From mboxrd@z Thu Jan 1 00:00:00 1970 From: architt@codeaurora.org (Archit Taneja) Date: Thu, 30 Mar 2017 15:19:05 +0530 Subject: [PATCH 1/2] drm/bridge: ti-tfp410: support hpd via gpio In-Reply-To: References: <2e47786ab3d04078ae70d0c4064f7c4d@rwthex-s1-b.rwth-ad.de> <093b4e9c0ae6413499e5bf8ec309fa41@rwthex-s1-b.rwth-ad.de> <6dfb2b66ec2a408dabe80d703f411ce0@rwthex-s1-b.rwth-ad.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/28/2017 07:02 PM, Jyri Sarha wrote: > On 03/27/17 08:58, Archit Taneja wrote: >> Hi, >> >> On 03/07/2017 03:21 AM, Christopher Spinrath wrote: >>> Hi Fabio, >>> >>> On 03/06/2017 10:46 PM, Fabio Estevam wrote: >>>> Hi Christopher, >>>> >>>> On Mon, Mar 6, 2017 at 6:40 PM, >>>> wrote: >>>>> From: Christopher Spinrath >>>>> >>>>> On some boards the hpd pin of a hdmi connector is wired up to a gpio >>>>> pin. Since in the DRM world the tfp410 driver is responsible for >>>>> handling the connector, add support for hpd gpios in this very driver. >>>>> >>>>> Signed-off-by: Christopher Spinrath >>>>> >>>>> --- >>>>> drivers/gpu/drm/bridge/ti-tfp410.c | 72 >>>>> ++++++++++++++++++++++++++++++++++++-- >>>> > ... >>> >> >> The patch looks good to me. >> >> Jyri, >> >> Is it possible for you to verify this on Beaglebone platform? >> > > If I read my BeagleBone DVI-D Cape docs right, it does not have the HPD > pin connected. At least it does not mention any gpio that could be used > for the purpose. So I can not easily test this patch in real world > situation. For what it is worth the patch looks ok to me too. Thanks for the review. I looked at the tfp410 data sheet[1], there isn't a HPD pin on the chip at all. My guess is that boards using tfp410 most likely have the HPD pin routed to the SoC from the HDMI connector (with a level shifter/shield in between). We would eventually need to move the both ddc and hpd stuff to a generic hdmi connector driver later on. I've queued this to drm-misc-next. [1]: http://www.ti.com/lit/ds/symlink/tfp410.pdf Archit > > Best regards, > Jyri > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project