From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D7F0CE7A88 for ; Sat, 23 Sep 2023 18:08:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eASxH2CCabB/jsDyy50rOCXcqKXtWkbq3Clhq2oXOKs=; b=FBZrSghhkk5YhS VBaWrMpw4Fk9ex5u4sBpFj0Pc+FA5W37Hdfdnefqc81eMJlCR1xD/HX4SlBPASBgfIqjNFFWhEsv4 UhYwwl5FAZLx3K40L0BcI/9o1DLKVt0ZWxgF8aFa7brE9o7mab4wPgVteVvJSkA2iu0grvuYe9AMe Pens7+gB4HVf89UuAstMoyR0UNDGHhDx6KMkPD7szoA6HMWWHmBYao/uRnswyBjIdxCdbWdkz21SA reAbGy1HXoBzaBR9iAa+KzpRBwXBCWcV9CrOV3gi5dt1Oz7DOqx6G972sv8BNqxVdV+UpyX0hjoSP eUHQiQhqXEs09hsbki0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qk73J-00BIv4-06; Sat, 23 Sep 2023 18:08:25 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qk73G-00BIuK-1o for linux-arm-kernel@lists.infradead.org; Sat, 23 Sep 2023 18:08:23 +0000 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-40537481094so36880715e9.0 for ; Sat, 23 Sep 2023 11:08:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1695492501; x=1696097301; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8RYcBLgXi2Usyjv8O8F7jTAVsfiwldX4rLiaCjIZSoY=; b=HNxs+PyMwiunM40I2h3XHQDy1+/yR9TlrNUZQ5h/gKpczTMrfxfnsH5jSXmneeKzck nxGZoGw5jewpsyvCo9e9yVRZOALTBYWSKOruL8b8woKokjidc9vGqoPGjPoScO0O5yEn NDyT39gVcLCsLzsPaJA7LDZxMAymo2psL1+3ZJWT2zge4z1RqC92gb30V6FoKcocI4Mq +dAObAQmo9faBReTVJLqJ7az0Qqh2+rTD65YKiuwYKRiTVJhbc16rPUGPyrFDXSGmIim I6m3cs3M7LyXBkAMdpFG7B+9E+8L9c/z5uohfC+GKdv4Shd/tnPt1QpBUvsMjZ5kbwUD /87A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695492501; x=1696097301; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8RYcBLgXi2Usyjv8O8F7jTAVsfiwldX4rLiaCjIZSoY=; b=mfBhJfHhkryj6hFE4xNmTLdZ9HFQCK+sGWSTpVs/Z6yfPg5VGxE3YhXVQyS8SYjY8m 12XF+hjFTPBlSqL0IUWfUtsCub77ra3OMPjdzW9ly7PzzzVX8Os4PvLRIWfCPF0GzTNn CdOeNHKuSQHwGGr08UMUS1lKiOX3Loi/53vpzyUlIGfrM2BC4E1wnVnKKEms3SpNwOQz 4hoWvRVrT6POGn88Gsa4OwMGglvWrUwS9hAG9jleD9hlECCzlUGUj1MM9Sl/cwiGcskf EGGYzZRwrYHdz03HJFcLOFYKzbwm8zcKT3oRlAoin8NR51a+V5xclXTUcx475jxuhZZ4 IO/w== X-Gm-Message-State: AOJu0YwNImmb8SPKe1kovEC+h9sDNny5q4DcqYIvFNPJn2XQHKfAcJ6N RPluHBW5NgkWLg9jA1Q0wLhK+w== X-Google-Smtp-Source: AGHT+IHgTWwCB7z8DnJNi+Zreo84MahTyxYFZoaRGkQRiDLl6+zBS9mKeFPkwSsb23KkMMbqczLODw== X-Received: by 2002:a5d:6b51:0:b0:31f:d95d:20a6 with SMTP id x17-20020a5d6b51000000b0031fd95d20a6mr2321405wrw.12.1695492500957; Sat, 23 Sep 2023 11:08:20 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.100]) by smtp.gmail.com with ESMTPSA id m12-20020a056000008c00b0031f3b04e7cdsm7440226wrx.109.2023.09.23.11.08.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Sep 2023 11:08:20 -0700 (PDT) Message-ID: Date: Sat, 23 Sep 2023 20:08:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 08/15] soc: mediatek: Add cmdq_pkt_finalize_loop to CMDQ driver Content-Language: en-US To: "Jason-JH.Lin" , Jassi Brar , Krzysztof Kozlowski , Rob Herring , Matthias Brugger , Chun-Kuang Hu , AngeloGioacchino Del Regno Cc: Conor Dooley , Jason-ch Chen , Johnson Wang , Elvis Wang , Singo Chang , Nancy Lin , Shawn Sung , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20230918192204.32263-1-jason-jh.lin@mediatek.com> <20230918192204.32263-9-jason-jh.lin@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20230918192204.32263-9-jason-jh.lin@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230923_110822_605906_29DFF99E X-CRM114-Status: GOOD ( 18.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 18/09/2023 21:21, Jason-JH.Lin wrote: > Add cmdq_pkt_finalize_loop to CMDQ driver. > > cmdq_pkt_finalize_loop appends end of command(EOC) instruction and > jump to start of command buffer instruction to make the command > buffer loopable. > > Signed-off-by: Jason-JH.Lin > --- > drivers/soc/mediatek/mtk-cmdq-helper.c | 23 +++++++++++++++++++++++ > include/linux/soc/mediatek/mtk-cmdq.h | 8 ++++++++ > 2 files changed, 31 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c > index 4be2a18a4a02..bbb127620bb3 100644 > --- a/drivers/soc/mediatek/mtk-cmdq-helper.c > +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c > @@ -475,6 +475,29 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt) > } > EXPORT_SYMBOL(cmdq_pkt_finalize); > > +int cmdq_pkt_finalize_loop(struct cmdq_pkt *pkt) > +{ > + struct cmdq_instruction inst = { {0} }; > + int err; > + > + /* insert EOC and generate IRQ for each command iteration */ > + inst.op = CMDQ_CODE_EOC; > + inst.value = CMDQ_EOC_IRQ_EN; > + err = cmdq_pkt_append_command(pkt, inst); > + if (err < 0) > + return err; > + > + /* JUMP to start of pkt */ > + err = cmdq_pkt_jump(pkt, pkt->pa_base); > + if (err < 0) > + return err; > + > + pkt->loop = true; > + > + return err; > +} > +EXPORT_SYMBOL(cmdq_pkt_finalize_loop); NAK. No users (and please carefully think before you answer that your other patch uses it). Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel