From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04D91CD11DF for ; Tue, 26 Mar 2024 10:11:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GRU/ymxUxNb7iaRJ7AlWyLRTrxTKiZ1cSOWh3byOTZE=; b=krOogy34pYxF2U HUI3sazsz5gx2EreFxrKlEs+monr/J85U12E5M48gIaFlf9Qs6ibNGC4MN9TVCfCnvFyr+wZ+Nq7l je6LFfkEpNRTJ8dSQvyIXLmvFF9Um9H4R2zUvw6MjlD73xbs3+5IT0xQP8VaJ45wBjcNOIDuWlie/ TOq+Z05BOUARQfW7CdmPQZ7KggPKaFNQFAyn/hQZGqtRMM8kMETUwg0LVBwhjKZ+mwmdx4ORH5cBO 4HS+khgSYy7UO4yjEXWKsJY2KaSi31aQfmNjbKkd++wedI3tznyCWQb2gDQZRWtXHnYIW1zX1SaLE 2LRQkBh/32klRetwXeog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rp3lx-00000003z6o-3s8N; Tue, 26 Mar 2024 10:11:13 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rp3l5-00000003yvi-1ivn for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2024 10:10:21 +0000 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-568c714a9c7so6178044a12.2 for ; Tue, 26 Mar 2024 03:10:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711447816; x=1712052616; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=JQnaSyYwl5rD6XVmt2ooNtpLwR2x205PFtPTu6yX330=; b=HRZzdb5zi945xsxNFwqfEb7+dtz3owlYb/nSI1S9BkgYgN06dpghYHpDHA9H2J0LDM Jxx0jMTrOE2NPlVRb4DQhdIlddX/NnM/tOQhNiYkNlig3PAHlzsPNcVp5QWAjwnii63y tPo03hUPn2qHPGKFmFaNQwG0ptY0Wh071V3FUD3hr2zp+yZzEYV8+VA+q8YYA6kvkRKr NppqP8bVXsie0HJSrgiCW78MckrSF3+cOsdhYlpmgvb9vpDozXiTRdU7DCayvNOmE9ux 0fgrN4Jt5xuBLE9rrt+zTrYLYq4E6leA2MoZxCMmFhQZWtz4/tZ7h8CRSi2DWySFthg9 2f/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711447816; x=1712052616; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JQnaSyYwl5rD6XVmt2ooNtpLwR2x205PFtPTu6yX330=; b=g/sppNBgdvH2zbO7MlS42zkC2/jwCzCsZDExHBbKr+7JwXMPnygVLKI+ALRBw/wsZ0 Dw89EZuAAFLhTufBFHl7rXUXoMtg/bFNPnFV7yZTduYQbTGV7TNjzo/fJzVQxVtNlCKP ziAXJWvcGwyNM7ysAucBqzHo5oxGwbSn+SWGWTvic4WCxko+oJ/9AOkzIMYoS6+q4Jat XlGy7cEYFQxGjGk9SGU/QLMGWYKljL3o/tbHIvbisP314NWlIY8FtCmTNjS5UaZl22Ul 86v3IljUooUz0SpgqEevuP60Hoemb3XEyYzJSCuDcaL3SewG+hu496tDaZDsG3LQ/rc8 vYBg== X-Forwarded-Encrypted: i=1; AJvYcCXLsju3PnhAK+LMj1FhgZE9FdqMJh3iN3Nin7XsLR4wlQAsJAJFGR3ccO6cBVfce/3GlWq1Ly1BF6AM6i0q9Y+hwvpTfa7hrIMWDIZCrjMBcQjOvwc= X-Gm-Message-State: AOJu0Yx2FeQ5tQrKmlqBgb6m25uAhGnHEcxgD+eCPHtkelxsfTkqVBJf CGdr8hMRx5wMmxJaNAKcG/yeZ68y+Ng0SYK3ujuXg71DaF0Q3PDib6TtOjCkA9vz+eJcm7n0wVK J X-Google-Smtp-Source: AGHT+IE5g6nuG88tlLs73Wec3cLhmWwqjWuu+9HPNJuUBta5wdqIVeW1wvlCSpOkxC0z+zMSsyj2Sw== X-Received: by 2002:a50:874a:0:b0:56b:defb:3b59 with SMTP id 10-20020a50874a000000b0056bdefb3b59mr6554522edv.19.1711447816609; Tue, 26 Mar 2024 03:10:16 -0700 (PDT) Received: from [192.168.92.47] (078088045141.garwolin.vectranet.pl. [78.88.45.141]) by smtp.gmail.com with ESMTPSA id ek27-20020a056402371b00b0056c2d0052c0sm293096edb.60.2024.03.26.03.10.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Mar 2024 03:10:16 -0700 (PDT) Message-ID: Date: Tue, 26 Mar 2024 11:10:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] ARM: dts: qcom: Add support for Motorola Moto G (2013) To: Stanislav Jakubek Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org References: Content-Language: en-US From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240326_031019_633194_965B8F81 X-CRM114-Status: GOOD ( 17.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25.03.2024 9:25 PM, Stanislav Jakubek wrote: > On Mon, Mar 25, 2024 at 08:28:27PM +0100, Konrad Dybcio wrote: >> On 24.03.2024 3:04 PM, Stanislav Jakubek wrote: >>> Add a device tree for the Motorola Moto G (2013) smartphone based >>> on the Qualcomm MSM8226 SoC. >>> >>> Initially supported features: >>> - Buttons (Volume Down/Up, Power) >>> - eMMC >>> - Hall Effect Sensor >>> - SimpleFB display >>> - TMP108 temperature sensor >>> - Vibrator >>> >>> Signed-off-by: Stanislav Jakubek >>> --- >> >> [...] >> >>> + hob-ram@f500000 { >>> + reg = <0x0f500000 0x40000>, >>> + <0x0f540000 0x2000>; >>> + no-map; >>> + }; >> >> Any reason it's in two parts? Should it be one contiguous region, or >> two separate nodes? >> >> lgtm otherwise > > Hi Konrad, I copied this from downstream as-is. > According to the downstream docs [1]: > > HOB RAM MMAP Device provides ability for userspace to access the > hand over block memory to read out modem related parameters. > > And the two regs are the "DHOB partition" and "SHOB partition". Oh right, motorola made some inventions here.. > > I suppose this is something Motorola (firmware?) specific (since the > downstream compatible is mmi,hob_ram [2]). > Should I split this into 2 nodes - dhob@f500000 and shob@f540000? Yes please and add the downstream txt link to the commit message in case somebody was curious down the line. Konrad _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel