From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93796EB64DA for ; Wed, 5 Jul 2023 21:15:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nTgat7VWc6o6Kgw9IlsPiT1jHbOGKa9/2gjV+PsO/q8=; b=pcocx/wqjXQRbF X52Jzl6SEXZkkvZnsLOi/onejNkMJss7hu+LUExc2HFvJ7LKBPiLdnH1ke2162vQ1DUFMbA3R/L7f LUfFG3aoPbbOOSETCpIt4C8LUDItYLhiDl0pi+QZ6zwPRfnfO1Zn/t/tjSXd6+fxZt6KbBdGYKn7n t2Bsgq1jYP0VJnZCR8zl5B73ewpxxcXi3wcixcsgycRFA7JJaW8uArseP1vp4wSA9PGyKruSaEMKI Wnp2HLIAF1UUJHrkPDrcGd1NIjLJ7XmrFhUMoC3cmZqDwVB+8x2c9r8yBw8LfM8Tfz9q0a9DxBdq0 1Qlw3iY9Mk6S+dzVPFxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qH9pr-00H6o5-16; Wed, 05 Jul 2023 21:14:51 +0000 Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qH9po-00H6mx-1U for linux-arm-kernel@lists.infradead.org; Wed, 05 Jul 2023 21:14:50 +0000 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2b6b98ac328so108811251fa.0 for ; Wed, 05 Jul 2023 14:14:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688591685; x=1691183685; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jXh1qp3VcG4x7VyPV9/wVqCpHKyRAdF4uZDV5Kq0EWU=; b=LGDjVr757p+L1QWlKXvJ/gAUWsdtaNcGemcGO48U8DQxQFg+HA0sACmPwdhmO6Yije yC9oGziCNSmcU/ONMcQ1ICN2sQKkFIg45jLS4QfTG/8NzfywfoTw/FJ/C7QUGnryOK9S O36ox78hhxZpsPBKKnGASV00AV/X4M36XsVwHeqGo5UbfkLRkgB5wGKs5BdB+D+4URwM mXpMOmat7KRkEhCMUWH36i9ZR7sSJqitAWImjG9cfhMRSIWAMxyeQoqi30aIdBhDNXN+ syXgAPgM8BrSHauYn1cLnIcB1aVoagbk6uSPxvKi6w2R+QcopLIZT2TCX2RxbtN7OkJP 2xgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688591685; x=1691183685; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jXh1qp3VcG4x7VyPV9/wVqCpHKyRAdF4uZDV5Kq0EWU=; b=Hz2lGKJI0t/0rHcameomxJTFRF3GV3hcVpn+28t2rq/7dmlOJx5hcLLZxGi+ED1Zpc W3lH5+ZjwM083hpsMSl3/P0d7jzJpHl67Lm5mcAHbjW38HRtphrdEkAuX1Kv9eiJMP79 OjlHmjB22F0zFBU+C7ro6M2zQpyS5qsVWh/TTZZhlVV8bHLUPSvAITe2bUC2aB7+6QT1 v8+KSvEiTUVo/iobv3IiIbosGj0R6I8+op4csKn+idlo1IJlLZQpLXb70c7qLEKXhOut wHTVLMV9vbIBsLRgF4eC7iZtZIjD4oZGpFWDqgQSCjb0kJQnEw99QmBULdFL1J/2arSu NYKQ== X-Gm-Message-State: ABy/qLYuYuJvdsvzdCX9ILmTNP+U6ywul70WkCk4Pq3f024HANt8UmPI kD+6UcUWh68CVMrRuM2lLvYTKEv62Xv2Oj+yD8I= X-Google-Smtp-Source: APBJJlGCrgsEZyfPbyg9iwta9Ar+mKIE43BkXWms0nT6cArFKi8I2D+CP8m4idO2s/cRmXDRYobs1g== X-Received: by 2002:a2e:9159:0:b0:2b6:a3b0:f4d3 with SMTP id q25-20020a2e9159000000b002b6a3b0f4d3mr14294522ljg.26.1688591684965; Wed, 05 Jul 2023 14:14:44 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id v19-20020a2e9613000000b002b6d781b60esm3446940ljh.82.2023.07.05.14.14.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jul 2023 14:14:44 -0700 (PDT) Message-ID: Date: Thu, 6 Jul 2023 00:14:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH V7 1/2] dt-bindings: firmware: bootstats: Add the dtschema Content-Language: en-GB To: Rob Herring , Krzysztof Kozlowski Cc: Souradeep Chowdhury , Andy Gross , Konrad Dybcio , Krzysztof Kozlowski , Bjorn Andersson , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Sibi Sankar , Rajendra Nayak References: <968fb5d3-6cd8-7850-47e7-682e26f9ee5f@quicinc.com> <20230705193012.GA1642540-robh@kernel.org> From: Dmitry Baryshkov In-Reply-To: <20230705193012.GA1642540-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230705_141448_527259_6BCF656E X-CRM114-Status: GOOD ( 25.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/07/2023 22:30, Rob Herring wrote: > On Wed, Jul 05, 2023 at 11:34:35AM +0200, Krzysztof Kozlowski wrote: >> On 05/07/2023 10:33, Souradeep Chowdhury wrote: >>>>> + $ref: /schemas/types.yaml#/definitions/string-array >>>>> + >>>>> + abl-time: >>>>> + description: The property to store the duration of abl in ms. >>>>> + $ref: /schemas/types.yaml#/definitions/string-array >>>> >>>> I have no clue what this entire binding is about. Nothing can bind to >>>> it, no usage explained. Properties are not used to "store the duration". >>>> This does not look like suitable for DT, drop entire binding. >>> >>> This binding was created as per the suggestion on version 6 of the patch >>> by Arnd. The idea was that these 2 devicetree properties will be used to >>> populate the bootstat values from the bootloader and exposed to the user >>> via /sys/firmware/devicetree/ directly. >>> >>> Details in the link below:- >>> >>> https://lore.kernel.org/lkml/7d397e67-5d56-4975-98af-1ac9746c07f4@app.fastmail.com/T/#mbdc9ad95fcbb5ad7b56c6996a3933899b42d982c >>> >>> Can you suggest any alternative way to represent this as a binding? >> >> Then you should clearly state in the binding how this is going to be >> used and who is going to populate it. Not only in the binding but also >> in commit msg which currently has 0 rationale and answers to "why". Your >> commit msg explained only "what", which is usually obvious and much less >> important. Your commit should stand on its own and should clearly >> explain why we need this feature at all, what problem it solves. >> >> And before you claim that there is some discussion under link or some >> cover letter - these do not matter. Commit and bindings matter. >> >> What's more, I don't think that Arnd's advice is correct here - DT is >> suppose to describe hardware or firmware. These properties are coming >> from firmware but they are not describing any firmware or hardware >> characteristics. Instead they are debugging of current boot status. >> >> I will leave the decision on that for Rob, however anyway binding is >> very vague and incorrect, so I would expect he will come with the same >> concerns regardless whether it is suitable to DT or is not. > > My main concern here is not so much having this info in DT, but whether > it's just the start of various properties. Either because there's already > more data and these are just the 2 things you care about now, or because > once we enable this it's an invitation to add more properties. > > Boot timing information seems like something multiple platforms might > want and only having 2 stages isn't extensible. I preferred the previous implementation idea, where the Linux driver will parse firmware data, instead of bootloader doing something for us. Not to mention that that approach would allow us to get boot time stats on older platforms, without waiting (indefinitely) for the platform vendor to update the bootloader. > > Rob -- With best wishes Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel