From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45FCBCD6E5D for ; Sun, 31 May 2026 13:16:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FKsBAzVe+VcsfLgI6bNArQFtB7x/VHsQAwX5l82S9tg=; b=FwE0sOUUjVOhhP5YV31RHGxswL +VjKMr3nhO2UP2L1WLNRQckpD7n9YyxAqnCi8FZdrjCbpDUl1L94j4QbPJxBwx4V0Bxv4Ev8Ynqn/ GlSzPPjwZpe6Vgwv45hnw5WK/RKg+EDK2XS+fg3osgucmr03baLrbfJHMPsJAeHpxsfPqES5ABN4d H1+qR7OhCi5ZmWrmPUUBdwIWXJxyQ1hu1bwNhU66WnOdFO3gQQ/jNCHrR6FLwkfp0BL4NO8VLLdi3 v+l4VhZtbHt2smTmWUlwfO1h4MYCyIois2ezddV72pPXSKKlt4XBeoSdaFwFBLkQ6p0haMODCPYtH fFCPgZ9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wTg1C-00000009cJW-3Sd9; Sun, 31 May 2026 13:15:54 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wTg1A-00000009cJA-18FJ for linux-arm-kernel@lists.infradead.org; Sun, 31 May 2026 13:15:53 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 3154442D6D; Sun, 31 May 2026 13:15:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE3D21F00898; Sun, 31 May 2026 13:15:47 +0000 (UTC) Message-ID: Date: Sun, 31 May 2026 23:15:43 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 03/11] m68k: mcf5441x: initialize DAC clocks by iio DAC driver name To: Angelo Dureghello , Geert Uytterhoeven , Steven King , Arnd Bergmann , Maxime Coquelin , Alexandre Torgue , Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-iio@vger.kernel.org References: <20260522-wip-stmark2-dac-v3-0-16be0ad35a67@baylibre.com> <20260522-wip-stmark2-dac-v3-3-16be0ad35a67@baylibre.com> Content-Language: en-US From: Greg Ungerer In-Reply-To: <20260522-wip-stmark2-dac-v3-3-16be0ad35a67@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260531_061552_357178_EFF0EC13 X-CRM114-Status: GOOD ( 15.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Angelo, On 23/5/26 07:20, Angelo Dureghello wrote: > From: Angelo Dureghello > > Later in this patchset, the mcf54415 DAC driver is added. > Considering some other different ColdFire cpu DACs exists, the DAC driver > is named as "mcf54415_dac", related to the mcf5441x family SoCs with > DACs (mcf54415/6/7/8). > > So updating DAC CLKDEDV_INIT with proper driver name. > > Signed-off-by: Angelo Dureghello > --- > Changes in v2: > - none > Changes in v3 > - roll back clock names as they was originally > --- > arch/m68k/coldfire/m5441x.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/m68k/coldfire/m5441x.c b/arch/m68k/coldfire/m5441x.c > index 5b5e09ecf487..b02ca2eb55a4 100644 > --- a/arch/m68k/coldfire/m5441x.c > +++ b/arch/m68k/coldfire/m5441x.c > @@ -106,8 +106,8 @@ static struct clk_lookup m5411x_clk_lookup[] = { > CLKDEV_INIT("mcfpit.3", NULL, &__clk_0_35), > CLKDEV_INIT("mcfeport.0", NULL, &__clk_0_36), > CLKDEV_INIT("mcfadc.0", NULL, &__clk_0_37), > - CLKDEV_INIT("mcfdac.0", NULL, &__clk_0_38), > - CLKDEV_INIT("mcfdac.1", NULL, &__clk_0_39), > + CLKDEV_INIT("mcf54415_dac.0", NULL, &__clk_0_38), > + CLKDEV_INIT("mcf54415_dac.1", NULL, &__clk_0_39), I thought after the last discussion on this that we would not change these clock names? Regards Greg > CLKDEV_INIT("mcfrtc.0", NULL, &__clk_0_42), > CLKDEV_INIT("mcfsim.0", NULL, &__clk_0_43), > CLKDEV_INIT("mcfusb-otg.0", NULL, &__clk_0_44), >