From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD97BC7EE2C for ; Tue, 30 May 2023 14:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xupgcUQ+tITNbZrDvRSFURcCWRfBbbYufW0LGv/Sx1Q=; b=fyCtHcsayEvGRS 9ElciPlP6UUFsqFRTJ7lzhJ2djvbGJ5xAqfbJd28QfkTu+p/zsM4AAqRVHQ5jkKW0XXgOgP2v4Ikc rD5oqlbIoNJDp7wGOzVxtII2EZqbGHC+qnpK9kvMv6YS6lzzNc1cSvYN6gnQqRxhg7ecAzMfWvFEy uLZbBx9w4GVjpihl+/b5DvJlqcPMAWWji8tlR2XqFWAsIin46wSrIVKTxw5wNaxLeOIPUyV4CD0i7 TKIDN2TW+LVPJqs8RZacF3m1X+QhtO97zE9g0oixLW31Zfh5pxUMpCt4OSVxrSVIf96FKsd/3zT2+ mqlvFO2F8W36PAnO4qMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q40o7-00EJ1S-0l; Tue, 30 May 2023 14:58:43 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q40o4-00EJ0X-0i for linux-arm-kernel@lists.infradead.org; Tue, 30 May 2023 14:58:41 +0000 Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-5149aafef44so3932184a12.0 for ; Tue, 30 May 2023 07:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685458716; x=1688050716; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Y5roT10laz2CzdwcuNGZ1IEx+qEHueK0Fd53T1e6Xfk=; b=m8nB5byu9FRrq2xdOz/5PN01pQ542DAaRl8HaAx/xEegXEiP1+BIKz3/DBtds6G7L0 YG9UbTW13AEpez9bXniZcEIOPeP8NvNNZuR5XTzAHSZHsR8OTo3+sjOycud5gTd2NCiv 9wAteWijVbfam4t1GhAk8rh7tPXqA9gnOwgeZ/2x0FWwlwhXOg3jzI5f3j9f0hywMN3j ftodd438uGD7V9Gih/siMbZ0FCeQidy8MDMIHgQNTK8kTVmkAr/7HAovSI5TYsEzcQ6i Y6xUggAy1HmKBar/swX+Xcg+uKPJZZS+JQa7hdGyH0j8m8aoiYpkP+U997QBCwr13Rfg bDhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685458716; x=1688050716; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Y5roT10laz2CzdwcuNGZ1IEx+qEHueK0Fd53T1e6Xfk=; b=Ux5LMGgyJC5bXmtbspIv0YVbLjgfLJ4vSkTcvqPlyrnAHMyG1nTiUK29iFoSI4x+3f 30aY28B+5Ev1jlHKqKNdPWAGoaeBefusUZ79mdRTO0s1IhTBtJqIFJwA2AdX8bjFaufg BELJUk1hjMpBt6BOdsgwInsoeX7Ar2MZXJfZ5HuaYFw3k+yY1LYCKxPae2AmHh67YfTf 3ILp/a8nk6IDZwqplwbcM3v7g6G0itOLas7TimWEmr3PnvwiaVK52jtPZvjyQi5AaLSW 6+EU/zcZiGJ058pmKhMzUpZTxjNKIbe7pjnxu7omVUUouvN17ZRtVn0JbHLV0BVSP5nw YkTA== X-Gm-Message-State: AC+VfDy8tM7zhtgTrCeNv7zXGQahqLlGAr4VFRln5LSfNb+BmZQ5XPWQ 0S2inz1aOPPuUZmhJ39Jc0epwQ== X-Google-Smtp-Source: ACHHUZ7Be8Z+NCpE61J4jKqCk67UtnMimLo2D/Jlbqp1FUziK8Rm1KdNBdY1sQ5h++vhPhdtE2COeQ== X-Received: by 2002:a05:6402:1645:b0:50d:8991:d1b9 with SMTP id s5-20020a056402164500b0050d8991d1b9mr1853579edx.8.1685458716495; Tue, 30 May 2023 07:58:36 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id a21-20020aa7d755000000b0050bc041d2a8sm4425119eds.15.2023.05.30.07.58.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 May 2023 07:58:35 -0700 (PDT) Message-ID: Date: Tue, 30 May 2023 16:58:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/2] dt-bindings: i2c: imx-lpi2c: Add bus recovery example Content-Language: en-US To: carlos.song@nxp.com, aisheng.dong@nxp.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, Anson.Huang@nxp.com Cc: xiaoning.wang@nxp.com, haibo.chen@nxp.com, linux-imx@nxp.com, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230529074302.3612294-1-carlos.song@nxp.com> <20230529074302.3612294-2-carlos.song@nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20230529074302.3612294-2-carlos.song@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230530_075840_260429_13584BBA X-CRM114-Status: GOOD ( 17.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29/05/2023 09:43, carlos.song@nxp.com wrote: > From: Clark Wang > > Add i2c bus recovery configuration example. Why? That's just example... also with coding style issue. > > Signed-off-by: Clark Wang > Signed-off-by: Carlos Song > --- > .../devicetree/bindings/i2c/i2c-imx-lpi2c.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml > index 4656f5112b84..62ee457496e4 100644 > --- a/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml > +++ b/Documentation/devicetree/bindings/i2c/i2c-imx-lpi2c.yaml > @@ -58,6 +58,16 @@ properties: > power-domains: > maxItems: 1 > > + pinctrl-names: > + minItems: 1 > + maxItems: 3 What's the benefit of this? Entries should be defined but without it is not really helpful. Anyway not explained in commit msg. > + > + scl-gpios: > + maxItems: 1 > + > + sda-gpios: > + maxItems: 1 You don't need these two. Anyway not explained in commit msg. > + > required: > - compatible > - reg > @@ -70,6 +80,7 @@ examples: > - | > #include > #include > + #include > > i2c@40a50000 { > compatible = "fsl,imx7ulp-lpi2c"; > @@ -78,4 +89,9 @@ examples: > interrupts = ; > clocks = <&clks IMX7ULP_CLK_LPI2C7>, > <&clks IMX7ULP_CLK_NIC1_BUS_DIV>; > + pinctrl-names = "default","gpio"; Missing space. > + pinctrl-0 = <&pinctrl_i2c>; > + pinctrl-1 = <&pinctrl_i2c_recovery>; > + scl-gpios = <&gpio5 14 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > + sda-gpios = <&gpio5 15 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > }; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel