From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8DB5CCD188 for ; Thu, 9 Oct 2025 09:10:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uytNIvQFTAiG0HJ5uUMyriM7ytJogyKw+q/SDSNIslc=; b=QzBJnJ8Cih+ol048ZIrPSrPI0z iA6ghT4OZoIWcI7Zt1K1unMkOrRfV+iDsQ2GxSD2PNT/ExU/c4N4Ek0phEuwIDycE50YUiejUZMLu gwHTFf6EhbPUgM52j4e7JWpW1Jvoh1YHCEOJf9YAN80ZgoxtDUqKotK1xN4se4fll2rWFsqjEA1VP RV8uFr87VkJvWbbQY3u27BzHoToZw1ZvRO3HrmSBf3cyakHDuuH+806qggZnq2FWznjzEs/yDTQMH dzMleUKfYbbg8zZ25V4Z9rDa+nnQqD6PD8kJBMovkwUkmJtpT6O8O/EQ6xxAzEL2w6KVaSDvo7JMG FZwG6BzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v6met-00000005bt2-2V5u; Thu, 09 Oct 2025 09:09:59 +0000 Received: from bali.collaboradmins.com ([2a01:4f8:201:9162::2]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v6meq-00000005bsD-3LFC; Thu, 09 Oct 2025 09:09:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1760000994; bh=AcqsttLfCgUKRY2r8lxvg8B5ELVPZ326fY9rGZgWLBk=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=m/mU67tdjO3bz+vCLFSWfRxnNfwPHSAIihfAM8Vx/4cXTKE9Gwv5OyV7SsQ/uPFj4 sBs/NevXn8898ySOSvA1whDo/gxDWzOBnMpnxC6Grb51YuaI2Rf1G/d1GvoTp6XaIP tMEBsH/6tNzydUa4b49Q5VRDA5YT7hqcSbHZXm5cS94ZiwKrCGIiTjBLUVlEwQOtJl oi3dCJKUItFpqsEYUSOB5/M0GZTzD9KOz2UCAmVQWcy/bAbt2wR9LbLTiY3O90rhfF w2bqDRewhtokrF2Q9EZwlMBuDxRf9dXMGy1ZHmcraumPgrUVX/1z91D83pcHMEP7qU Grz/Igl6rgLWg== Received: from [10.40.0.100] (185-67-175-126.lampert.tv [185.67.175.126]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mriesch) by bali.collaboradmins.com (Postfix) with ESMTPSA id 1EC2B17E1060; Thu, 9 Oct 2025 11:09:53 +0200 (CEST) Message-ID: Date: Thu, 9 Oct 2025 11:09:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 05/17] media: dt-bindings: add rockchip rk3568 mipi csi-2 receiver To: Sakari Ailus Cc: Mehdi Djait , Maxime Chevallier , =?UTF-8?Q?Th=C3=A9o_Lebrun?= , Thomas Petazzoni , Gerald Loacker , Bryan O'Donoghue , Markus Elfring , Laurent Pinchart , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Kever Yang , Nicolas Dufresne , Sebastian Reichel , Collabora Kernel Team , Paul Kocialkowski , Alexander Shiyan , Val Packett , Rob Herring , Philipp Zabel , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Bryan O'Donoghue References: <20240220-rk3568-vicap-v11-0-af0eada54e5d@collabora.com> <20240220-rk3568-vicap-v11-5-af0eada54e5d@collabora.com> Content-Language: en-US From: Michael Riesch In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251009_020957_062235_F90866F3 X-CRM114-Status: GOOD ( 18.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sakari, On 10/7/25 22:00, Sakari Ailus wrote: > Hi Michael, > > On Wed, Sep 17, 2025 at 05:38:45PM +0200, Michael Riesch via B4 Relay wrote: >> From: Michael Riesch >> >> Add documentation for the Rockchip RK3568 MIPI CSI-2 Receiver. >> >> Signed-off-by: Michael Riesch >> Reviewed-by: Bryan O'Donoghue >> Signed-off-by: Michael Riesch >> --- >> .../bindings/media/rockchip,rk3568-mipi-csi.yaml | 144 +++++++++++++++++++++ >> MAINTAINERS | 6 + >> 2 files changed, 150 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi.yaml >> new file mode 100644 >> index 000000000000..8cbab93b4b85 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi.yaml >> @@ -0,0 +1,144 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/rockchip,rk3568-mipi-csi.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Rockchip RK3568 MIPI CSI-2 Receiver >> + >> +maintainers: >> + - Michael Riesch >> + >> +description: >> + The Rockchip RK3568 MIPI CSI-2 Receiver is a CSI-2 bridge with one input port >> + and one output port. It receives the data with the help of an external >> + MIPI PHY (C-PHY or D-PHY) and passes it to the Rockchip RK3568 Video Capture >> + (VICAP) block. >> + >> +properties: >> + compatible: >> + oneOf: >> + - items: >> + - enum: >> + - rockchip,rk3588-mipi-csi >> + - const: rockchip,rk3568-mipi-csi >> + - const: rockchip,rk3568-mipi-csi >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + items: >> + - description: Interrupt that signals changes in CSI2HOST_ERR1. >> + - description: Interrupt that signals changes in CSI2HOST_ERR2. >> + >> + interrupt-names: >> + items: >> + - const: irq1 >> + - const: irq2 >> + >> + clocks: >> + maxItems: 1 >> + >> + phys: >> + maxItems: 1 >> + description: MIPI C-PHY or D-PHY. >> + >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + >> + properties: >> + port@0: >> + $ref: /schemas/graph.yaml#/$defs/port-base >> + unevaluatedProperties: false >> + description: Input port node. Connect to e.g., a MIPI CSI-2 image sensor. >> + >> + properties: >> + endpoint: >> + $ref: video-interfaces.yaml# >> + unevaluatedProperties: false >> + >> + properties: >> + bus-type: >> + enum: [1, 4] >> + >> + data-lanes: >> + minItems: 1 >> + maxItems: 4 >> + >> + required: >> + - bus-type >> + - data-lanes >> + >> + port@1: >> + $ref: /schemas/graph.yaml#/properties/port >> + description: Output port connected to a RK3568 VICAP port. > > As the VICAP port appears to be a DVP/Bt.565 receiver, also this output can > presumably be connected elsewhere, too. Not quite. One VICAP port is the DVP (and can receive BT.656, amongst others), but there may be one or more ports that are connected to the MIPI CSI-2 receiver(s). See the VICAP binding. > Either way, aren't signal polarity or sampling related properties relevant > here, too, and perhaps more so for the VICAP bindings? No, I don't think so. This is some internal HW connection. No idea how Rockchip glued the MIPI CSI-2 receiver(s) to the corresponding VICAP port(s), and there is nothing one could tweak or adjust or configure... Best regards, Michael > See e.g. > Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml . > >> + >> + required: >> + - port@0 >> + - port@1 >> + >> + power-domains: >> + maxItems: 1 >> + >> + resets: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - phys >> + - ports >> + - power-domains >> + - resets >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + #include >> + #include >> + >> + soc { >> + interrupt-parent = <&gic>; >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> + csi: csi@fdfb0000 { >> + compatible = "rockchip,rk3568-mipi-csi"; >> + reg = <0x0 0xfdfb0000 0x0 0x10000>; >> + interrupts = , >> + ; >> + interrupt-names = "irq1", "irq2"; >> + clocks = <&cru PCLK_CSI2HOST1>; >> + phys = <&csi_dphy>; >> + power-domains = <&power RK3568_PD_VI>; >> + resets = <&cru SRST_P_CSI2HOST1>; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + csi_in: port@0 { >> + reg = <0>; >> + >> + csi_input: endpoint { >> + bus-type = ; >> + data-lanes = <1 2 3 4>; >> + remote-endpoint = <&imx415_output>; >> + }; >> + }; >> + >> + csi_out: port@1 { >> + reg = <1>; >> + >> + csi_output: endpoint { >> + remote-endpoint = <&vicap_mipi_input>; >> + }; >> + }; >> + }; >> + }; >> + }; >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 4c39b9fd80bb..2ac4b7a5b255 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -21797,6 +21797,12 @@ F: Documentation/userspace-api/media/v4l/metafmt-rkisp1.rst >> F: drivers/media/platform/rockchip/rkisp1 >> F: include/uapi/linux/rkisp1-config.h >> >> +ROCKCHIP MIPI CSI-2 RECEIVER DRIVER >> +M: Michael Riesch >> +L: linux-media@vger.kernel.org >> +S: Maintained >> +F: Documentation/devicetree/bindings/media/rockchip,rk3568-mipi-csi.yaml >> + >> ROCKCHIP RK3568 RANDOM NUMBER GENERATOR SUPPORT >> M: Daniel Golle >> M: Aurelien Jarno >> >