From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 853BCC636D4 for ; Mon, 13 Feb 2023 14:20:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FalrAHGRMdFs4e42/RLAZI1sJRWLhtmaQ21/+Sklw5E=; b=mfr+arsCo1S1Ka iOvj1tjklSidw15Rl+kQsTKHxb5AcTslz5qEhdCRYXeTBX5+j4xQ+TN0x5qiApSV0sdmoo/iJ+dtr h9ClaU0L5EGOJ+dap9kOQBVqNfDOgoyz8kR28ZIIo6tIo2WF0+ikwyZncOihGb/pHjs6zqv72Qr2x hSlftk1es32x/P2k9HRdpC47BRTQSZlvL1f6nSlYyC+ydgIZEtL47oyaj5SWLeQD9MjnctxGdcsyS TbX6IARtlH5vLg1/dF4J7ABt4q3pm1jILRtjeVIUwQ/+cg7y/7s67DVhBHT+wV+vESr+CVha5Fg/4 iyFPSloCWi9CHfbqIn3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRZg8-00Ewrb-UO; Mon, 13 Feb 2023 14:19:37 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRZg5-00Ewqb-QZ for linux-arm-kernel@lists.infradead.org; Mon, 13 Feb 2023 14:19:35 +0000 Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31DE3CMn017464; Mon, 13 Feb 2023 14:19:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=1afekj1atS6B7HHZ4RVIl8IvPNbTbmPEAs1NhaFYRLM=; b=S6zEKUguj8+EXZUxYQDBgvSB9dGCEe5CnaQPFFt/NrNLaovcGyi/9oBqXrFK48mw04Jy nVRIJ87P7GLabD5rBnUDetzijCmwN421neKvQxI8J/zMF0dfQR/Nn0ZUceXVm+iWqlQv LPr7/qRVu5+vOmev520NNFuOzikKVAIWHLHrkr0SvNbUuSJ25MG21if6nzNoOyLp6OzD 9GgOAxeL8EIC/g+auLaQpeGF6cpCV5XoEF5OtHrEG9kujgDNVZyRa0y4qtiyixu3iI8r oJwvPNNTAjrXFs7wvOA7kZYAvmhddSC4S8ZpekHHfCJF0fgHxH7CC5t3bGRxzQiKRgYO hg== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3nqpmmg11w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Feb 2023 14:19:12 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 31DEJBI5012083 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Feb 2023 14:19:11 GMT Received: from [10.50.58.188] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 13 Feb 2023 06:19:02 -0800 Message-ID: Date: Mon, 13 Feb 2023 19:48:54 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH V3 4/7] pinctrl: qcom: Add IPQ9574 pinctrl driver To: Bjorn Andersson CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20230130125528.11509-1-quic_devipriy@quicinc.com> <20230130125528.11509-5-quic_devipriy@quicinc.com> <20230208231412.yqp3rvokvmbb7ixi@ripper> Content-Language: en-US From: Devi Priya In-Reply-To: <20230208231412.yqp3rvokvmbb7ixi@ripper> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: kGUNY5cHUYA7GmZTQqdqsb8JBsXsBBvo X-Proofpoint-GUID: kGUNY5cHUYA7GmZTQqdqsb8JBsXsBBvo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-13_09,2023-02-13_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 priorityscore=1501 suspectscore=0 adultscore=0 impostorscore=0 bulkscore=0 clxscore=1015 mlxscore=0 mlxlogscore=606 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302130129 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230213_061933_917899_68771316 X-CRM114-Status: GOOD ( 14.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thanks Bjorn for taking time to review the patch On 2/9/2023 4:44 AM, Bjorn Andersson wrote: > On Mon, Jan 30, 2023 at 06:25:25PM +0530, devi priya wrote: >> +static const struct msm_pingroup ipq9574_groups[] = { >> + PINGROUP(0, sdc_data, qspi_data, qdss_traceclk_b, _, _, _, _, _, _), >> + PINGROUP(1, sdc_data, qspi_data, qdss_tracectl_b, _, _, _, _, _, _), >> + PINGROUP(2, sdc_data, qspi_data, qdss_tracedata_b, _, _, _, _, _, _), >> + PINGROUP(3, sdc_data, qspi_data, qdss_tracedata_b, _, _, _, _, _, _), >> + PINGROUP(4, sdc_cmd, qspi_cs, qdss_tracedata_b, _, _, _, _, _, _), >> + PINGROUP(5, sdc_clk, qspi_clk, qdss_tracedata_b, _, _, _, _, _, >> + _), > > Please avoid line wrapping these, it just makes it hard to read. Yes, we have addressed this comment part of V7 series https://lore.kernel.org/linux-arm-kernel/20230206103337.21000-5-quic_devipriy@quicinc.com/ > > [..] >> +}; >> + >> +/* Reserving GPIO59 for controlling the QFPROM LDO regulator */ > > This seems like a property of the board, please use gpio-reserved-ranges > in the DT node instead. As the GPIO is forbidden on SoC IPQ9574, we have moved it to the pinctrl driver based on the suggestions received in V1 series https://lore.kernel.org/linux-arm-kernel/675ed9f7-da31-6206-5089-1db22025ef4b@linaro.org/ > > Thanks, > Bjorn Best Regards, Devi Priya _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel