From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75EDBC00A5A for ; Thu, 19 Jan 2023 17:12:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZGWE9eGnWL6fGI/zod0P+eCsaqSGn15m0zWGCXoIq1E=; b=Ecc2FaeWb5c5UM j0azKFDdQGyTNTox6A+s60ENJO5KXvPoHR1RzdfnZ7ShjEeck1Wtjd0ipbqSkicsqrMpp5QrFuEkI l3of9Zf4gL97QDODAPLhSHJzSJ7u/iRi/xmAUcWcUFtq1wiksLh2WY15InLRxPlxBljIBMX9ZV2Uc RZafs0Wh48GIdZ8BMFw6tA5CAuly/T6fs+7vA0jm3Pt6TtCc1M+OXXo/BUseglv7epFUl53lns/jr sagMelChMKltInjQOXaAB041k6N12TUmdoXxOrrr3Uvnug+zwbQavVVIYpGzT7b57L+d8KaaNmsje nbWZeS9GySi/Gcl9zMBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIYRS-006BY8-A2; Thu, 19 Jan 2023 17:11:10 +0000 Received: from smtp-fw-80007.amazon.com ([99.78.197.218]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pIYR1-006BIj-4a for linux-arm-kernel@lists.infradead.org; Thu, 19 Jan 2023 17:10:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1674148243; x=1705684243; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=8RD2NMlTLbb1fDHF7JSh91WOGDcsE0IX4cxLuRZNagI=; b=vbdKBps8qHXHKWynbCcpDC1iQzEROMzrQCI6o32boqmn3gaTR1r2Cl7p Wc71VQKKTLtOadFy8OEcJ3wm+N+69DEzBxTYqPhThdS05OK2EqB/eBCNH 3VB6w0D+z1B/4Cn1KWEaCT6Ul6imTjBXbSUD0sBvkY+/SKuIuEo52LrbX E=; X-IronPort-AV: E=Sophos;i="5.97,229,1669075200"; d="scan'208";a="172897248" Received: from pdx4-co-svc-p1-lb2-vlan3.amazon.com (HELO email-inbound-relay-pdx-2c-m6i4x-f7c754c9.us-west-2.amazon.com) ([10.25.36.214]) by smtp-border-fw-80007.pdx80.corp.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2023 17:10:39 +0000 Received: from EX13MTAUWC002.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-pdx-2c-m6i4x-f7c754c9.us-west-2.amazon.com (Postfix) with ESMTPS id 152C741CE6; Thu, 19 Jan 2023 17:10:39 +0000 (UTC) Received: from EX19D003UWC001.ant.amazon.com (10.13.138.144) by EX13MTAUWC002.ant.amazon.com (10.43.162.240) with Microsoft SMTP Server (TLS) id 15.0.1497.45; Thu, 19 Jan 2023 17:10:38 +0000 Received: from freeip.amazon.com (10.43.162.56) by EX19D003UWC001.ant.amazon.com (10.13.138.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1118.7; Thu, 19 Jan 2023 17:10:37 +0000 Date: Thu, 19 Jan 2023 11:10:29 -0600 From: Geoff Blake To: Robin Murphy CC: Will Deacon , Mark Rutland , , Subject: RE: [PATCH] perf/arm-cmn: Add shutdown routine In-Reply-To: <7071a073-08f5-104b-f10f-e1013d1b5390@arm.com> Message-ID: References: <2bb86e97-6cef-700e-70ed-4f303da10fd9@amazon.com> <20221215180039.18035-1-blakgeof@amazon.com> <7071a073-08f5-104b-f10f-e1013d1b5390@arm.com> MIME-Version: 1.0 X-Originating-IP: [10.43.162.56] X-ClientProxiedBy: EX13D41UWC001.ant.amazon.com (10.43.162.107) To EX19D003UWC001.ant.amazon.com (10.13.138.144) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230119_091044_486210_BA71D0C3 X-CRM114-Status: UNSURE ( 9.65 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 19 Jan 2023, Robin Murphy wrote: > If you have a convincing argument that returning IRQ_NONE for unexpected > spurious interrupts is a real and important concern, then please propose > a general solution, because if it matters for arm-cmn then it matters > for hundreds of other drivers too, by rough estimate: > > $ git grep -l IRQ_NONE '*.c' | xargs git grep -L IRQF_SHARED | wc -l > 834 The general solution for IRQ_NONE exists in the layer above the driver, it complains with a visible warning that something might be wrong and then moves on. Nothing more is needed. Your shutdown routine that flips DT_EN in CMN_DT_DTC_CTL is sufficient, as after some testing it solves the problem with left over IRQs for my kexec use case. -Geoff _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel