From: Matthias Brugger <matthias.bgg@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
arm@kernel.org, soc@kernel.org, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 18/40] ARM: dts: mediatek: align gpio-key node names with dtschema
Date: Fri, 17 Jun 2022 12:44:32 +0200 [thread overview]
Message-ID: <edc8933a-5433-8fe9-f5ab-5efeaa6cde78@gmail.com> (raw)
In-Reply-To: <20220616005333.18491-18-krzysztof.kozlowski@linaro.org>
On 16/06/2022 02:53, Krzysztof Kozlowski wrote:
> The node names should be generic and DT schema expects certain pattern
> (e.g. with key/button/switch).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Applied, thanks!
> ---
> arch/arm/boot/dts/mt7623a-rfb-emmc.dts | 4 ++--
> arch/arm/boot/dts/mt7623a-rfb-nand.dts | 4 ++--
> arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 4 ++--
> arch/arm/boot/dts/mt7623n-rfb-emmc.dts | 4 ++--
> arch/arm/boot/dts/mt7629-rfb.dts | 4 ++--
> 5 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm/boot/dts/mt7623a-rfb-emmc.dts b/arch/arm/boot/dts/mt7623a-rfb-emmc.dts
> index 13c86936d1c8..e8b4b6d30d19 100644
> --- a/arch/arm/boot/dts/mt7623a-rfb-emmc.dts
> +++ b/arch/arm/boot/dts/mt7623a-rfb-emmc.dts
> @@ -45,13 +45,13 @@ gpio-keys {
> pinctrl-names = "default";
> pinctrl-0 = <&key_pins_a>;
>
> - factory {
> + button-factory {
> label = "factory";
> linux,code = <BTN_0>;
> gpios = <&pio 256 GPIO_ACTIVE_LOW>;
> };
>
> - wps {
> + button-wps {
> label = "wps";
> linux,code = <KEY_WPS_BUTTON>;
> gpios = <&pio 257 GPIO_ACTIVE_HIGH>;
> diff --git a/arch/arm/boot/dts/mt7623a-rfb-nand.dts b/arch/arm/boot/dts/mt7623a-rfb-nand.dts
> index 88d8f0b2f4c2..61f5da68d4b0 100644
> --- a/arch/arm/boot/dts/mt7623a-rfb-nand.dts
> +++ b/arch/arm/boot/dts/mt7623a-rfb-nand.dts
> @@ -45,13 +45,13 @@ gpio-keys {
> pinctrl-names = "default";
> pinctrl-0 = <&key_pins_a>;
>
> - factory {
> + button-factory {
> label = "factory";
> linux,code = <BTN_0>;
> gpios = <&pio 256 GPIO_ACTIVE_LOW>;
> };
>
> - wps {
> + button-wps {
> label = "wps";
> linux,code = <KEY_WPS_BUTTON>;
> gpios = <&pio 257 GPIO_ACTIVE_HIGH>;
> diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> index 027c1b0c6a98..5008115d2494 100644
> --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> @@ -91,13 +91,13 @@ gpio-keys {
> pinctrl-names = "default";
> pinctrl-0 = <&key_pins_a>;
>
> - factory {
> + button-factory {
> label = "factory";
> linux,code = <BTN_0>;
> gpios = <&pio 256 GPIO_ACTIVE_LOW>;
> };
>
> - wps {
> + button-wps {
> label = "wps";
> linux,code = <KEY_WPS_BUTTON>;
> gpios = <&pio 257 GPIO_ACTIVE_HIGH>;
> diff --git a/arch/arm/boot/dts/mt7623n-rfb-emmc.dts b/arch/arm/boot/dts/mt7623n-rfb-emmc.dts
> index 1b9b9a8145a7..bf67a8e9be59 100644
> --- a/arch/arm/boot/dts/mt7623n-rfb-emmc.dts
> +++ b/arch/arm/boot/dts/mt7623n-rfb-emmc.dts
> @@ -60,13 +60,13 @@ gpio-keys {
> pinctrl-names = "default";
> pinctrl-0 = <&key_pins_a>;
>
> - factory {
> + button-factory {
> label = "factory";
> linux,code = <BTN_0>;
> gpios = <&pio 256 GPIO_ACTIVE_LOW>;
> };
>
> - wps {
> + button-wps {
> label = "wps";
> linux,code = <KEY_WPS_BUTTON>;
> gpios = <&pio 257 GPIO_ACTIVE_HIGH>;
> diff --git a/arch/arm/boot/dts/mt7629-rfb.dts b/arch/arm/boot/dts/mt7629-rfb.dts
> index eb536cbebd9b..84e14bee7235 100644
> --- a/arch/arm/boot/dts/mt7629-rfb.dts
> +++ b/arch/arm/boot/dts/mt7629-rfb.dts
> @@ -23,13 +23,13 @@ chosen {
> gpio-keys {
> compatible = "gpio-keys";
>
> - reset {
> + button-reset {
> label = "factory";
> linux,code = <KEY_RESTART>;
> gpios = <&pio 60 GPIO_ACTIVE_LOW>;
> };
>
> - wps {
> + button-wps {
> label = "wps";
> linux,code = <KEY_WPS_BUTTON>;
> gpios = <&pio 58 GPIO_ACTIVE_LOW>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-17 10:46 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220616005224.18391-1-krzysztof.kozlowski@linaro.org>
2022-06-16 0:53 ` [PATCH v3 07/40] arm64: dts: freescale: align gpio-key node names with dtschema Krzysztof Kozlowski
2022-06-16 0:53 ` [PATCH v3 08/40] arm64: dts: freescale: align led " Krzysztof Kozlowski
2022-06-16 0:53 ` [PATCH v3 09/40] arm64: dts: hisilicon: align gpio-key " Krzysztof Kozlowski
2022-06-20 11:14 ` (subset) " Krzysztof Kozlowski
2022-06-21 2:29 ` Wei Xu
2022-06-16 0:53 ` [PATCH v3 10/40] arm64: dts: hisilicon: correct gpio-keys properties Krzysztof Kozlowski
2022-06-20 11:14 ` (subset) " Krzysztof Kozlowski
2022-06-21 2:28 ` Wei Xu
2022-06-16 0:53 ` [PATCH v3 11/40] arm64: dts: marvell: align gpio-key node names with dtschema Krzysztof Kozlowski
2022-06-22 8:32 ` Krzysztof Kozlowski
2022-06-27 8:42 ` Krzysztof Kozlowski
2022-06-27 9:15 ` (subset) " Krzysztof Kozlowski
2022-06-16 0:53 ` [PATCH v3 12/40] arm64: dts: marvell: armada-3720: align lednode " Krzysztof Kozlowski
2022-06-27 9:15 ` (subset) " Krzysztof Kozlowski
2022-06-16 0:53 ` [PATCH v3 13/40] ARM: dts: marvell: align gpio-key node " Krzysztof Kozlowski
2022-06-27 9:15 ` (subset) " Krzysztof Kozlowski
2022-06-16 0:53 ` [PATCH v3 14/40] ARM: dts: marvell: correct gpio-keys properties Krzysztof Kozlowski
2022-06-27 9:15 ` (subset) " Krzysztof Kozlowski
2022-06-16 0:53 ` [PATCH v3 15/40] arm64: dts: mediatek: align gpio-key node names with dtschema Krzysztof Kozlowski
2022-06-17 10:43 ` Matthias Brugger
2022-06-16 0:53 ` [PATCH v3 16/40] arm64: dts: mediatek: mt7622-bananapi-bpi-r64: align led " Krzysztof Kozlowski
2022-06-17 10:43 ` Matthias Brugger
2022-06-16 0:53 ` [PATCH v3 17/40] arm64: dts: mediatek: mt7622-rfb1: correct gpio-keys properties Krzysztof Kozlowski
2022-06-17 10:41 ` Matthias Brugger
2022-06-17 23:18 ` Krzysztof Kozlowski
2022-06-16 0:53 ` [PATCH v3 18/40] ARM: dts: mediatek: align gpio-key node names with dtschema Krzysztof Kozlowski
2022-06-17 10:44 ` Matthias Brugger [this message]
2022-06-16 0:53 ` [PATCH v3 26/40] arm64: dts: rockchip: " Krzysztof Kozlowski
2022-06-22 8:34 ` Krzysztof Kozlowski
2022-06-22 12:52 ` Heiko Stuebner
2022-06-16 0:53 ` [PATCH v3 27/40] ARM: " Krzysztof Kozlowski
2022-06-16 0:53 ` [PATCH v3 28/40] ARM: dts: rockchip: rk3288-tinker: correct gpio-keys properties Krzysztof Kozlowski
2022-06-16 0:53 ` [PATCH v3 29/40] arm64: dts: ti: align gpio-key node names with dtschema Krzysztof Kozlowski
2022-06-16 0:53 ` [PATCH v3 30/40] arm64: dts: xilinx: " Krzysztof Kozlowski
2022-06-23 8:10 ` Michal Simek
2022-06-16 0:53 ` [PATCH v3 31/40] ARM: " Krzysztof Kozlowski
2022-06-23 8:10 ` Michal Simek
2022-06-16 0:53 ` [PATCH v3 36/40] ARM: dts: aspeed: " Krzysztof Kozlowski
2022-06-27 8:49 ` Krzysztof Kozlowski
2022-07-05 11:42 ` Krzysztof Kozlowski
2022-07-05 11:45 ` (subset) " Krzysztof Kozlowski
2022-06-16 0:53 ` [PATCH v3 37/40] ARM: dts: aspeed: correct gpio-keys properties Krzysztof Kozlowski
2022-07-05 11:45 ` (subset) " Krzysztof Kozlowski
2022-06-16 0:53 ` [PATCH v3 38/40] ARM: dts: at91: align gpio-key node names with dtschema Krzysztof Kozlowski
2022-06-16 7:41 ` Claudiu.Beznea
2022-06-27 9:15 ` (subset) " Krzysztof Kozlowski
2022-06-16 0:53 ` [PATCH v3 39/40] ARM: dts: at91: correct gpio-keys properties Krzysztof Kozlowski
2022-06-27 9:15 ` (subset) " Krzysztof Kozlowski
2022-06-16 0:53 ` [PATCH v3 40/40] ARM: dts: at91: drop unneeded status from gpio-keys Krzysztof Kozlowski
2022-06-27 9:16 ` (subset) " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edc8933a-5433-8fe9-f5ab-5efeaa6cde78@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).