Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ilkka Koskinen <ilkka@os.amperecomputing.com>
To: TAKANO Mitsuhiro <takano32@gmail.com>
Cc: linux-perf-users@vger.kernel.org,
	 Arnaldo Carvalho de Melo <acme@kernel.org>,
	 Namhyung Kim <namhyung@kernel.org>,
	James Clark <james.clark@linaro.org>,
	 Ian Rogers <irogers@google.com>,
	John Garry <john.garry@linux.dev>,
	 Ilkka Koskinen <ilkka@os.amperecomputing.com>,
	 linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] perf vendor events arm64 AmpereOneX: Fix misspelled PublicDescription keys
Date: Tue, 17 Nov 2026 13:11:38 -0800 (PST)	[thread overview]
Message-ID: <edccb772-bbc0-66e5-4606-91dc80b2972a@os.amperecomputing.com> (raw)
In-Reply-To: <20261113065253.746615-1-takano32@gmail.com>



On Fri, 13 Nov 2026, TAKANO Mitsuhiro wrote:

> Sixteen of the 28 entries in mmu.json spell PublicDescription as
> "PublicDescrition"; the other 12 spell it correctly.  jevents.py reads
> only the keys it asks for by name, so those 16 fields are dead.
>
> Fixing them does not change the perf list output: every one of the 16
> entries has a BriefDescription with the same text, and jevents.py drops
> the long description when it equals the brief one (jevents.py:405).
> Running jevents.py for arm64 before and after this change gives a
> byte-identical generated string table (1580383 bytes both times).
>
> The file becomes self-consistent again, and the field works if the brief
> text is ever changed on its own.  No text, name, code or expression
> changes.
>
> Written with Hermes Agent, an LLM assistant; the author reviewed it and
> ran the generator as described.  perf was built, not run against
> hardware.
>
> Signed-off-by: TAKANO Mitsuhiro <takano32@gmail.com>


Thanks for the patch!

Acked-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>

Cheers, Ilkka

> ---
> v2: rebased on 7.4-rc2.  The arm64 string table generated with
>    jevents.py is byte identical before and after the change
>    (1580383 bytes), measured again on this base.
>
> .../arch/arm64/ampere/ampereonex/mmu.json     | 32 +++++++++----------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/mmu.json b/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/mmu.json
> index 66d83b680651..9457f9be4ecc 100644
> --- a/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/mmu.json
> +++ b/tools/perf/pmu-events/arch/arm64/ampere/ampereonex/mmu.json
> @@ -30,37 +30,37 @@
>         "BriefDescription": "Data TLB translation cache hit on S2L2 walk cache entry"
>     },
>     {
> -        "PublicDescrition": "Data TLB translation cache hit on S2L1 walk cache entry",
> +        "PublicDescription": "Data TLB translation cache hit on S2L1 walk cache entry",
>         "EventCode": "0xd805",
>         "EventName": "MMU_D_TRANS_CACHE_HIT_S2L1_WALK",
>         "BriefDescription": "Data TLB translation cache hit on S2L1 walk cache entry"
>     },
>     {
> -        "PublicDescrition": "Data TLB translation cache hit on S2L0 walk cache entry",
> +        "PublicDescription": "Data TLB translation cache hit on S2L0 walk cache entry",
>         "EventCode": "0xd806",
>         "EventName": "MMU_D_TRANS_CACHE_HIT_S2L0_WALK",
>         "BriefDescription": "Data TLB translation cache hit on S2L0 walk cache entry"
>     },
>     {
> -        "PublicDescrition": "Data-side S1 page walk cache lookup",
> +        "PublicDescription": "Data-side S1 page walk cache lookup",
>         "EventCode": "0xd807",
>         "EventName": "MMU_D_S1_WALK_CACHE_LOOKUP",
>         "BriefDescription": "Data-side S1 page walk cache lookup"
>     },
>     {
> -        "PublicDescrition": "Data-side S1 page walk cache refill",
> +        "PublicDescription": "Data-side S1 page walk cache refill",
>         "EventCode": "0xd808",
>         "EventName": "MMU_D_S1_WALK_CACHE_REFILL",
>         "BriefDescription": "Data-side S1 page walk cache refill"
>     },
>     {
> -        "PublicDescrition": "Data-side S2 page walk cache lookup",
> +        "PublicDescription": "Data-side S2 page walk cache lookup",
>         "EventCode": "0xd809",
>         "EventName": "MMU_D_S2_WALK_CACHE_LOOKUP",
>         "BriefDescription": "Data-side S2 page walk cache lookup"
>     },
>     {
> -        "PublicDescrition": "Data-side S2 page walk cache refill",
> +        "PublicDescription": "Data-side S2 page walk cache refill",
>         "EventCode": "0xd80a",
>         "EventName": "MMU_D_S2_WALK_CACHE_REFILL",
>         "BriefDescription": "Data-side S2 page walk cache refill"
> @@ -90,61 +90,61 @@
>         "BriefDescription": "Level 2 instruction translation buffer allocation"
>     },
>     {
> -        "PublicDescrition": "Instruction TLB translation cache hit on S1L2 walk cache entry",
> +        "PublicDescription": "Instruction TLB translation cache hit on S1L2 walk cache entry",
>         "EventCode": "0xd901",
>         "EventName": "MMU_I_TRANS_CACHE_HIT_S1L2_WALK",
>         "BriefDescription": "Instruction TLB translation cache hit on S1L2 walk cache entry"
>     },
>     {
> -        "PublicDescrition": "Instruction TLB translation cache hit on S1L1 walk cache entry",
> +        "PublicDescription": "Instruction TLB translation cache hit on S1L1 walk cache entry",
>         "EventCode": "0xd902",
>         "EventName": "MMU_I_TRANS_CACHE_HIT_S1L1_WALK",
>         "BriefDescription": "Instruction TLB translation cache hit on S1L1 walk cache entry"
>     },
>     {
> -        "PublicDescrition": "Instruction TLB translation cache hit on S1L0 walk cache entry",
> +        "PublicDescription": "Instruction TLB translation cache hit on S1L0 walk cache entry",
>         "EventCode": "0xd903",
>         "EventName": "MMU_I_TRANS_CACHE_HIT_S1L0_WALK",
>         "BriefDescription": "Instruction TLB translation cache hit on S1L0 walk cache entry"
>     },
>     {
> -        "PublicDescrition": "Instruction TLB translation cache hit on S2L2 walk cache entry",
> +        "PublicDescription": "Instruction TLB translation cache hit on S2L2 walk cache entry",
>         "EventCode": "0xd904",
>         "EventName": "MMU_I_TRANS_CACHE_HIT_S2L2_WALK",
>         "BriefDescription": "Instruction TLB translation cache hit on S2L2 walk cache entry"
>     },
>     {
> -        "PublicDescrition": "Instruction TLB translation cache hit on S2L1 walk cache entry",
> +        "PublicDescription": "Instruction TLB translation cache hit on S2L1 walk cache entry",
>         "EventCode": "0xd905",
>         "EventName": "MMU_I_TRANS_CACHE_HIT_S2L1_WALK",
>         "BriefDescription": "Instruction TLB translation cache hit on S2L1 walk cache entry"
>     },
>     {
> -        "PublicDescrition": "Instruction TLB translation cache hit on S2L0 walk cache entry",
> +        "PublicDescription": "Instruction TLB translation cache hit on S2L0 walk cache entry",
>         "EventCode": "0xd906",
>         "EventName": "MMU_I_TRANS_CACHE_HIT_S2L0_WALK",
>         "BriefDescription": "Instruction TLB translation cache hit on S2L0 walk cache entry"
>     },
>     {
> -        "PublicDescrition": "Instruction-side S1 page walk cache lookup",
> +        "PublicDescription": "Instruction-side S1 page walk cache lookup",
>         "EventCode": "0xd907",
>         "EventName": "MMU_I_S1_WALK_CACHE_LOOKUP",
>         "BriefDescription": "Instruction-side S1 page walk cache lookup"
>     },
>     {
> -        "PublicDescrition": "Instruction-side S1 page walk cache refill",
> +        "PublicDescription": "Instruction-side S1 page walk cache refill",
>         "EventCode": "0xd908",
>         "EventName": "MMU_I_S1_WALK_CACHE_REFILL",
>         "BriefDescription": "Instruction-side S1 page walk cache refill"
>     },
>     {
> -        "PublicDescrition": "Instruction-side S2 page walk cache lookup",
> +        "PublicDescription": "Instruction-side S2 page walk cache lookup",
>         "EventCode": "0xd909",
>         "EventName": "MMU_I_S2_WALK_CACHE_LOOKUP",
>         "BriefDescription": "Instruction-side S2 page walk cache lookup"
>     },
>     {
> -        "PublicDescrition": "Instruction-side S2 page walk cache refill",
> +        "PublicDescription": "Instruction-side S2 page walk cache refill",
>         "EventCode": "0xd90a",
>         "EventName": "MMU_I_S2_WALK_CACHE_REFILL",
>         "BriefDescription": "Instruction-side S2 page walk cache refill"
>
> base-commit: 7475ea8b58616b33c04afb976cf0fbaad9dd63fb
> -- 
> 2.53.0
>
>
>


      reply	other threads:[~2026-11-17 21:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-08 18:38 [PATCH] perf vendor events arm64 AmpereOneX: Fix misspelled PublicDescription keys TAKANO Mitsuhiro
2026-11-09 10:24 ` James Clark
2026-11-10 19:42   ` TAKANO Mitsuhiro
2026-11-11 10:16     ` James Clark
2026-11-11 13:35       ` TAKANO Mitsuhiro
2026-11-11 14:03         ` James Clark
2026-11-13  6:40           ` TAKANO Mitsuhiro
2026-11-13  6:52 ` [PATCH v2] " TAKANO Mitsuhiro
2026-11-17 21:11   ` Ilkka Koskinen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=edccb772-bbc0-66e5-4606-91dc80b2972a@os.amperecomputing.com \
    --to=ilkka@os.amperecomputing.com \
    --cc=acme@kernel.org \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=john.garry@linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=takano32@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox