From: andriy.shevchenko@linux.intel.com (Andy Shevchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/3] serial: 8250: export serial8250_do_set_divisor()
Date: Tue, 10 Jul 2018 16:56:28 +0300 [thread overview]
Message-ID: <ee2443ab6b413e9d7f0148e8916b0bd0d4924375.camel@linux.intel.com> (raw)
In-Reply-To: <20180710111327.072584c0@xhacker.debian>
On Tue, 2018-07-10 at 11:13 +0800, Jisheng Zhang wrote:
> Some drivers could call serial8250_do_set_divisor() to complete its
> own set_divisor routine. Export this symbol for code reusing.
>
I dunno Greg's preferences here, but it could be merged with patch 1.
In any case,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
for this part.
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
> ---
> drivers/tty/serial/8250/8250_port.c | 5 +++--
> include/linux/serial_8250.h | 3 +++
> 2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_port.c
> b/drivers/tty/serial/8250/8250_port.c
> index ce0dc17f18ee..945f8dc2d50f 100644
> --- a/drivers/tty/serial/8250/8250_port.c
> +++ b/drivers/tty/serial/8250/8250_port.c
> @@ -2580,8 +2580,8 @@ static unsigned char
> serial8250_compute_lcr(struct uart_8250_port *up,
> return cval;
> }
>
> -static void serial8250_do_set_divisor(struct uart_port *port,
> unsigned int baud,
> - unsigned int quot, unsigned int
> quot_frac)
> +void serial8250_do_set_divisor(struct uart_port *port, unsigned int
> baud,
> + unsigned int quot, unsigned int
> quot_frac)
> {
> struct uart_8250_port *up = up_to_u8250p(port);
>
> @@ -2612,6 +2612,7 @@ static void serial8250_do_set_divisor(struct
> uart_port *port, unsigned int baud,
> serial_port_out(port, 0x2, quot_frac);
> }
> }
> +EXPORT_SYMBOL_GPL(serial8250_do_set_divisor);
>
> static void serial8250_set_divisor(struct uart_port *port, unsigned
> int baud,
> unsigned int quot, unsigned int
> quot_frac)
> diff --git a/include/linux/serial_8250.h b/include/linux/serial_8250.h
> index 76b9db71e489..18e21427bce4 100644
> --- a/include/linux/serial_8250.h
> +++ b/include/linux/serial_8250.h
> @@ -160,6 +160,9 @@ extern void serial8250_do_shutdown(struct
> uart_port *port);
> extern void serial8250_do_pm(struct uart_port *port, unsigned int
> state,
> unsigned int oldstate);
> extern void serial8250_do_set_mctrl(struct uart_port *port, unsigned
> int mctrl);
> +extern void serial8250_do_set_divisor(struct uart_port *port,
> unsigned int baud,
> + unsigned int quot,
> + unsigned int quot_frac);
> extern int fsl8250_handle_irq(struct uart_port *port);
> int serial8250_handle_irq(struct uart_port *port, unsigned int iir);
> unsigned char serial8250_rx_chars(struct uart_8250_port *up, unsigned
> char lsr);
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-07-10 13:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 3:09 [PATCH v4 0/3] serial: 8250_dw: add fractional divisor support Jisheng Zhang
2018-07-10 3:12 ` [PATCH v4 1/3] serial: 8250: introduce get_divisor() and set_divisor() hook Jisheng Zhang
2018-07-10 3:13 ` [PATCH v4 2/3] serial: 8250: export serial8250_do_set_divisor() Jisheng Zhang
2018-07-10 13:56 ` Andy Shevchenko [this message]
2018-07-10 3:15 ` [PATCH v4 3/3] serial: 8250_dw: add fractional divisor support Jisheng Zhang
2018-07-10 16:19 ` Andy Shevchenko
2018-07-11 6:41 ` Jisheng Zhang
2018-07-11 14:23 ` Andy Shevchenko
2018-07-11 7:11 ` [PATCH v5 " Jisheng Zhang
2018-07-11 11:31 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee2443ab6b413e9d7f0148e8916b0bd0d4924375.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).