From: "Rao, Appana Durga Kedareswara" <appanad@amd.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Appana Durga Kedareswara rao
<appana.durga.kedareswara.rao@amd.com>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <michal.simek@xilinx.com>,
<derek.kiernan@xilinx.com>, <dragan.cvetic@xilinx.com>,
<arnd@arndb.de>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <git@amd.com>,
<git@xilinx.com>,
Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
Subject: Re: [PATCH v2 4/4] drivers: misc: Add Support for TMR Inject IP
Date: Wed, 3 Aug 2022 12:05:46 +0530 [thread overview]
Message-ID: <ee2f6680-5dbf-665f-a5aa-d607262c3365@amd.com> (raw)
In-Reply-To: <YuOiHGBaVOSGzD7V@kroah.com>
Hi Greg,
On 29/07/22 2:32 pm, Greg KH wrote:
> On Fri, Jul 29, 2022 at 01:43:47PM +0530, Rao, Appana Durga Kedareswara wrote:
>> Hi Greg,
>>
>> Thanks for the review.
>>
>> On 28/07/22 7:54 pm, Greg KH wrote:
>>> On Wed, Jul 20, 2022 at 11:30:16AM +0530, Appana Durga Kedareswara rao wrote:
>>>> From: Appana Durga Kedareswara rao <appana.durga.rao@xilinx.com>
>>>>
>>>> The Triple Modular Redundancy(TMR) provides functional fault injection by
>>>> changing selected MicroBlaze instructions, which provides the possibility
>>>> to verify that the TMR subsystem error detection and fault recovery logic
>>>> is working properly, provided sysfs entries which allow the user to inject
>>>> a fault.
>>>
>>> We already have a fault-injection api, why are you not using that?
>>>
>>
>> Inorder to inject the error using TMR inject IP, The API
>> which injects the error should be executed from Processor LMB,
>> below sysfs entry calls microblaze core API xmb_inject_err()
>> which switches the processor to real mode and injects the error,
>> Please find the code corresponds to xmb_inject_err() API here:
>> https://www.spinics.net/lists/arm-kernel/msg991888.html
>
> You did not answer the question. Why are you not using the in-kernel
> fault injection userspace api and why have you created your own?
will update the driver to use fault injection user space API in next
version.
>
> Also, please use lore.kernel.org links when possible.
Sure
Regards,
Kedar.
>
> thanks,
>
> greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-08-03 6:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 6:00 [PATCH v2 0/4] drivers: misc: Add support for TMR Manager and Inject IPs Appana Durga Kedareswara rao
2022-07-20 6:00 ` [PATCH v2 1/4] dt-bindings: misc: tmr-manager: Add device-tree binding for TMR Manager Appana Durga Kedareswara rao
2022-07-20 6:15 ` Krzysztof Kozlowski
2022-07-20 6:00 ` [PATCH v2 2/4] drivers: misc: Add Support " Appana Durga Kedareswara rao
2022-07-28 14:27 ` Greg KH
2022-07-29 8:13 ` Rao, Appana Durga Kedareswara
2022-07-20 6:00 ` [PATCH v2 3/4] dt-bindings: misc: tmr-inject: Add device-tree binding for TMR Inject Appana Durga Kedareswara rao
2022-07-20 6:15 ` Krzysztof Kozlowski
2022-07-20 8:26 ` Michal Simek
2022-07-20 9:35 ` Krzysztof Kozlowski
2022-07-20 12:09 ` Michal Simek
2022-07-20 12:21 ` Krzysztof Kozlowski
2022-07-20 12:35 ` Michal Simek
2022-07-20 13:21 ` Rao, Appana Durga Kedareswara
2022-07-20 6:00 ` [PATCH v2 4/4] drivers: misc: Add Support for TMR Inject IP Appana Durga Kedareswara rao
2022-07-28 14:24 ` Greg KH
2022-07-29 8:13 ` Rao, Appana Durga Kedareswara
2022-07-29 9:02 ` Greg KH
2022-08-03 6:35 ` Rao, Appana Durga Kedareswara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee2f6680-5dbf-665f-a5aa-d607262c3365@amd.com \
--to=appanad@amd.com \
--cc=appana.durga.kedareswara.rao@amd.com \
--cc=appana.durga.rao@xilinx.com \
--cc=arnd@arndb.de \
--cc=derek.kiernan@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@xilinx.com \
--cc=git@amd.com \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).