From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDE4BC433F5 for ; Sat, 7 May 2022 09:27:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/Q+rLCKo0+l5CdAl5f/Gkpx0VnCcaI4/cP+hcR1cJn8=; b=klDkR4/1B60c2t 0esOHXVp0sxOMLVy68P+3NFDLYmmlIovfce3/CptMIb2PqdNrtv6TKwkcW/KSS4PcjaZc+ajdmLRG PWVToBRvjisr/T4Qhsi2v//7JRFPh1MkEX6i1uHvESUPZh5crvhOaf+BHXJUTbmLI9AdCL7xmIWKh rqU0AEkfgZvN0J7l9u5tSJInslwuhJnQ1/X4p2+C8sj74GaZe8UDBEfTJacNs+i2CJ4sZk3MPiUIk jc6RHvR0aK8SIlxMH5VsEFYPo8y0mnkzlptSgtFybZhCScRGIFRXA5p6TpvamMzVA3WoO0j/VTBiK VOCNRja2WzjB2LrBCzSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnGi4-006d0N-5C; Sat, 07 May 2022 09:26:44 +0000 Received: from mout.kundenserver.de ([217.72.192.74]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nnGi0-006czE-HY; Sat, 07 May 2022 09:26:42 +0000 Received: from [192.168.1.107] ([37.4.249.94]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1N7Qp1-1ntC1L1FW9-017pmc; Sat, 07 May 2022 11:26:30 +0200 Message-ID: Date: Sat, 7 May 2022 11:26:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] clk: bcm2835: fix bcm2835_clock_choose_div Content-Language: en-US To: Maxime Ripard Cc: Florian Fainelli , Ray Jui , Scott Branden , Michael Turquette , Stephen Boyd , bcm-kernel-feedback-list@broadcom.com, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220428183010.1635248-1-stefan.wahren@i2se.com> <20220503145804.b2xz4etzc6kpr3fk@houat> From: Stefan Wahren In-Reply-To: <20220503145804.b2xz4etzc6kpr3fk@houat> X-Provags-ID: V03:K1:TISiMMp8m/FV5qPKCF9n1osclmv+q2upYrueyJsVP9zlp6+v8u/ dsk6fIGXhBVsiBaNwaN7QJ48EC/uL3zPRJWA39tnzUGtlQFN7ttJcUSnR6/Q8D2EHeTzVnH /KeQPVdsml1o24kI9JF7ZSud1R8Kdy34Xx5oQ5upZ/WKT8E45VvmsiHAnDUfoVkOs7Zdm9H FyCOQ26WpBkYBYI3vTT/Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:D0xWmPYIj00=:0PpTuUQc4n477rQ1kB0JQE DpBvR39rz31Z2qR4SJGWF05OkxhYTkuwhyO/NsYlI4g7I1Qu8zjsrKPz8vZZL3BpQoPUZUdNR v+fLBC4JezVsRvjoCLxEPREHJ55rObO7f/fnOWis6y9SxgFudWG6yXDghEBZu+H81gWIGxi+Q /YTGbVW1gIUxqd4a/5Vz1ktirIfad6ukiUQo65+nY2vZx/aoryGQ+DVINSs/+3m39fgzYJA02 lmKvHOv/wxeMIpMe8DpQmv4A8UJx4DszXTxj7vcaRi0WLlMuxoJuPh0TWVtaMxP5Ah7QSjNHt t4sKGQ2i8XEtHrYM5VvRrNNJz7vvTVrdngteWYY8o55DYlNfp3nQzqbl87DjJAd4jKFTCueUv A9VQ+oBcQbf2X40OpAaYJCLprM6EzbLGxwEUW0dn7KBmhNCj6Zm9KQ4DpW3HQiwHCeujo9XqI SUTl5D9R4NvIK3gjmHVf79vf33CA/92BxwsilIkoEU286zNUas8oRdKQsYnKDhb7ev3mfXpbq qBvGB+vNiGS58G1rYH1skLUTV7HPNBIW3ikGgsrhlVV19xjPg+Lu9P2G2OUEoc/P5legIt88m kLbwrkiX6DNq2BZ1wpDhVOa3Bnlc5Ao0zdJJZJ7CvYvrZM2Gy59/LC87PQf3M5W12Bx94sb0Y wFR3Bn9EIcWbSyJGi/vKS8nws7Z+zCHdfbX0orz1KJANrAkWZ5iNw82yH0+1EgbU2ivXPalBJ 3PVR7DOW/dJEvpIo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220507_022640_946553_0A5107C1 X-CRM114-Status: GOOD ( 10.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 03.05.22 um 16:58 schrieb Maxime Ripard: > Hi, > > On Thu, Apr 28, 2022 at 08:30:10PM +0200, Stefan Wahren wrote: >> The commit 09e3b18ca5de ("clk: bcm2835: Remove unused variable") >> accidentially breaks the behavior of bcm2835_clock_choose_div() and >> booting of Raspberry Pi. The removed do_div macro call had side effects, >> so we need to restore it. >> >> Fixes: 09e3b18ca5de ("clk: bcm2835: Remove unused variable") >> Signed-off-by: Stefan Wahren > I only found this patch after debugging why the HDMI driver was > returning -EINVAL at probe on -rc5. > > Acked-by: Maxime Ripard > Tested-by: Maxime Ripard Thanks, does this go via clk-fixes? > > Thanks! > Maxime _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel