[PATCH v2 0/3] Add support for exynos5250-manta (Google Nexus 10)

[PATCH v2 0/3] Add support for exynos5250-manta (Google Nexus 10)

[Lukas Timmermann]

This patch series adds initial support for the google-manta board, known
as Google Nexus 10 to users. The device is powered by
the Exynos 5250 SoC. The notification led driver (as3668) is already 
(tho not applied) in the kernel mailing list and can be found here:
https://lore.kernel.org/linux-leds/20251125114015.355487-1-linux@timmermann.space/

The first two patches add the necessary device tree files and
bindings, while the last patch makes a small modification to
allow CPU1 to boot, as it requires a call to it's underlying firmware.

This first iteration only provides basic support to get the board
up and running and usable via UART and with WiFi support. We will upstream additional 
features in future patches. All patches have been tested on real hardware.

Signed-off-by: Lukas Timmermann <linux@timmermann.space>
---
Alexandre Marquet (3):
      dt-bindings: ARM: samsung: Add Google Manta (Nexus 10)
      ARM: dts: exynos: Add Google Manta (Nexus 10)
      ARM: samsung: exynos5250: Allow CPU1 to boot

 .../bindings/arm/samsung/samsung-boards.yaml       |   1 +
 arch/arm/boot/dts/samsung/Makefile                 |   1 +
 arch/arm/boot/dts/samsung/exynos5250-manta.dts     | 516 +++++++++++++++++++++
 arch/arm/mach-exynos/firmware.c                    |   4 +-
 4 files changed, 520 insertions(+), 2 deletions(-)
---
base-commit: 6a23ae0a96a600d1d12557add110e0bb6e32730c
change-id: 20251125-google-manta-79545e179d10

Best regards,
-- 
Lukas Timmermann <linux@timmermann.space>

[PATCH v2 1/3] dt-bindings: ARM: samsung: Add Google Manta (Nexus 10)

[Lukas Timmermann]

From: Alexandre Marquet <tb@a-marquet.fr>

Add the Google Nexus 10 board to documentation.

Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
Signed-off-by: Lukas Timmermann <linux@timmermann.space>
---
 Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
index f8e20e602c20..13d97257f070 100644
--- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
+++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml
@@ -117,6 +117,7 @@ properties:
       - description: Exynos5250 based boards
         items:
           - enum:
+              - google,manta                    # Google Manta (Nexus 10)
               - google,snow-rev5                # Google Snow Rev 5+
               - google,spring                   # Google Spring
               - insignal,arndale                # Insignal Arndale

-- 
2.52.0

[PATCH v2 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

[Lukas Timmermann]

From: Alexandre Marquet <tb@a-marquet.fr>

Manta is the code name for Google Nexus 10, and was manufactured by
Samsung with their Exynos5250 SoC.
This patch adds initial device-tree file for this board.

Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
Co-developed-by: Lukas Timmermann <linux@timmermann.space>
Signed-off-by: Lukas Timmermann <linux@timmermann.space>
---
 arch/arm/boot/dts/samsung/Makefile             |   1 +
 arch/arm/boot/dts/samsung/exynos5250-manta.dts | 516 +++++++++++++++++++++++++
 2 files changed, 517 insertions(+)

diff --git a/arch/arm/boot/dts/samsung/Makefile b/arch/arm/boot/dts/samsung/Makefile
index 7becf36656b1..e0143ee8c82d 100644
--- a/arch/arm/boot/dts/samsung/Makefile
+++ b/arch/arm/boot/dts/samsung/Makefile
@@ -26,6 +26,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
 	exynos4412-trats2.dtb
 dtb-$(CONFIG_ARCH_EXYNOS5) += \
 	exynos5250-arndale.dtb \
+	exynos5250-manta.dtb \
 	exynos5250-smdk5250.dtb \
 	exynos5250-snow.dtb \
 	exynos5250-snow-rev5.dtb \
diff --git a/arch/arm/boot/dts/samsung/exynos5250-manta.dts b/arch/arm/boot/dts/samsung/exynos5250-manta.dts
new file mode 100644
index 000000000000..346465d5b466
--- /dev/null
+++ b/arch/arm/boot/dts/samsung/exynos5250-manta.dts
@@ -0,0 +1,516 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Google Manta (Nexus 10) board device tree source
+ *
+ * Copyright (c) 2023-2025 Alexandre Marquet
+ * Copyright (c) 2025 Lukas Timmermann
+ */
+
+/dts-v1/;
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/clock/maxim,max77686.h>
+#include <dt-bindings/input/linux-event-codes.h>
+#include "exynos-pinctrl.h"
+#include "exynos5250.dtsi"
+#include "exynos-mfc-reserved-memory.dtsi"
+
+/ {
+	model = "Google Nexus 10";
+	compatible = "google,manta", "samsung,exynos5250", "samsung,exynos5";
+
+	aliases {
+		mmc0 = &mmc_0; /* eMMC */
+		mmc1 = &mmc_1; /* WiFi */
+	};
+
+	memory@40000000 {
+		device_type = "memory";
+		reg = <0x40000000 0x20000000
+		       0x60000000 0x20000000
+		       0x80000000 0x20000000
+		       0xa0000000 0x1ff00000>;
+	};
+
+	chosen {
+		stdout-path = &serial_2;
+	};
+
+	firmware@204f000 {
+		compatible = "samsung,secure-firmware";
+		reg = <0x0204f000 0x1000>;
+	};
+
+	fixed-rate-clocks {
+		xxti {
+			compatible = "samsung,clock-xxti";
+			clock-frequency = <24000000>;
+		};
+
+		xusbxti {
+			compatible = "samsung,clock-xusbxti";
+			clock-frequency = <24000000>;
+		};
+	};
+
+	gpio-keys {
+		compatible = "gpio-keys";
+		pinctrl-names = "default";
+		pinctrl-0 = <&gpio_keys>;
+
+		key-down {
+			gpios = <&gpx2 1 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_VOLUMEDOWN>;
+			label = "volume down";
+			debounce-interval = <5>;
+		};
+
+		key-up {
+			gpios = <&gpx2 0 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_VOLUMEUP>;
+			label = "volume up";
+			debounce-interval = <5>;
+		};
+
+		key-power {
+			gpios = <&gpx2 7 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_POWER>;
+			label = "power";
+			debounce-interval = <5>;
+			wakeup-source;
+		};
+
+		lid-switch {
+			label = "Lid";
+			gpios = <&gpx1 3 GPIO_ACTIVE_LOW>;
+			linux,input-type = <5>; /* EV_SW */
+			linux,code = <0>; /* SW_LID */
+			debounce-interval = <10>;
+			wakeup-source;
+		};
+	};
+
+	multi-led {
+		compatible = "leds-group-multicolor";
+		color = <LED_COLOR_ID_RGB>;
+		function = LED_FUNCTION_STATUS;
+		leds = <&status_red>, <&status_green>, <&status_blue>, <&status_white>;
+	};
+
+	wlan_pwrseq: mmc1-pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		reset-gpios = <&gpv1 0 GPIO_ACTIVE_LOW>;
+		pinctrl-0 = <&wlan_pmena>;
+		pinctrl-names = "default";
+		clocks = <&max77686 MAX77686_CLK_PMIC>;
+		clock-names = "ext_clock";
+		post-power-on-delay-ms = <300>;
+		power-off-delay-us = <50>;
+	};
+
+	bmp180_vddd_reg: regulator-bmp180-vddd {
+		compatible = "regulator-fixed";
+		regulator-name = "BMP180_VDDD";
+	};
+
+	bmp180_vdda_reg: regulator-bmp180-vdda {
+		compatible = "regulator-fixed";
+		regulator-name = "BMP180_VDDA";
+	};
+};
+
+&clock {
+	assigned-clocks = <&clock CLK_FOUT_APLL>;
+	assigned-clock-rates = <1000000000>;
+};
+
+&cpu0 {
+	cpu0-supply = <&buck2_reg>;
+};
+
+&ehci {
+	status = "disabled";
+};
+
+&i2c_0 {
+	status = "okay";
+	samsung,i2c-sda-delay = <100>;
+	samsung,i2c-slave-addr = <0x10>;
+};
+
+&i2c_1 {
+	status = "okay";
+
+	pressure@77 {
+		compatible = "bosch,bmp180";
+		reg = <0x77>;
+		vddd-supply = <&bmp180_vddd_reg>;
+		vdda-supply = <&bmp180_vdda_reg>;
+	};
+
+	imu@68 {
+		compatible = "invensense,mpu6050";
+		reg = <0x68>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&acc_int>;
+		interrupt-parent = <&gpx1>;
+		interrupts = <4 IRQ_TYPE_EDGE_RISING>;
+		mount-matrix = "0",  "-1",  "0",
+				"-1",  "0",  "0",
+				"0",  "0", "-1";
+
+		i2c-gate {
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			magnetometer@c {
+				compatible = "asahi-kasei,ak8963";
+				reg = <0x0c>;
+				pinctrl-names = "default";
+				pinctrl-0 = <&msense_rst>;
+				mount-matrix = "-1",  "0",  "0",
+						"0",  "1",  "0",
+						"0",  "0", "-1";
+			};
+		};
+	};
+
+	led-controller@42 {
+		compatible = "ams,as3668";
+		reg = <0x42>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		status_red: led@0 {
+			reg = <0x0>;
+			function = LED_FUNCTION_STATUS;
+			color = <LED_COLOR_ID_RED>;
+		};
+
+		status_green: led@1 {
+			reg = <0x1>;
+			function = LED_FUNCTION_STATUS;
+			color = <LED_COLOR_ID_GREEN>;
+		};
+
+		status_blue: led@2 {
+			reg = <0x2>;
+			function = LED_FUNCTION_STATUS;
+			color = <LED_COLOR_ID_BLUE>;
+		};
+
+		status_white: led@3 {
+			reg = <0x3>;
+			function = LED_FUNCTION_STATUS;
+			color = <LED_COLOR_ID_WHITE>;
+		};
+	};
+};
+
+&i2c_2 {
+	status = "okay";
+
+	light-sensor@23 {
+		compatible = "rohm,bh1721";
+		reg = <0x23>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&bh1721fvc_reset>;
+		reset-gpios = <&gph1 2 GPIO_ACTIVE_LOW>;
+	};
+
+	onewire@18 {
+		compatible = "maxim,ds2484";
+		reg = <0x18>;
+
+		pinctrl-names = "default";
+		pinctrl-0 = <&onewire_sleep>;
+	};
+};
+
+&i2c_5 {
+	status = "okay";
+	samsung,i2c-sda-delay = <100>;
+
+	max77686: pmic@9 {
+		compatible = "maxim,max77686";
+		reg = <0x09>;
+		interrupt-parent = <&gpx0>;
+		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&max77686_irq>;
+		#clock-cells = <1>;
+		wakeup-source;
+
+		voltage-regulators {
+			ldo3_reg: LDO3 {
+				regulator-name = "VCC_1.8V_AP";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			ldo8_reg: LDO8 {
+				regulator-name = "VMIPI_1.0V";
+				regulator-min-microvolt = <1000000>;
+				regulator-max-microvolt = <1000000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			ldo9_reg: LDO9 {
+				regulator-name = "TOUCH_VDD_1.8V";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+			};
+			ldo10_reg: LDO10 {
+				regulator-name = "VMIPI_1.8V";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			ldo12_reg: LDO12 {
+				regulator-name = "VUOTG_3.0V";
+				regulator-min-microvolt = <3000000>;
+				regulator-max-microvolt = <3000000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			ldo15_reg: LDO15 {
+				regulator-name = "VHSIC_1.0V";
+				regulator-min-microvolt = <1000000>;
+				regulator-max-microvolt = <1000000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			ldo16_reg: LDO16 {
+				regulator-name = "VHSIC_1.8V";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			ldo17_reg: LDO17 {
+				regulator-name = "5M_CORE_1.5V";
+				regulator-min-microvolt = <1500000>;
+				regulator-max-microvolt = <1500000>;
+			};
+			ldo18_reg: LDO18 {
+				regulator-name = "CAM_IO_1.8V";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+			};
+			ldo19_reg: LDO19 {
+				regulator-name = "VT_CAM_1.8V";
+				regulator-min-microvolt = <1800000>;
+				regulator-max-microvolt = <1800000>;
+			};
+			ldo20_reg: LDO20 {
+				regulator-name = "TA_CHECK_1.35V";
+				regulator-min-microvolt = <1350000>;
+				regulator-max-microvolt = <1350000>;
+			};
+			ldo23_reg: LDO23 {
+				regulator-name = "TSP_AVDD_2.8V";
+				regulator-min-microvolt = <2800000>;
+				regulator-max-microvolt = <2800000>;
+			};
+			ldo24_reg: LDO24 {
+				regulator-name = "CAM_AF_2.8V";
+				regulator-min-microvolt = <2800000>;
+				regulator-max-microvolt = <2800000>;
+			};
+			ldo25_reg: LDO25 {
+				regulator-name = "VADC_3.3V";
+				regulator-min-microvolt = <3300000>;
+				regulator-max-microvolt = <3300000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			buck1_reg: BUCK1 {
+				regulator-name = "vdd_mif";
+				regulator-min-microvolt = <850000>;
+				regulator-max-microvolt = <1200000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			buck2_reg: BUCK2 {
+				regulator-name = "vdd_arm";
+				regulator-min-microvolt = <850000>;
+				regulator-max-microvolt = <1200000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			buck3_reg: BUCK3 {
+				regulator-name = "vdd_int";
+				regulator-min-microvolt = <850000>;
+				regulator-max-microvolt = <1200000>;
+				regulator-always-on;
+				regulator-boot-on;
+			};
+			buck4_reg: BUCK4 {
+				regulator-name = "vdd_g3d";
+				regulator-min-microvolt = <850000>;
+				regulator-max-microvolt = <1200000>;
+				regulator-boot-on;
+			};
+		};
+	};
+};
+
+&mali {
+	status = "okay";
+	mali-supply = <&buck4_reg>;
+};
+
+&mixer {
+	status = "okay";
+};
+
+/* eMMC */
+&mmc_0 {
+	status = "okay";
+	non-removable;
+	max-frequency = <200000000>;
+	sd-uhs-ddr50;
+	mmc-ddr-1_8v;
+	cap-mmc-hw-reset;
+	mmc-hs200-1_8v;
+	bus-width = <8>;
+	card-detect-delay = <200>;
+	samsung,dw-mshc-ciu-div = <3>;
+	samsung,dw-mshc-sdr-timing = <1 2>;
+	samsung,dw-mshc-ddr-timing = <2 3>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_bus8>;
+};
+
+/* WiFi */
+&mmc_1 {
+	status = "okay";
+	non-removable;
+	max-frequency = <100000000>;
+	sd-uhs-sdr50;
+	cap-sd-highspeed;
+	keep-power-in-suspend;
+	bus-width = <4>;
+	card-detect-delay = <0>;
+	samsung,dw-mshc-ciu-div = <3>;
+	samsung,dw-mshc-sdr-timing = <2 4>;
+	samsung,dw-mshc-ddr-timing = <2 3>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sd1_clk &sd1_cmd &sd1_bus4>;
+	mmc-pwrseq = <&wlan_pwrseq>;
+
+	wifi@1 {
+		compatible = "brcm,bcm4330-fmac", "brcm,bcm4329-fmac";
+		reg = <1>;
+		interrupt-parent = <&gpx2>;
+		interrupts = <5 IRQ_TYPE_NONE>;
+		interrupt-names = "host-wake";
+		pinctrl-names = "default";
+		pinctrl-0 = <&wlan_irq>;
+	};
+};
+
+&ohci {
+	status = "disabled";
+};
+
+&pinctrl_0 {
+	acc_int: acc-int-pins {
+		samsung,pins = "gpx1-4";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_EINT>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_UP>;
+	};
+
+	max77686_irq: max77686-irq-pins {
+		samsung,pins = "gpx0-2";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_F>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV1>;
+	};
+	gpio_keys: gpio-keys-pins-pins {
+		samsung,pins = "gpx2-0", "gpx2-1", "gpx2-7", "gpx1-3";
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+	};
+	wlan_irq: wlan-irq-pins {
+		samsung,pins = "gpx2-5";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_INPUT>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>;
+	};
+};
+
+&pinctrl_1 {
+	bh1721fvc_reset: bh1721fvc-reset-pins {
+		samsung,pins = "gph1-2";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+	};
+	msense_rst: msense-rst-pins {
+		samsung,pins = "gpg2-0";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
+	};
+	onewire_sleep: onewire-sleep-pins {
+		samsung,pins = "gpg0-0";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>;
+		samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>;
+	};
+};
+
+&pinctrl_2 {
+	wlan_pmena: wlan-pmena-pins {
+		samsung,pins = "gpv1-0";
+		samsung,pin-function = <EXYNOS_PIN_FUNC_OUTPUT>;
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+		samsung,pin-drv = <EXYNOS4_PIN_DRV_LV3>;
+		samsung,pin-con-pdn = <EXYNOS_PIN_PDN_PREV>;
+		samsung,pin-val = <0>;
+	};
+};
+
+&pmu_system_controller {
+	assigned-clocks = <&pmu_system_controller 0>;
+	assigned-clock-parents = <&clock CLK_FIN_PLL>;
+};
+
+&sd1_bus4 {
+	samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>;
+	samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>;
+};
+
+&sd1_cmd {
+	samsung,pin-con-pdn = <EXYNOS_PIN_PDN_INPUT>;
+	samsung,pin-pud-pdn = <EXYNOS_PIN_PULL_NONE>;
+};
+
+/* Bluetooth */
+&serial_0 {
+	status = "disabled";
+};
+
+&serial_1 {
+	pinctrl-names = "default", "flow-control";
+	pinctrl-0 = <&uart1_data>;
+	pinctrl-1 = <&uart1_data>, <&uart1_fctl>;
+};
+
+&serial_2 {
+	pinctrl-names = "default", "flow-control";
+	pinctrl-0 = <&uart2_data>;
+	pinctrl-1 = <&uart2_data>, <&uart2_fctl>;
+};
+
+&usbdrd {
+	status = "disabled";
+};
+
+&usbdrd_dwc3 {
+	status = "disabled";
+};
+
+&usbdrd_phy {
+	status = "disabled";
+};

-- 
2.52.0

[PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot

[Lukas Timmermann]

From: Alexandre Marquet <tb@a-marquet.fr>

Add an exception to let the secondary CPU boot.

Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
Signed-off-by: Lukas Timmermann <linux@timmermann.space>
---
 arch/arm/mach-exynos/firmware.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
index a5e22678e27b..80e645b4d338 100644
--- a/arch/arm/mach-exynos/firmware.c
+++ b/arch/arm/mach-exynos/firmware.c
@@ -61,10 +61,10 @@ static int exynos_cpu_boot(int cpu)
 	 * Exynos3250 doesn't need to send smc command for secondary CPU boot
 	 * because Exynos3250 removes WFE in secure mode.
 	 *
-	 * On Exynos5 devices the call is ignored by trustzone firmware.
+	 * On most Exynos5 devices the call is ignored by trustzone firmware.
 	 */
 	if (!soc_is_exynos4210() && !soc_is_exynos4212() &&
-	    !soc_is_exynos4412())
+	    !soc_is_exynos4412() && !of_machine_is_compatible("samsung,nexus10-manta"))
 		return 0;
 
 	/*

-- 
2.52.0

Re: [PATCH v2 0/3] Add support for exynos5250-manta (Google Nexus 10)

[Krzysztof Kozlowski]

On 25/11/2025 16:12, Lukas Timmermann wrote:
> This patch series adds initial support for the google-manta board, known
> as Google Nexus 10 to users. The device is powered by
> the Exynos 5250 SoC. The notification led driver (as3668) is already 
> (tho not applied) in the kernel mailing list and can be found here:
> https://lore.kernel.org/linux-leds/20251125114015.355487-1-linux@timmermann.space/
> 

Thank you for your patches.

Nothing in the cover letter improved regarding my request - you clearly
need to document, in a very explicit and obvious way, that this uses
bindings where not applied. Drivers don't matter here. I need here list
of bindings this is using which were not yet applied by maintainers.

If there is going to be v3, please be sure you fix the cover letter.

Best regards,
Krzysztof

Re: [PATCH v2 0/3] Add support for exynos5250-manta (Google Nexus 10)

[Krzysztof Kozlowski]

On 25/11/2025 16:20, Krzysztof Kozlowski wrote:
> On 25/11/2025 16:12, Lukas Timmermann wrote:
>> This patch series adds initial support for the google-manta board, known
>> as Google Nexus 10 to users. The device is powered by
>> the Exynos 5250 SoC. The notification led driver (as3668) is already 
>> (tho not applied) in the kernel mailing list and can be found here:
>> https://lore.kernel.org/linux-leds/20251125114015.355487-1-linux@timmermann.space/
>>
> 
> Thank you for your patches.
> 
> Nothing in the cover letter improved regarding my request - you clearly
> need to document, in a very explicit and obvious way, that this uses
> bindings where not applied. Drivers don't matter here. I need here list

... "bindings which were not applied."

> of bindings this is using which were not yet applied by maintainers.
> 
> If there is going to be v3, please be sure you fix the cover letter.
> 
> Best regards,
> Krzysztof


Best regards,
Krzysztof

Re: [PATCH v2 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

[Krzysztof Kozlowski]

On Tue, Nov 25, 2025 at 04:12:41PM +0100, Lukas Timmermann wrote:
> +/ {
> +	model = "Google Nexus 10";
> +	compatible = "google,manta", "samsung,exynos5250", "samsung,exynos5";
> +

Everything looks good in general, thanks for working on this. I have
few nits below. You can send next version whenever you are ready, but
just to let you know - my tree is already closed till RC1.

> +	aliases {
> +		mmc0 = &mmc_0; /* eMMC */
> +		mmc1 = &mmc_1; /* WiFi */
> +	};
> +
> +	memory@40000000 {

Please order the nodes in top level by node name (see DTS coding style).
I know that existing files do not follow that, but we try to have new
code conforming to the coding style.

> +		device_type = "memory";
> +		reg = <0x40000000 0x20000000

Separate <> for each entry.

> +		       0x60000000 0x20000000
> +		       0x80000000 0x20000000
> +		       0xa0000000 0x1ff00000>;
> +	};
> +
> +	chosen {
> +		stdout-path = &serial_2;
> +	};
> +
> +	firmware@204f000 {
> +		compatible = "samsung,secure-firmware";
> +		reg = <0x0204f000 0x1000>;
> +	};
> +
> +	fixed-rate-clocks {
> +		xxti {
> +			compatible = "samsung,clock-xxti";
> +			clock-frequency = <24000000>;
> +		};
> +
> +		xusbxti {
> +			compatible = "samsung,clock-xusbxti";

Are you sure you have this clock input? I think on Exynos5250 usually
only XXTI was provided, no?

> +			clock-frequency = <24000000>;
> +		};
> +	};
> +
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&gpio_keys>;
> +
> +		key-down {
> +			gpios = <&gpx2 1 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_VOLUMEDOWN>;
> +			label = "volume down";
> +			debounce-interval = <5>;
> +		};
> +
> +		key-up {
> +			gpios = <&gpx2 0 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_VOLUMEUP>;
> +			label = "volume up";
> +			debounce-interval = <5>;
> +		};
> +
> +		key-power {
> +			gpios = <&gpx2 7 GPIO_ACTIVE_LOW>;
> +			linux,code = <KEY_POWER>;
> +			label = "power";
> +			debounce-interval = <5>;
> +			wakeup-source;
> +		};
> +
> +		lid-switch {
> +			label = "Lid";
> +			gpios = <&gpx1 3 GPIO_ACTIVE_LOW>;
> +			linux,input-type = <5>; /* EV_SW */
> +			linux,code = <0>; /* SW_LID */
> +			debounce-interval = <10>;
> +			wakeup-source;
> +		};
> +	};
> +
> +	multi-led {
> +		compatible = "leds-group-multicolor";
> +		color = <LED_COLOR_ID_RGB>;
> +		function = LED_FUNCTION_STATUS;
> +		leds = <&status_red>, <&status_green>, <&status_blue>, <&status_white>;
> +	};
> +
> +	wlan_pwrseq: mmc1-pwrseq {

Just "pwrseq"

Best regards,
Krzysztof

Re: [PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot

[Krzysztof Kozlowski]

On Tue, Nov 25, 2025 at 04:12:42PM +0100, Lukas Timmermann wrote:
> From: Alexandre Marquet <tb@a-marquet.fr>
> 
> Add an exception to let the secondary CPU boot.

Please say here why.

> 
> Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
> Signed-off-by: Lukas Timmermann <linux@timmermann.space>

Best regards,
Krzysztof

Re: [PATCH v2 0/3] Add support for exynos5250-manta (Google Nexus 10)

[Rob Herring]

On Tue, 25 Nov 2025 16:12:39 +0100, Lukas Timmermann wrote:
> This patch series adds initial support for the google-manta board, known
> as Google Nexus 10 to users. The device is powered by
> the Exynos 5250 SoC. The notification led driver (as3668) is already
> (tho not applied) in the kernel mailing list and can be found here:
> https://lore.kernel.org/linux-leds/20251125114015.355487-1-linux@timmermann.space/
> 
> The first two patches add the necessary device tree files and
> bindings, while the last patch makes a small modification to
> allow CPU1 to boot, as it requires a call to it's underlying firmware.
> 
> This first iteration only provides basic support to get the board
> up and running and usable via UART and with WiFi support. We will upstream additional
> features in future patches. All patches have been tested on real hardware.
> 
> Signed-off-by: Lukas Timmermann <linux@timmermann.space>
> ---
> Alexandre Marquet (3):
>       dt-bindings: ARM: samsung: Add Google Manta (Nexus 10)
>       ARM: dts: exynos: Add Google Manta (Nexus 10)
>       ARM: samsung: exynos5250: Allow CPU1 to boot
> 
>  .../bindings/arm/samsung/samsung-boards.yaml       |   1 +
>  arch/arm/boot/dts/samsung/Makefile                 |   1 +
>  arch/arm/boot/dts/samsung/exynos5250-manta.dts     | 516 +++++++++++++++++++++
>  arch/arm/mach-exynos/firmware.c                    |   4 +-
>  4 files changed, 520 insertions(+), 2 deletions(-)
> ---
> base-commit: 6a23ae0a96a600d1d12557add110e0bb6e32730c
> change-id: 20251125-google-manta-79545e179d10
> 
> Best regards,
> --
> Lukas Timmermann <linux@timmermann.space>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: 6a23ae0a96a600d1d12557add110e0bb6e32730c (use --merge-base to override)

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/samsung/' for 20251125-google-manta-v2-0-0f097cfff39c@timmermann.space:

arch/arm/boot/dts/samsung/exynos5250-manta.dtb: /soc/i2c@12c70000/led-controller@42: failed to match any schema with compatible: ['ams,as3668']
arch/arm/boot/dts/samsung/exynos5250-manta.dtb: rtc@101e0000 (samsung,s3c6410-rtc): clock-names: ['rtc'] is too short
	from schema $id: http://devicetree.org/schemas/rtc/s3c-rtc.yaml
arch/arm/boot/dts/samsung/exynos5250-manta.dtb: rtc@101e0000 (samsung,s3c6410-rtc): clocks: [[2, 337]] is too short
	from schema $id: http://devicetree.org/schemas/rtc/s3c-rtc.yaml

Re: [PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot

[Lukas Timmermann]

On Wed, Nov 26, 2025 at 10:24:02AM +0100, Krzysztof Kozlowski wrote:
> On Tue, Nov 25, 2025 at 04:12:42PM +0100, Lukas Timmermann wrote:
> > From: Alexandre Marquet <tb@a-marquet.fr>
> > 
> > Add an exception to let the secondary CPU boot.
> 
> Please say here why.
> 
> > 
> > Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
> > Signed-off-by: Lukas Timmermann <linux@timmermann.space>
> 
> Best regards,
> Krzysztof
> 
> 
Okay, I will fix that in v3. Thanks

Best regards,
Lukas Timmermann

Re: [PATCH v2 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

[Lukas Timmermann]

On Wed, Nov 26, 2025 at 10:10:46AM +0100, Krzysztof Kozlowski wrote:
> On Tue, Nov 25, 2025 at 04:12:41PM +0100, Lukas Timmermann wrote:
> > +/ {
> > +	model = "Google Nexus 10";
> > +	compatible = "google,manta", "samsung,exynos5250", "samsung,exynos5";
> > +
> 
> Everything looks good in general, thanks for working on this. I have
> few nits below. You can send next version whenever you are ready, but
> just to let you know - my tree is already closed till RC1.
> 
First of all, thank you!
The as3668 bindings are yet to be applied, no need to rush here.
> > +	aliases {
> > +		mmc0 = &mmc_0; /* eMMC */
> > +		mmc1 = &mmc_1; /* WiFi */
> > +	};
> > +
> > +	memory@40000000 {
> 
> Please order the nodes in top level by node name (see DTS coding style).
> I know that existing files do not follow that, but we try to have new
> code conforming to the coding style.
> 
We ordered them as seen in other devices. I've checked out the coding style 
guideline and will make modifications accordingly.
> > +		device_type = "memory";
> > +		reg = <0x40000000 0x20000000
> 
> Separate <> for each entry.
> 
Acknowledged.
> > +		       0x60000000 0x20000000
> > +		       0x80000000 0x20000000
> > +		       0xa0000000 0x1ff00000>;
> > +	};
> > +
> > +	chosen {
> > +		stdout-path = &serial_2;
> > +	};
> > +
> > +	firmware@204f000 {
> > +		compatible = "samsung,secure-firmware";
> > +		reg = <0x0204f000 0x1000>;
> > +	};
> > +
> > +	fixed-rate-clocks {
> > +		xxti {
> > +			compatible = "samsung,clock-xxti";
> > +			clock-frequency = <24000000>;
> > +		};
> > +
> > +		xusbxti {
> > +			compatible = "samsung,clock-xusbxti";
> 
> Are you sure you have this clock input? I think on Exynos5250 usually
> only XXTI was provided, no?
> 
We checked with the downstream code and found this clock input. We
recognize, that downstream kernels aren't 100% correct at times.
I tested the device without this clock input as you suggested.
It seems that this is in fact not needed. So I will remove it in v3.
> > +			clock-frequency = <24000000>;
> > +		};
> > +	};
> > +
> > +	gpio-keys {
> > +		compatible = "gpio-keys";
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&gpio_keys>;
> > +
> > +		key-down {
> > +			gpios = <&gpx2 1 GPIO_ACTIVE_LOW>;
> > +			linux,code = <KEY_VOLUMEDOWN>;
> > +			label = "volume down";
> > +			debounce-interval = <5>;
> > +		};
> > +
> > +		key-up {
> > +			gpios = <&gpx2 0 GPIO_ACTIVE_LOW>;
> > +			linux,code = <KEY_VOLUMEUP>;
> > +			label = "volume up";
> > +			debounce-interval = <5>;
> > +		};
> > +
> > +		key-power {
> > +			gpios = <&gpx2 7 GPIO_ACTIVE_LOW>;
> > +			linux,code = <KEY_POWER>;
> > +			label = "power";
> > +			debounce-interval = <5>;
> > +			wakeup-source;
> > +		};
> > +
> > +		lid-switch {
> > +			label = "Lid";
> > +			gpios = <&gpx1 3 GPIO_ACTIVE_LOW>;
> > +			linux,input-type = <5>; /* EV_SW */
> > +			linux,code = <0>; /* SW_LID */
> > +			debounce-interval = <10>;
> > +			wakeup-source;
> > +		};
> > +	};
> > +
> > +	multi-led {
> > +		compatible = "leds-group-multicolor";
> > +		color = <LED_COLOR_ID_RGB>;
> > +		function = LED_FUNCTION_STATUS;
> > +		leds = <&status_red>, <&status_green>, <&status_blue>, <&status_white>;
> > +	};
> > +
> > +	wlan_pwrseq: mmc1-pwrseq {
> 
> Just "pwrseq"
> 
Acknowledged.
Just out of curiosity. Why is that?
> Best regards,
> Krzysztof
> 
> 
Best regards,
Lukas Timmermann

Re: [PATCH v2 2/3] ARM: dts: exynos: Add Google Manta (Nexus 10)

[Krzysztof Kozlowski]

On 27/11/2025 21:01, Lukas Timmermann wrote:
>>> +
>>> +		lid-switch {
>>> +			label = "Lid";
>>> +			gpios = <&gpx1 3 GPIO_ACTIVE_LOW>;
>>> +			linux,input-type = <5>; /* EV_SW */
>>> +			linux,code = <0>; /* SW_LID */
>>> +			debounce-interval = <10>;
>>> +			wakeup-source;
>>> +		};
>>> +	};
>>> +
>>> +	multi-led {
>>> +		compatible = "leds-group-multicolor";
>>> +		color = <LED_COLOR_ID_RGB>;
>>> +		function = LED_FUNCTION_STATUS;
>>> +		leds = <&status_red>, <&status_green>, <&status_blue>, <&status_white>;
>>> +	};
>>> +
>>> +	wlan_pwrseq: mmc1-pwrseq {
>>
>> Just "pwrseq"
>>
> Acknowledged.
> Just out of curiosity. Why is that?


You have only one pwrseq device, so not need to precise which one is
that and node names should be generic.

https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Best regards,
Krzysztof

Re: [PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 1480 bytes --]

On Tue 2025-11-25 16:12:42, Lukas Timmermann wrote:
> From: Alexandre Marquet <tb@a-marquet.fr>
> 
> Add an exception to let the secondary CPU boot.
> 
> Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
> Signed-off-by: Lukas Timmermann <linux@timmermann.space>
> ---
>  arch/arm/mach-exynos/firmware.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos/firmware.c b/arch/arm/mach-exynos/firmware.c
> index a5e22678e27b..80e645b4d338 100644
> --- a/arch/arm/mach-exynos/firmware.c
> +++ b/arch/arm/mach-exynos/firmware.c
> @@ -61,10 +61,10 @@ static int exynos_cpu_boot(int cpu)
>  	 * Exynos3250 doesn't need to send smc command for secondary CPU boot
>  	 * because Exynos3250 removes WFE in secure mode.
>  	 *
> -	 * On Exynos5 devices the call is ignored by trustzone firmware.
> +	 * On most Exynos5 devices the call is ignored by trustzone firmware.
>  	 */
>  	if (!soc_is_exynos4210() && !soc_is_exynos4212() &&
> -	    !soc_is_exynos4412())
> +	    !soc_is_exynos4412() && !of_machine_is_compatible("samsung,nexus10-manta"))
>  		return 0;

Strange -- +       compatible = "google,manta", "samsung,exynos5250", "samsung,exynos5";

Should this be google,manta or something?

Also please cc: phone-devel mailing list with phone related patches.

Best regards,
								Pavel

-- 
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, Netanyahu and Musk!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot

[Krzysztof Kozlowski]

On 04/12/2025 12:22, Pavel Machek wrote:
> Also please cc: phone-devel mailing list with phone related patches.

You don't have to. This list is not part of any upstream Linux kernel
process (see `git grep`), it's not relevant to upstream kernel development.


Best regards,
Krzysztof

Re: [PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 507 bytes --]

On Thu 2025-12-04 12:51:36, Krzysztof Kozlowski wrote:
> On 04/12/2025 12:22, Pavel Machek wrote:
> > Also please cc: phone-devel mailing list with phone related patches.
> 
> You don't have to. This list is not part of any upstream Linux kernel
> process (see `git grep`), it's not relevant to upstream kernel development.

Yes, you should. Its a relevant mailing list.

								Pavel
-- 
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, Netanyahu and Musk!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot

[Krzysztof Kozlowski]

On 04/12/2025 12:53, Pavel Machek wrote:
> On Thu 2025-12-04 12:51:36, Krzysztof Kozlowski wrote:
>> On 04/12/2025 12:22, Pavel Machek wrote:
>>> Also please cc: phone-devel mailing list with phone related patches.
>>
>> You don't have to. This list is not part of any upstream Linux kernel
>> process (see `git grep`), it's not relevant to upstream kernel development.
> 
> Yes, you should. Its a relevant mailing list.

git grep for it. Stop inventing rules.

Best regards,
Krzysztof

Re: [PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

On Thu 2025-12-04 12:54:03, Krzysztof Kozlowski wrote:
> On 04/12/2025 12:53, Pavel Machek wrote:
> > On Thu 2025-12-04 12:51:36, Krzysztof Kozlowski wrote:
> >> On 04/12/2025 12:22, Pavel Machek wrote:
> >>> Also please cc: phone-devel mailing list with phone related patches.
> >>
> >> You don't have to. This list is not part of any upstream Linux kernel
> >> process (see `git grep`), it's not relevant to upstream kernel development.
> > 
> > Yes, you should. Its a relevant mailing list.
> 
> git grep for it. Stop inventing rules.

Who is inventing rules here? Stop sabotaging review process.

"Many kernel-related lists are hosted on vger.kernel.org; you can find a
list of them at http://vger.kernel.org/vger-lists.html.  There are
kernel-related lists hosted elsewhere as well, though."

								Pavel
-- 
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, Netanyahu and Musk!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot

[Krzysztof Kozlowski]

On 04/12/2025 12:55, Pavel Machek wrote:
> On Thu 2025-12-04 12:54:03, Krzysztof Kozlowski wrote:
>> On 04/12/2025 12:53, Pavel Machek wrote:
>>> On Thu 2025-12-04 12:51:36, Krzysztof Kozlowski wrote:
>>>> On 04/12/2025 12:22, Pavel Machek wrote:
>>>>> Also please cc: phone-devel mailing list with phone related patches.
>>>>
>>>> You don't have to. This list is not part of any upstream Linux kernel
>>>> process (see `git grep`), it's not relevant to upstream kernel development.
>>>
>>> Yes, you should. Its a relevant mailing list.
>>
>> git grep for it. Stop inventing rules.
> 
> Who is inventing rules here? Stop sabotaging review process.

You invented rule that some specific list of your interest has to be
CCed, even though no one knows about that list and it is nowhere documented.

> 
> "Many kernel-related lists are hosted on vger.kernel.org; you can find a
> list of them at http://vger.kernel.org/vger-lists.html.  There are
> kernel-related lists hosted elsewhere as well, though."

This proves nothing. There are just some lists there. No one has to cc
whatever list there just because Pavel Machek asks them. Kernel process
defines it or not. Not you.


Best regards,
Krzysztof

Re: [PATCH v2 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot

[Pavel Machek]

[-- Attachment #1: Type: text/plain, Size: 2007 bytes --]

On Thu 2025-12-04 13:02:00, Krzysztof Kozlowski wrote:
> On 04/12/2025 12:55, Pavel Machek wrote:
> > On Thu 2025-12-04 12:54:03, Krzysztof Kozlowski wrote:
> >> On 04/12/2025 12:53, Pavel Machek wrote:
> >>> On Thu 2025-12-04 12:51:36, Krzysztof Kozlowski wrote:
> >>>> On 04/12/2025 12:22, Pavel Machek wrote:
> >>>>> Also please cc: phone-devel mailing list with phone related patches.
> >>>>
> >>>> You don't have to. This list is not part of any upstream Linux kernel
> >>>> process (see `git grep`), it's not relevant to upstream kernel development.
> >>>
> >>> Yes, you should. Its a relevant mailing list.
> >>
> >> git grep for it. Stop inventing rules.
> > 
> > Who is inventing rules here? Stop sabotaging review process.
> 
> You invented rule that some specific list of your interest has to be
> CCed, even though no one knows about that list and it is nowhere documented.

No. I'm asking people to please cc the mailing list so that interested
people can see the patches. It is you blabbering nonsense about "git
grep" and "get_maintainer" as if those were rules.

> > "Many kernel-related lists are hosted on vger.kernel.org; you can find a
> > list of them at http://vger.kernel.org/vger-lists.html.  There are
> > kernel-related lists hosted elsewhere as well, though."
> 
> This proves nothing. There are just some lists there. No one has to cc
> whatever list there just because Pavel Machek asks them. Kernel process
> defines it or not. Not you.

And not you.

Kernel process is to cc relevant people, and relevant mailing lists,
SubmittingPatches points you to http://vger.kernel.org/vger-lists.html
. If people are interested in the patch (for example because they
reacted to previous version), you should cc them. People in
phone-devel expressed interest in phone-related kernel development, so
you should cc them.

								Pavel
-- 
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, Netanyahu and Musk!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]