From: Michal Simek <michal.simek@amd.com>
To: phucduc.bui@gmail.com,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/3] ASoC: xilinx: xlnx_i2s: Use dev_err_probe() and drop redundant error handling
Date: Fri, 10 Jul 2026 12:38:30 +0200 [thread overview]
Message-ID: <ee7ed7d7-4ac6-4e17-b493-7b5f1c3d31cc@amd.com> (raw)
In-Reply-To: <20260710102138.29347-1-phucduc.bui@gmail.com>
On 7/10/26 12:21, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> Hi all,
>
> This series cleans up error handling in the Xilinx ASoC drivers.
> It replaces dev_err() followed by return with dev_err_probe() where
> appropriate in probe paths, allowing deferred probe to be handled
> correctly while simplifying the code.
> It also removes redundant dev_err() calls after helper functions that
> already report failures, avoiding duplicate error messages.
>
> Changes in v2:
> - Split out a separate patch to preserve devm_request_irq() error codes.
> - Adjust line wrapping.
> - Add the Reviewed-by tag.
>
> Best regards,
> Phuc
>
> bui duc phuc (3):
> ASoC: xilinx: xlnx_i2s: Use dev_err_probe() and drop redundant error
> handling
> ASoC: xilinx: xlnx_spdif: Preserve devm_request_irq() error codes
> ASoC: xilinx: xlnx_spdif: Use dev_err_probe() and drop redundant error
> handling
>
> sound/soc/xilinx/xlnx_i2s.c | 18 +++++++-----------
> sound/soc/xilinx/xlnx_spdif.c | 31 +++++++++++--------------------
> 2 files changed, 18 insertions(+), 31 deletions(-)
>
Reviewed-by: Michal Simek <michal.simek@amd.com>
Thanks,
Michal
next prev parent reply other threads:[~2026-07-10 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 10:21 [PATCH v2 0/3] ASoC: xilinx: xlnx_i2s: Use dev_err_probe() and drop redundant error handling phucduc.bui
2026-07-10 10:21 ` [PATCH v2 1/3] " phucduc.bui
2026-07-10 10:21 ` [PATCH v2 2/3] ASoC: xilinx: xlnx_spdif: Preserve devm_request_irq() error codes phucduc.bui
2026-07-10 10:21 ` [PATCH v2 3/3] ASoC: xilinx: xlnx_spdif: Use dev_err_probe() and drop redundant error handling phucduc.bui
2026-07-10 10:38 ` Michal Simek [this message]
2026-07-10 12:35 ` [PATCH v2 0/3] ASoC: xilinx: xlnx_i2s: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee7ed7d7-4ac6-4e17-b493-7b5f1c3d31cc@amd.com \
--to=michal.simek@amd.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=phucduc.bui@gmail.com \
--cc=tiwai@suse.com \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox