Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: wulf@rock-chips.com (wlf)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] phy: rockchip-inno-usb2: correct clk_ops callback
Date: Tue, 15 Nov 2016 11:22:30 +0800	[thread overview]
Message-ID: <ee7f7cd7-cd77-dfa9-5075-3cc08b1cd79e@rock-chips.com> (raw)
In-Reply-To: <CAD=FV=W36tdw3LqPq3tp58U4trYX6n=qaotMTsP6tm0QzZrRWQ@mail.gmail.com>

Hi Doug,

? 2016?11?15? 02:15, Doug Anderson ??:
> William
>
> On Sun, Nov 13, 2016 at 11:01 PM, William Wu <wulf@rock-chips.com> wrote:
>> Since we needs to delay ~1ms to wait for 480MHz output clock
>> of USB2 PHY to become stable after turn on it, the delay time
>> is pretty long for something that's supposed to be "atomic"
>> like a clk_enable(). Consider that clk_enable() will disable
>> interrupt and that a 1ms interrupt latency is not sensible.
>>
>> The 480MHz output clock should be handled in prepare callbacks
>> which support gate a clk if the operation may sleep.
>>
>> Signed-off-by: William Wu <wulf@rock-chips.com>
>> ---
>>   drivers/phy/phy-rockchip-inno-usb2.c | 12 ++++++------
>>   1 file changed, 6 insertions(+), 6 deletions(-)
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

Thanks! I'll add  Reviewed-by.
>
>
>

  reply	other threads:[~2016-11-15  3:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14  7:01 [PATCH v2 0/2] phy: rockchip-inno-usb2: correct 480MHz clk_ops callbacks and stable time William Wu
2016-11-14  7:01 ` [PATCH v2 1/2] phy: rockchip-inno-usb2: correct clk_ops callback William Wu
2016-11-14 18:15   ` Doug Anderson
2016-11-15  3:22     ` wlf [this message]
2016-11-14  7:01 ` [PATCH v2 2/2] phy: rockchip-inno-usb2: correct 480MHz output clock stable time William Wu
2016-11-14  8:15   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee7f7cd7-cd77-dfa9-5075-3cc08b1cd79e@rock-chips.com \
    --to=wulf@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox