From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DA41C10F0E for ; Fri, 12 Apr 2019 08:51:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFD9420818 for ; Fri, 12 Apr 2019 08:51:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fxHr1tVf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="L+zrl/lZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFD9420818 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UsC39DUO52/X0VgGaOw4BWOlgPc1tqDBYkcM5tZSTAE=; b=fxHr1tVfJTXjb0 uS4J1Pwo0QAq/Nj23Oyux43a7P2Oa0u67SxSsZBcZPYI+t/A8ImUa/0o01FgHyCLkEi5uN7+3MRrp Xk/2YidY5M/ZmAqT31nC7BsJcl4zYbsAnnaOcW2OsFr5CdiwA9OSkUNfi2oaIfY9EG/u7ouQFMPva eT5M2OByuDorIFgNT8MmURdF7c/JqE4FJQZa3YbWplagorNfjL0uZf/+g/kfYke1B9HNSNF6hH2+2 SoR3qqiGCzV2BV36peW/Bqymx+CI6QWdlhXzK3NzIcFtijlzicLNJYBCl79MOEpZdPwRJM3+vixVK 2x5Mghs8jQ4vJgDdN1IA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEruK-00070n-DZ; Fri, 12 Apr 2019 08:51:36 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEruH-00070F-6I for linux-arm-kernel@lists.infradead.org; Fri, 12 Apr 2019 08:51:34 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x3C8pImV103252; Fri, 12 Apr 2019 03:51:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1555059078; bh=th70+twh7HkI/eIDcRitXYsgf4ynNKVisCSmCddN6vs=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=L+zrl/lZ3F50vWPCeYHB8UmvlFwqnWexxTqXZONmnyThzy5vv+MA5L2HLPnJYUcUS OlN0aEuZog9kJHkU6o/vWPyk8h3hnzzT4GXSJ1p1+3v/+tu4Zn3hvIdo8YvJTJWVMO GjEPOLsQkucVZ7LtI536fjjLD4PR1KpUIQ10I1As= Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x3C8pIKW045018 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 12 Apr 2019 03:51:18 -0500 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 12 Apr 2019 03:51:18 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Fri, 12 Apr 2019 03:51:18 -0500 Received: from [172.24.190.233] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x3C8p9Yw035000; Fri, 12 Apr 2019 03:51:10 -0500 Subject: Re: [PATCH v3 12/26] PCI: keystone: Prevent ARM32 specific code to be compiled for ARM64 To: Lorenzo Pieralisi References: <20190325093947.32633-1-kishon@ti.com> <20190325093947.32633-13-kishon@ti.com> <20190411150332.GC6862@red-moon> From: Kishon Vijay Abraham I Message-ID: Date: Fri, 12 Apr 2019 14:20:06 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190411150332.GC6862@red-moon> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190412_015133_305477_4EAFC351 X-CRM114-Status: GOOD ( 19.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jesper Nilsson , Arnd Bergmann , Greg Kroah-Hartman , Gustavo Pimentel , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@axis.com, Minghuan Lian , Rob Herring , Murali Karicheri , Jingoo Han , Bjorn Helgaas , Mingkai Hu , linux-omap@vger.kernel.org, Roy Zang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Lorenzo, On 11/04/19 8:33 PM, Lorenzo Pieralisi wrote: > On Mon, Mar 25, 2019 at 03:09:33PM +0530, Kishon Vijay Abraham I wrote: >> hook_fault_code is an ARM32 specific API for hooking into data abort. >> Since pci-keystone.c will be used for AM65X platforms which is an >> ARM64 platform, > > Hi Kishon, > > How is the problem plugged by the fault hook fixed on ARM64 ? At least in AM654 platform, I don't see a bus error when PCIe device is not connected but returns 0xffffffff. So there is no necessary for hook_fault_code in AM654 platform. Thanks Kishon > > Thanks, > Lorenzo > >> allow hook_fault_code to be compiled only for ARM32. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> drivers/pci/controller/dwc/pci-keystone.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/pci/controller/dwc/pci-keystone.c b/drivers/pci/controller/dwc/pci-keystone.c >> index dfe54553d832..93296d434f40 100644 >> --- a/drivers/pci/controller/dwc/pci-keystone.c >> +++ b/drivers/pci/controller/dwc/pci-keystone.c >> @@ -710,6 +710,7 @@ static int ks_pcie_config_legacy_irq(struct keystone_pcie *ks_pcie) >> return ret; >> } >> >> +#ifdef CONFIG_ARM >> /* >> * When a PCI device does not exist during config cycles, keystone host gets a >> * bus error instead of returning 0xffffffff. This handler always returns 0 >> @@ -729,6 +730,7 @@ static int ks_pcie_fault(unsigned long addr, unsigned int fsr, >> >> return 0; >> } >> +#endif >> >> static int __init ks_pcie_init_id(struct keystone_pcie *ks_pcie) >> { >> @@ -778,12 +780,14 @@ static int __init ks_pcie_host_init(struct pcie_port *pp) >> if (ret < 0) >> return ret; >> >> +#ifdef CONFIG_ARM >> /* >> * PCIe access errors that result into OCP errors are caught by ARM as >> * "External aborts" >> */ >> hook_fault_code(17, ks_pcie_fault, SIGBUS, 0, >> "Asynchronous external abort"); >> +#endif >> >> ks_pcie_start_link(pci); >> dw_pcie_wait_for_link(pci); >> -- >> 2.17.1 >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel