From: Neil Armstrong <neil.armstrong@linaro.org>
To: zelong dong <zelong.dong@amlogic.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh@kernel.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
kelvin.zhang@amlogic.com
Subject: Re: [PATCH 1/3] dt-bindings: reset: Add compatible and DT bindings for Amlogic A4/A5 Reset Controller
Date: Wed, 3 Jul 2024 09:42:11 +0200 [thread overview]
Message-ID: <eea2d957-fb4d-4ede-9789-d1e24ef1663a@linaro.org> (raw)
In-Reply-To: <20240703061610.37217-2-zelong.dong@amlogic.com>
On 03/07/2024 08:16, zelong dong wrote:
> From: Zelong Dong <zelong.dong@amlogic.com>
>
> Add new compatible and DT bindings for Amlogic A4/A5 Reset Controller
>
> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
> ---
> .../bindings/reset/amlogic,meson-reset.yaml | 22 +++++++++++++------
> 1 file changed, 15 insertions(+), 7 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
> index f0c6c0df0ce3..80345af81d5a 100644
> --- a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
> +++ b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
> @@ -12,13 +12,21 @@ maintainers:
>
> properties:
> compatible:
> - enum:
> - - amlogic,meson8b-reset # Reset Controller on Meson8b and compatible SoCs
> - - amlogic,meson-gxbb-reset # Reset Controller on GXBB and compatible SoCs
> - - amlogic,meson-axg-reset # Reset Controller on AXG and compatible SoCs
> - - amlogic,meson-a1-reset # Reset Controller on A1 and compatible SoCs
> - - amlogic,meson-s4-reset # Reset Controller on S4 and compatible SoCs
> - - amlogic,c3-reset # Reset Controller on C3 and compatible SoCs
> + oneOf:
> + - items:
> + - enum:
> + - amlogic,meson8b-reset # Reset Controller on Meson8b and compatible SoCs
> + - amlogic,meson-gxbb-reset # Reset Controller on GXBB and compatible SoCs
> + - amlogic,meson-axg-reset # Reset Controller on AXG and compatible SoCs
> + - amlogic,meson-a1-reset # Reset Controller on A1 and compatible SoCs
> + - amlogic,meson-s4-reset # Reset Controller on S4 and compatible SoCs
> + - amlogic,t7-reset
> + - items:
> + - enum:
> + - amlogic,a4-reset
> + - amlogic,a5-reset
> + - amlogic,c3-reset
> + - const: amlogic,meson-s4-reset
Here you're changing bindings for amlogic,c3-reset, move it in the other enum list.
Neil
>
> reg:
> maxItems: 1
next prev parent reply other threads:[~2024-07-03 7:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 6:16 [PATCH 0/3] reset: amlogic-a4/a5: add reset driver zelong dong
2024-07-03 6:16 ` [PATCH 1/3] dt-bindings: reset: Add compatible and DT bindings for Amlogic A4/A5 Reset Controller zelong dong
2024-07-03 7:42 ` Neil Armstrong [this message]
2024-07-04 6:08 ` kernel test robot
2024-07-08 15:52 ` Rob Herring
2024-07-08 15:53 ` Rob Herring
2024-07-03 6:16 ` [PATCH 2/3] arm64: dts: amlogic: Add Amlogic A4 reset controller zelong dong
2024-07-03 6:16 ` [PATCH 3/3] arm64: dts: amlogic: Add Amlogic A5 " zelong dong
2024-07-04 7:56 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eea2d957-fb4d-4ede-9789-d1e24ef1663a@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=kelvin.zhang@amlogic.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=zelong.dong@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).