From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E6A8ECAAD3 for ; Mon, 19 Sep 2022 12:00:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uyIt7j0TbzC/OFg4poOQdhSjMajezvRndlZ8xTcKgf0=; b=WsC6GkvJG18x8E 9rILc/f7N9dBz5G0qtl/LGIKfTouT/qdtHgYrZrZB+Y8elUcU7xwFQuEu7zizeTQKcJuc0lJzt+fl ZgpKb1AJPRtX/RM6kHnRgmf6TRk4T9bskgbCfi9HO8w4D85xTVKUtfq+zmG07CE6iF7kT7TpTFXw4 q6npzMgwyz7J9Ny3jSuu+PCfq834uWPnxkgqtisNnJbz2H901LcLx2lH0oeMsoepI78S/oK1VST22 lRlZNSrNwtFNZPE489tovgWcbPPJdbSayrNM6Uvjn3ogIXO5+/h+NhYEl8+elkYbcv/A8WTuBaZAf vMSz4wz0xvB1hN09Dq1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaFQa-00BcmL-6m; Mon, 19 Sep 2022 11:59:08 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaFQV-00BckA-RQ for linux-arm-kernel@lists.infradead.org; Mon, 19 Sep 2022 11:59:05 +0000 Received: by mail-lf1-x129.google.com with SMTP id o2so44340678lfc.10 for ; Mon, 19 Sep 2022 04:58:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=tOSWQ/Fkk0V5oAcdCK1GczlPJaCXPeT7oD2Ukr849gI=; b=ud8s1MDjz5DX1o47iaJrLJF00O4hgWcsSs4er19vmHaPKcrqBfPysZ3TwkVrzhEr45 25HKqPWspOgbLAGoPSu1xN+HGQLU9ZcdoNW7eHHYRRlnF82EvqCnDCZREAVj5j5+Qks/ BaTEgJkD1GAYxtIHBV2NHPjwpOIDXkMXM2Tp0WJ3LphcddWQvJaaJiUiDUVko0zHtiBC eCKvzETT3zU/u82k0ZGnmPXggaQ1qZCIsnhX1AtuJ8YXc+hrs6xWD7lTmDUgB79yGe8f rfEFfAFco+cIdLL5HRiC4/vgNa0TWpe24JFgCwRMhvoIwkdN7kFwm9jMHn+u0bBRWah6 pMnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=tOSWQ/Fkk0V5oAcdCK1GczlPJaCXPeT7oD2Ukr849gI=; b=q2NIsNvjaLgIjzaBWbtyhcTWjG3LkclL7XaZxK+E6GNvc666eMZUr2VCTyVfatG/HK tBh78LT4vlEgER70ln/ZpaHKwMGani/7heTzPCLGO/XxsiuxYUDvkrsiHmt98oArXHca 7vW9Ryh2GGy1niTi0EdDhD6R89r/YkIfV5xjgNhjBu+tlDAsSLYpBVHLnj2j97IHDOB7 2UZbXB92HFM0qcOLWvYsykiSGfNIqCIl570YS3lSxWAqaNAP6CxtpzlOb2XdmCoqIfNX Sd04ZHqQ7lTyAh3yULyPBVAF558C3o3di2E4PVfJltoe0GRIPNXwgKmzQsbREkFzyhsp Qd4w== X-Gm-Message-State: ACrzQf27Fz/dywCfIrjnER6f43dw2cHnswSLkeYGRBtjtvTBdlutEYKY hHUa4K6qCeI93q4GR5cv6NtLkA== X-Google-Smtp-Source: AMsMyM5q+6jx2f3SL4JC+p1u5O/iO5UAPFCnIdCUDD/xQ+gkohX0TWipZ7CN/CJOab2xJP98btYxmg== X-Received: by 2002:a05:6512:c17:b0:498:f034:1c30 with SMTP id z23-20020a0565120c1700b00498f0341c30mr5879136lfu.408.1663588738088; Mon, 19 Sep 2022 04:58:58 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id o3-20020a2e7303000000b0026bca725cd0sm4881188ljc.39.2022.09.19.04.58.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 04:58:57 -0700 (PDT) Message-ID: Date: Mon, 19 Sep 2022 14:58:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v2] firmware/psci: Print a warning if PSCI doesn't accept PC mode Content-Language: en-GB To: Mark Rutland Cc: Ulf Hansson , "Rafael J. Wysocki" , Daniel Lezcano , Lorenzo Pieralisi , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org References: <20220804130750.3706897-1-dmitry.baryshkov@linaro.org> From: Dmitry Baryshkov In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220919_045903_957567_730D3186 X-CRM114-Status: GOOD ( 19.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/08/2022 17:19, Mark Rutland wrote: > On Thu, Aug 04, 2022 at 04:07:50PM +0300, Dmitry Baryshkov wrote: >> The function psci_pd_try_set_osi_mode() will print an error if enabling >> OSI mode fails. To ease debugging PSCI issues print corresponding >> message if switching to PC mode fails too. >> >> Signed-off-by: Dmitry Baryshkov > > Acked-by: Mark Rutland > > Mark. Granted that this patch has been acked by the maintainers of PSCI interface, how do I proceed? Should I submit it to Russel's patch tracker? Or do PSCI patches land via some other tree? > >> --- >> This is a replacement for [1], now moving the warning from >> psci_set_osi_mode() callers to the function iself. >> >> https://lore.kernel.org/all/20220727182034.983727-1-dmitry.baryshkov@linaro.org/ >> >> --- >> drivers/cpuidle/cpuidle-psci-domain.c | 4 +--- >> drivers/firmware/psci/psci.c | 2 ++ >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/cpuidle/cpuidle-psci-domain.c b/drivers/cpuidle/cpuidle-psci-domain.c >> index 3db4fca1172b..821984947ed9 100644 >> --- a/drivers/cpuidle/cpuidle-psci-domain.c >> +++ b/drivers/cpuidle/cpuidle-psci-domain.c >> @@ -124,10 +124,8 @@ static bool psci_pd_try_set_osi_mode(void) >> return false; >> >> ret = psci_set_osi_mode(true); >> - if (ret) { >> - pr_warn("failed to enable OSI mode: %d\n", ret); >> + if (ret) >> return false; >> - } >> >> return true; >> } >> diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c >> index cfb448eabdaa..1628f1edef4a 100644 >> --- a/drivers/firmware/psci/psci.c >> +++ b/drivers/firmware/psci/psci.c >> @@ -163,6 +163,8 @@ int psci_set_osi_mode(bool enable) >> PSCI_1_0_SUSPEND_MODE_PC; >> >> err = invoke_psci_fn(PSCI_1_0_FN_SET_SUSPEND_MODE, suspend_mode, 0, 0); >> + if (err < 0) >> + pr_warn("failed to set %s mode: %d\n", enable ? "OSI" : "PC", err); >> return psci_to_linux_errno(err); >> } >> >> -- >> 2.35.1 >> -- With best wishes Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel