From: Jinjie Ruan <ruanjinjie@huawei.com>
To: Will Deacon <will@kernel.org>
Cc: <catalin.marinas@arm.com>, <mark.rutland@arm.com>,
<dianders@chromium.org>, <swboyd@chromium.org>,
<sumit.garg@linaro.org>, <frederic@kernel.org>,
<scott@os.amperecomputing.com>, <misono.tomohiro@fujitsu.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: smp: Fix missing IPI statistics
Date: Thu, 20 Jun 2024 11:52:13 +0800 [thread overview]
Message-ID: <eeb78b0e-73cf-37ae-d780-08ae6b8211ac@huawei.com> (raw)
In-Reply-To: <20240619133258.GA3526@willie-the-truck>
On 2024/6/19 21:32, Will Deacon wrote:
> On Fri, Jun 07, 2024 at 03:47:16PM +0800, Jinjie Ruan wrote:
>> commit 83cfac95c018 ("genirq: Allow interrupts to be excluded from
>> /proc/interrupts") is to avoid IPIs appear twice in /proc/interrupts.
>> But the commit 331a1b3a836c ("arm64: smp: Add arch support for backtrace
>> using pseudo-NMI") and commit 2f5cd0c7ffde("arm64: kgdb: Implement
>> kgdb_roundup_cpus() to enable pseudo-NMI roundup") set CPU_BACKTRACE and
>> KGDB_ROUNDUP IPIs "IRQ_HIDDEN" flag but not show them in
>> arch_show_interrupts(), which cause the interrupt kstat_irqs accounting
>> is missing in display.
>>
>> Fixes: 331a1b3a836c ("arm64: smp: Add arch support for backtrace using pseudo-NMI")
>> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
>> ---
>> arch/arm64/kernel/smp.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
>> index 31c8b3094dd7..7f9a5cf0f3b8 100644
>> --- a/arch/arm64/kernel/smp.c
>> +++ b/arch/arm64/kernel/smp.c
>> @@ -1039,7 +1039,8 @@ void __init set_smp_ipi_range(int ipi_base, int n)
>> }
>>
>> ipi_desc[i] = irq_to_desc(ipi_base + i);
>> - irq_set_status_flags(ipi_base + i, IRQ_HIDDEN);
>> + if (i < NR_IPI)
>> + irq_set_status_flags(ipi_base + i, IRQ_HIDDEN);
>> }
>
> Please can you show the contents of /proc/interrupts before and after
> this patch and put that in the commit message? I'm not seeing how the
> two new IPIs get picked up by arch_show_interrupts().
Before this patch, CPU_BACKTRACE and KGDB_ROUNDUP IPIs are missing as below:
/ # cat /proc/interrupts
CPU0 CPU1 CPU2 CPU3
11: 463 656 243 654 GICv3 27 Level
arch_timer
13: 14 0 0 0 GICv3 33 Level
uart-pl011
17: 0 0 0 0 ITS-MSI 16384 Edge
virtio2-config
18: 0 5 0 0 ITS-MSI 16385 Edge
virtio2-input
19: 68 0 0 0 GICv3 78 Edge
virtio0
20: 0 0 0 0 GICv3 79 Edge
virtio1
21: 0 0 0 0 GICv3 34 Level
rtc-pl031
22: 2 2 2 2 GICv3 23 Level
arm-pmu
23: 0 0 0 0 ITS-MSI 32768 Edge
virtio3-config
24: 0 0 0 0 ITS-MSI 32769 Edge
virtio3-requests
25: 0 0 0 0 9030000.pl061 3 Edge
GPIO Key Poweroff
IPI0: 15 13 5 21 Rescheduling
interrupts
IPI1: 385 129 282 194 Function call
interrupts
IPI2: 0 0 0 0 CPU stop interrupts
IPI3: 0 0 0 0 CPU stop (for
crash dump) interrupts
IPI4: 0 0 0 0 Timer broadcast
interrupts
IPI5: 1 0 0 0 IRQ work interrupts
Err: 0
After this patch the hwirq6/7 IPI is also displayed:
/ # cat /proc/interrupts
CPU0 CPU1 CPU2 CPU3
7: 0 0 0 0 GICv3 6 Edge IPI
8: 0 0 0 0 GICv3 7 Edge IPI
11: 414 433 424 422 GICv3 27 Level
arch_timer
13: 21 0 0 0 GICv3 33 Level
uart-pl011
17: 0 0 0 0 ITS-MSI 16384 Edge
virtio2-config
18: 0 6 0 0 ITS-MSI 16385 Edge
virtio2-input
19: 60 0 0 0 GICv3 78 Edge
virtio0
20: 0 0 0 0 GICv3 79 Edge
virtio1
21: 0 0 0 0 GICv3 34 Level
rtc-pl031
22: 3 3 3 3 GICv3 23 Level
arm-pmu
23: 0 0 0 0 ITS-MSI 32768 Edge
virtio3-config
24: 0 0 0 0 ITS-MSI 32769 Edge
virtio3-requests
25: 0 0 0 0 9030000.pl061 3 Edge
GPIO Key Poweroff
IPI0: 15 13 19 12 Rescheduling
interrupts
IPI1: 241 162 328 252 Function call
interrupts
IPI2: 0 0 0 0 CPU stop interrupts
IPI3: 0 0 0 0 CPU stop (for
crash dump) interrupts
IPI4: 0 0 0 0 Timer broadcast
interrupts
IPI5: 0 1 0 0 IRQ work interrupts
Err: 0
>
> Thanks,
>
> Will
next prev parent reply other threads:[~2024-06-20 3:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 7:47 [PATCH] arm64: smp: Fix missing IPI statistics Jinjie Ruan
2024-06-07 16:02 ` Doug Anderson
2024-06-14 2:48 ` Jinjie Ruan
2024-06-19 13:32 ` Will Deacon
2024-06-20 3:52 ` Jinjie Ruan [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-06-20 6:34 Jinjie Ruan
2024-06-20 22:26 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eeb78b0e-73cf-37ae-d780-08ae6b8211ac@huawei.com \
--to=ruanjinjie@huawei.com \
--cc=catalin.marinas@arm.com \
--cc=dianders@chromium.org \
--cc=frederic@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=misono.tomohiro@fujitsu.com \
--cc=scott@os.amperecomputing.com \
--cc=sumit.garg@linaro.org \
--cc=swboyd@chromium.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox