From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21408CED256 for ; Tue, 8 Oct 2024 02:31:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JLu2GkrJyIH/iXx8pdbjQNyQU8u3ariQBugLwkrciVs=; b=Z50rhjhSaeUQJuCwFHLVnBOpuj khM9fsRARxDCtTH/Sb+uVyxythO4t230GUiiN6AgskphkAMOXekZeA1qPjvHUQZstL7z04a9yxYUS uNycJU8UWSPtsQMeB9f9JpgNgP25fk09jpQ1kNAAG4R9x2httkvaQNP4vcLoahJHUKWvG7HK/LvlX wTQWKzq+CMDpnaZWcp+Wep1nWcJYsxbhOzqNxaOAm7B997FE531lEvHaejEfyhiTjTAl9bz9zTgJS mGMNehxkf0Pg4WiO8CSG5r6hJT7lYHCLL7khxgYuURP8833Co26BHHmDRZ8RdfC2Stpx0xpfS+jlb l/iVZuBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sy00b-00000004ILD-10fu; Tue, 08 Oct 2024 02:31:33 +0000 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sxzzI-00000004I5j-13CT; Tue, 08 Oct 2024 02:30:14 +0000 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-7d4f85766f0so4156114a12.2; Mon, 07 Oct 2024 19:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728354611; x=1728959411; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JLu2GkrJyIH/iXx8pdbjQNyQU8u3ariQBugLwkrciVs=; b=LEcSAPcazxEKo2hKS26MNkgJIJfdctMo6EyGywbAtzXtoSl5xthCFYxxZ5XGN/RdzQ BK84c3qOy3pY7eBf/ltvIkVpIf2pVJpJ8ZpWsL0VyRDOiJl7s5NlXmTqqPg3NxJKm/fC DO7nMqzdO5htEKK6qLuMfaau2Fq2uRdhJx4+pBDE41jDKnQr68cXyFMOlUALJF9ybVT8 MSol6Xr4vlz+1s3aPtuxoQnCrbZFLq7pu8E9Dguac1TqSkrouh1rKigLz3YL6KXLHfHJ yX2XEzDx+REwdLYrK7cemfUp9iro3+DK1Go1K6FW0xZSWBSzG9WiG2sjjizNPqzxC+p0 NQcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728354611; x=1728959411; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JLu2GkrJyIH/iXx8pdbjQNyQU8u3ariQBugLwkrciVs=; b=Y5nhs0cwrfoQI4yVRJsS0OZsr+mWX/tZHJ9sNBKD+zYFhWdKqHDnwnTcT65yDctHBf 8+gSpaze068V3eb6hZmyoiV91nYmQhOeVEOjGkuzmAMZBlIU4IbNBq71fuaJ/dRedlsN Z8qzsAkWz/gZZewtABNNVuT44E1MM4P2TzT8Qxh9Zw5S9a1fP/p9xRgDIT8MbG6TEjY/ JFAfm+5gGsLRANOAuR5EY1e1jhjY5eC1NbgI/I+BtCO6w0wBozLVspKGGdchJdMDaBvJ IeKe3y3giN77vpoRe+ZSEdlrS56NhyG3bA2VrUWy/NWXGrFgsGTtyuU9chrsrly/+r4a CBZQ== X-Forwarded-Encrypted: i=1; AJvYcCWJtoVWKDxIwu5iidPp1BTVq5svMHx3wsS/RtV8CVAx8kThk4DdHk20nMlo2E5Mr13wRt6NjGnr5UXQxPd9CNiO@lists.infradead.org, AJvYcCXX3CNxo0THtqg3OiWuRN2n0c0q2oVTtJcX3/pXWeBEz4CZRQlGBt23cIdx1wOOtb706D/MMY2cnAvy@lists.infradead.org X-Gm-Message-State: AOJu0Ywf/BrnCi4fiJLyoEWUsF1k2UI2ElywrZ4/YuBYeJyLN86pj92r drWiMcaJdE8TOvWwTOnPjPI6ZOAe/yluDd+iMPyhpWTHq7Y/PQ5g X-Google-Smtp-Source: AGHT+IGeQEqLzuvHuWusEN4nVLoxNffXjEIhVExhavgblUpbYb87p1OahnMRUqzEYA2b6qstnKCPfA== X-Received: by 2002:a05:6a21:1788:b0:1ce:d08c:2c10 with SMTP id adf61e73a8af0-1d6dfa55709mr20715014637.28.1728354610971; Mon, 07 Oct 2024 19:30:10 -0700 (PDT) Received: from [172.19.1.53] (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e28213ce28sm386873a91.40.2024.10.07.19.30.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Oct 2024 19:30:10 -0700 (PDT) Message-ID: Date: Tue, 8 Oct 2024 10:30:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 1/2] dt-bindings: mtd: nuvoton,ma35d1-nand: add new bindings To: Miquel Raynal Cc: richard@nod.at, vigneshr@ti.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, nikita.shubin@maquefel.me, arnd@arndb.de, vkoul@kernel.org, esben@geanix.com, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski References: <20240927020749.46791-1-hpchen0nvt@gmail.com> <20240927020749.46791-2-hpchen0nvt@gmail.com> <20241001121902.658d3977@xps-13> Content-Language: en-US From: Hui-Ping Chen In-Reply-To: <20241001121902.658d3977@xps-13> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241007_193012_321406_891EADBF X-CRM114-Status: GOOD ( 14.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dear Miquel, Thank you for your reply. On 2024/10/1 下午 06:19, Miquel Raynal wrote: > Hi Hui-Ping, > > hpchen0nvt@gmail.com wrote on Fri, 27 Sep 2024 02:07:48 +0000: > >> Add dt-bindings for the Nuvoton MA35 SoC NAND Controller. >> >> Signed-off-by: Hui-Ping Chen >> Reviewed-by: Krzysztof Kozlowski >> --- >> .../bindings/mtd/nuvoton,ma35d1-nand.yaml | 93 +++++++++++++++++++ >> 1 file changed, 93 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mtd/nuvoton,ma35d1-nand.yaml >> >> diff --git a/Documentation/devicetree/bindings/mtd/nuvoton,ma35d1-nand.yaml b/Documentation/devicetree/bindings/mtd/nuvoton,ma35d1-nand.yaml >> new file mode 100644 >> index 000000000000..a8a549644c98 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mtd/nuvoton,ma35d1-nand.yaml >> @@ -0,0 +1,93 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/mtd/nuvoton,ma35d1-nand.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Nuvoton MA35D1 NAND Flash Interface (NFI) Controller >> + >> +maintainers: >> + - Hui-Ping Chen >> + >> +allOf: >> + - $ref: nand-controller.yaml# >> + >> +properties: >> + compatible: >> + enum: >> + - nuvoton,ma35d1-nand-controller >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> +patternProperties: >> + "^nand@[a-f0-9]$": >> + type: object >> + $ref: raw-nand-chip.yaml >> + properties: >> + nand-ecc-step-size: >> + enum: [512, 1024] >> + >> + nand-ecc-strength: >> + enum: [8, 12, 24] >> + >> + required: >> + - nand-ecc-step-size >> + - nand-ecc-strength > No, they should not be required, unless there is a good reason to do > so. Optimal strength is discoverable, stop forcing it by default. I will remove this required. >> + >> + unevaluatedProperties: false >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clocks >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + >> + soc { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> + nand-controller@401A0000 { >> + compatible = "nuvoton,ma35d1-nand-controller"; >> + reg = <0x0 0x401A0000 0x0 0x1000>; >> + interrupts = ; >> + clocks = <&clk NAND_GATE>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + nand@0 { >> + reg = <0>; >> + >> + nand-on-flash-bbt; >> + nand-ecc-step-size = <512>; >> + nand-ecc-strength = <8>; >> + >> + partitions { >> + compatible = "fixed-partitions"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + uboot@0 { >> + label = "nand-uboot"; >> + read-only; >> + reg = <0x0 0x300000>; >> + }; >> + }; >> + }; >> + }; >> + }; >> + >> +... > > Thanks, > Miquèl Best regards, Hui-Ping Chen