From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99C05C4360F for ; Thu, 28 Feb 2019 11:49:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 67D5A2083D for ; Thu, 28 Feb 2019 11:49:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="nudE7YET" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67D5A2083D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ef4z3Vhn+nX2pRH3hhV3A40NhToPTU6MjB8JU2Lx9+c=; b=nudE7YETIDc3Ip O5raY28kiZm9Y+Yxsm9q0+t9JCu1ANAK8f7Ei9b7dkfmOKv/o7lY52u5L6OmZX/qe0bsKlD/wp3+e p8qam34MKalwITTXbiPGrtLIix2/Rr8hYGx6x9Wpa7cSP3l3Ex3pV8tTtlUbLCZL3Sfa2tX9Y+Tlp kjYm5cIGtPhyIuBfNQrRaI3O4Ui/JI+TuhFD3MVfuvJHGm5DimWJsip4bxhUwPbiXzUydp2qJIANI W7ysIcSb3+U4DbWug2y21dZxeyE92TILV9efUT0kdM1oDCK4UodPgrsKB3GVAty4lXCH88TzFECSx AIpWY4a5/55y7rBFq/Fg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzKCA-0003WN-Sm; Thu, 28 Feb 2019 11:49:46 +0000 Received: from foss.arm.com ([217.140.101.70]) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzKC5-0003V2-WD for linux-arm-kernel@lists.infradead.org; Thu, 28 Feb 2019 11:49:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B29A880D; Thu, 28 Feb 2019 03:49:40 -0800 (PST) Received: from [10.1.196.69] (e112269-lin.cambridge.arm.com [10.1.196.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6EDAB3F738; Thu, 28 Feb 2019 03:49:37 -0800 (PST) Subject: Re: [PATCH v3 20/34] sparc: mm: Add p?d_large() definitions To: David Miller References: <20190227170608.27963-1-steven.price@arm.com> <20190227170608.27963-21-steven.price@arm.com> <20190227.103837.668255833945043179.davem@davemloft.net> From: Steven Price Message-ID: Date: Thu, 28 Feb 2019 11:49:35 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <20190227.103837.668255833945043179.davem@davemloft.net> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190228_034942_036373_C7364F9D X-CRM114-Status: GOOD ( 12.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark.Rutland@arm.com, dave.hansen@linux.intel.com, arnd@arndb.de, ard.biesheuvel@linaro.org, peterz@infradead.org, catalin.marinas@arm.com, x86@kernel.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, jglisse@redhat.com, mingo@redhat.com, bp@alien8.de, luto@kernel.org, hpa@zytor.com, sparclinux@vger.kernel.org, james.morse@arm.com, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, kan.liang@linux.intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/02/2019 18:38, David Miller wrote: > From: Steven Price > Date: Wed, 27 Feb 2019 17:05:54 +0000 > >> walk_page_range() is going to be allowed to walk page tables other than >> those of user space. For this it needs to know when it has reached a >> 'leaf' entry in the page tables. This information is provided by the >> p?d_large() functions/macros. >> >> For sparc, we don't support large pages, so add stubs returning 0. >> >> CC: "David S. Miller" >> CC: sparclinux@vger.kernel.org >> Signed-off-by: Steven Price > > Sparc does support large pages on 64-bit, just not at this level. It > would be nice if the commit message was made more accurate. Yes you are right, I fear I only looked at the 32 bit changes when I wrote the commit message. I'll clarify the difference between 32/64 bit. > Other than that: > > Acked-by: David S. Miller Thanks, Steve _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel