From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D0AAC27C4F for ; Wed, 26 Jun 2024 17:27:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=shjrQOgLm3XfFHmcQBDx0vYvLb6ShIsh3+fZWsScilM=; b=QQtKee2g2VjIj2MDRs66996ADl vIKrj5aWnJ8pQGeE52yeLcnHDxSVPZ1u+SEWwwmBWQSmugSVlcgr0yP4sN8wtnJDSEDyA1HDdAS6S ksZz4cop7XnpXJ4g1VUVTVT6S1vJ/Ik62VgD0CIDVhwaV3D3sOYwc9nEC9qPYvKzBd5G+ZEN4nZxn 6q2fRfkzxa5c5VTuTtvWHMmPjrQ2PgDjr3B5dfSiIJMZwG/ESgGjaU371wAPQ8a+iBOgytCXvc8U/ W1bTTIwdchKSdLK/AtVJ7AiUEq/VEf86ixRu2orJbJsciXlRFpwy6mFLBDqXsbi/CxQmKAKhW2xtB aUkzjzkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMWPu-00000007lKe-2hP1; Wed, 26 Jun 2024 17:26:46 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMWPn-00000007lHo-340W for linux-arm-kernel@lists.infradead.org; Wed, 26 Jun 2024 17:26:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=shjrQOgLm3XfFHmcQBDx0vYvLb6ShIsh3+fZWsScilM=; b=THZBAYg6BuxoU53DcDGfN8IP6l R451SX0J+E/Sz4UUSDzM2ZH7F5hIBbxe0MTCREd0Rn5JG5lStHz/nyw7AhE8BKOFAWT2hvH4yHqyW T+XexreCT2bQVOJqVc7bg05rkbA7LZliRwMTgVjYbA3U9zct4QBhOX3QjEHzjoJIzEEI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1sMWPg-0013pv-6T; Wed, 26 Jun 2024 19:26:32 +0200 Date: Wed, 26 Jun 2024 19:26:32 +0200 From: Andrew Lunn To: Devi Priya Cc: Devi Priya , catalin.marinas@arm.com, u-kumar1@ti.com, linux-arm-kernel@lists.infradead.org, krzk+dt@kernel.org, geert+renesas@glider.be, neil.armstrong@linaro.org, nfraprado@collabora.com, mturquette@baylibre.com, linux-kernel@vger.kernel.org, dmitry.baryshkov@linaro.org, netdev@vger.kernel.org, konrad.dybcio@linaro.org, m.szyprowski@samsung.com, arnd@arndb.de, richardcochran@gmail.com, will@kernel.org, sboyd@kernel.org, andersson@kernel.org, p.zabel@pengutronix.de, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH V5 4/7] dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions Message-ID: References: <20240626143302.810632-1-quic_devipriy@quicinc.com> <20240626143302.810632-5-quic_devipriy@quicinc.com> <171941612020.3280624.794530163562164163.robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <171941612020.3280624.794530163562164163.robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240626_102640_045089_A25A40C4 X-CRM114-Status: GOOD ( 15.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 26, 2024 at 09:35:20AM -0600, Rob Herring (Arm) wrote: > > On Wed, 26 Jun 2024 20:02:59 +0530, Devi Priya wrote: > > Add NSSCC clock and reset definitions for ipq9574. > > > > Signed-off-by: Devi Priya > > Reviewed-by: Krzysztof Kozlowski > > --- > > Changes in V5: > > - Dropped interconnects and added interconnect-cells to NSS > > clock provider so that it can be used as icc provider. > > > > .../bindings/clock/qcom,ipq9574-nsscc.yaml | 74 +++++++++ > > .../dt-bindings/clock/qcom,ipq9574-nsscc.h | 152 ++++++++++++++++++ > > .../dt-bindings/reset/qcom,ipq9574-nsscc.h | 134 +++++++++++++++ > > 3 files changed, 360 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml > > create mode 100644 include/dt-bindings/clock/qcom,ipq9574-nsscc.h > > create mode 100644 include/dt-bindings/reset/qcom,ipq9574-nsscc.h > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Error: Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.example.dts:26.26-27 syntax error > FATAL ERROR: Unable to parse input tree Hi Devi Version 4 of these patches had the same exact problem. There was not an email explaining it is a false positive etc, so i have to assume it is a real error. So why has it not been fixed? Qualcomm patches are under a microscope at the moment because of how bad things went a couple of months ago with patches. You cannot ignore things like this, because the damage to Qualcomm reputation is going to make it impossible to get patches merged soon. Andrew