From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25778C52D7C for ; Tue, 13 Aug 2024 13:34:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=blnF+SdPapTZEU9MsVd32ouo1/9eYNSeUZmt+Hr0sT8=; b=qsC2Tqy27WgtTbYvl8+I4z+idZ uxbgu4cIIl7BLN53LU0DJrfVc7a2pMwK5prtxXiMNoN9i/m9i6ha+8WGoAe6GhdtVelgJ9nUEF4ax eXCFgQoeYzTOGQmX1z3GyaqcxkoOYfc4kghuBV0oPJpoZAMkjjAppDrVU/2Q7lpZjYRyU43yEGvuj ++z3Ia3n+k/DEK5Fsib0JqorMM66eWCAoSQt6o/Yzy3ij0XpkSSEKXjWahNlclnLp/fZ2cBCLVfjQ H/qp/dee16hQSOIA7NSBya2r1B7l8aWP2P5XJ+YAEdoYJwBz0kJ0nu+OF6MztaWCyoLv9FA0Q/MF4 4/NpDvXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdrfH-00000003tD7-1LYX; Tue, 13 Aug 2024 13:34:19 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sdree-00000003t3F-0UEg for linux-arm-kernel@lists.infradead.org; Tue, 13 Aug 2024 13:33:41 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-428243f928cso38753205e9.3 for ; Tue, 13 Aug 2024 06:33:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1723556018; x=1724160818; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=blnF+SdPapTZEU9MsVd32ouo1/9eYNSeUZmt+Hr0sT8=; b=xxSF55SWB83N1xe1VX36BMY3/ooThbnUkhJBxIVtdrdlkXD05BjfSUh1bxNi6FSn5U EHjQht3Dk2W5sJLaHxgMD2D5MIH9bqTCh05jDiJLVwyYagX3RzDwNwmsLkepityLirWI JwjOrQkCV+ClP6+OSzCNG3URLaZpDG0rZxAdAF/lfYWGj5Nzel2vGG/TVmJEJs/UPPME J9w6jengCu/GLl5WRVhDU6eM+gO/CUVd/fHKmhNnwRm3UGN1OMdiB31b0uqlPDY1I5lm 0WxQtANbA7aqiNdBuOkQBK9ErUdmChnDOC40oarcfxIFmhZ99gxUePV2NKT0JI8XJKt6 vg7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723556018; x=1724160818; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=blnF+SdPapTZEU9MsVd32ouo1/9eYNSeUZmt+Hr0sT8=; b=nfdlXb6FZkNY7eEF2o7Rv2DHISbLI08nJf0p8eJ9nbZqx6nS/94qVICp7QK2IPQ/IX dDKp9LLCwX6WZ3h0EsJOJPF+IT3Ky9G7XIqux82TI6B24f8/by7NuagZZqnh6G2LeImV 3BlpzRv7SmbUaFKwkudpW9IzxNF1p6spSed0ECXFD1sph5L56xw/EtVnXTi9S4V4BZwS JDyZgjxfcY/Ak17V3anIZvOghZtxp+k+NhxghpxnRrMZvPj9VNBFCnWhWdoWVNF7e7LM vxI4DVsSZhB2UnTM+7ZqTPpUetcVgKgcPQD0/QlsfASfQn7up48E0yQ7UrvKQHBjgAm9 zHfA== X-Forwarded-Encrypted: i=1; AJvYcCWzQkwnueMpuFekEwHTAy+vXXmCbbIZNp43Hgj/JHNk+PUUbBMC/YwBWMQkFEd/ftv2H/3DWHjFfRFtw9Ux2jt3VJo1wSwqRfGZI+fTGdfISIxE97E= X-Gm-Message-State: AOJu0Yxc8pEJWkX6DL7mm45uVKVFBugp5PI1IZOpdEyIUuNgb0QoxHlp Cl/PV3XYVE4VpoHcYGEprUUoW6bCoBAWPies/P5ezLgB0DcR/O/IjyJkHouwNmY= X-Google-Smtp-Source: AGHT+IF0uGrRR7ZTGnQGQ51jKZOJySZ2yoFMxi1e5EZJfGqN/H8HsMXe/0fLFQwn0tC6OvUNOaOt3A== X-Received: by 2002:a05:600c:1c27:b0:428:1965:450d with SMTP id 5b1f17b1804b1-429d4837e17mr28119195e9.17.1723556018249; Tue, 13 Aug 2024 06:33:38 -0700 (PDT) Received: from [192.168.1.3] ([89.47.253.130]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4290c777017sm225862565e9.35.2024.08.13.06.33.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Aug 2024 06:33:37 -0700 (PDT) Message-ID: Date: Tue, 13 Aug 2024 14:33:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/7] perf evlist: Use hybrid default attrs whenever extended type is supported To: irogers@google.com, linux-perf-users@vger.kernel.org Cc: John Garry , Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Adrian Hunter , "Liang, Kan" , Dominique Martinet , Yang Jihong , Ze Gao , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240813132323.98728-1-james.clark@linaro.org> <20240813132323.98728-6-james.clark@linaro.org> Content-Language: en-US From: James Clark In-Reply-To: <20240813132323.98728-6-james.clark@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240813_063340_192902_DCF01567 X-CRM114-Status: GOOD ( 14.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/08/2024 2:23 pm, James Clark wrote: > For x86, a hybrid version of ___evlist__add_default_attrs() was added to > support default perf stat events. This can actually be used whenever > perf_pmus__supports_extended_type() is true, which now makes default > perf stat arguments work properly on Arm big.LITTLE: > > $ perf stat > ... > 3347093940 armv8_cortex_a53/cycles/ # 0.563 GHz (98.99%) > 3295523067 armv8_cortex_a57/cycles/ # 0.554 GHz (67.07%) > ... > > Signed-off-by: James Clark > --- > tools/perf/arch/x86/util/evlist.c | 65 ------------------------------- > tools/perf/util/evlist.c | 65 +++++++++++++++++++++++++++---- > tools/perf/util/evlist.h | 6 +-- > 3 files changed, 59 insertions(+), 77 deletions(-) > [...] > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c > index 1417f9a23083..e0c31399beb6 100644 > --- a/tools/perf/util/evlist.c > +++ b/tools/perf/util/evlist.c > @@ -5,6 +5,7 @@ > * Parts came from builtin-{top,stat,record}.c, see those files for further > * copyright notes. > */ > +#include "pmus.h" Oops, this include was auto added and isn't required.