From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF120C47073 for ; Wed, 10 Jan 2024 20:37:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yhhsVrDLKWbRGTMEyHfE+VhF4+/v7x7nY8mHcHAvXrM=; b=isPYrXRC+J+5JU KyyqVKNLc7hGzJW+T0+P8aKRhz3HT20M/cTZTUf0Q+Ak+qphcU9ztpoJTWKnp8sqSIq55R0F4GuAd 5GV02W6sk1KQSHE2ePJayDJU+RZkx1wWmNORMcUgOhch0+egR0FgjHvjAp3i7F1QP9EcC/sZgyTK9 0T0e45S4e8pcn7jJfMt6nceV3RG3jEfionagAxLO6c1dHXEaUfKC6I+ZZt2OoqQGh+d0vsyY0EaN3 ItOg/y1xd0rVFqGgl5tdDEKc+trpt7ZcMIK086x93EvPcv0Y2jK18+7jQQapp2wjPEPBUC8rXrwpE f1DfySe8X4Fdw9k5Gt9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rNfJn-00E1LY-1q; Wed, 10 Jan 2024 20:36:55 +0000 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rNfJk-00E1J5-1G for linux-arm-kernel@lists.infradead.org; Wed, 10 Jan 2024 20:36:54 +0000 Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2cd853c159eso157991fa.2 for ; Wed, 10 Jan 2024 12:36:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704919010; x=1705523810; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=vF5tupcUeWkTYyiJxCJd6V7g3X/1lq74f/KLJG4DSME=; b=SYo1DzV2RNx10wf4C8HpfltyMad20X3V6P5X32B+4dPojtD5c61RmBmyLo8+a57TO7 Ypb/yYtCW+4daAQ5LCQWOvjXr1O5x92IeMyvIs7E3OhEJaamyPr+M8qDG4ZfgDDlTkK3 9l8/KbgVL3W22Uipy9Kal6eHx6+xfDIgRnJS+nv4hrJmPVPqFF2v0/WL/Aie5frUwYhC nXKz9ZybssVU4I2v+mTPBwG8QTfuh3ggbOAXCjY88uhAUagZAwCOPhg15cSWz/1PjaOk dPDeZhSgDQrdGnXJDRcST5A4MDj2LQMfcBgqn99CcTC4fgzSlXYKDOm6cFnm7oEtiDbZ /eGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704919010; x=1705523810; h=content-transfer-encoding:in-reply-to:autocrypt:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vF5tupcUeWkTYyiJxCJd6V7g3X/1lq74f/KLJG4DSME=; b=KF8nfgtHdOEIdNxI790omPSQwaPfwyr8EFfGJ6iAoPxEvrnuVsoEV8uTxn3Hu/5dyT sDLsWy3EkkSYlpskD/V7rkONzESgU2Q7CIysHWHdRCcbXqLzmuILcN2dLT/LtEB/Aeuk feG3KwwYXHlHOjO3+DaF+08x4MVLiodziIB/ra9Wp4RDcL/Icz4hNKtqM372d0/AAEi4 p3+PI/t8SCcgMwY+kWy2GLne4eIwlzOxJzUSf3mGWLLo80SmxAoCWSbgHIRH4E1K5AKI bWxgu6BdVbQBwws5SEt3HFtbuHmoWP6MawkRgXs52jDzf6OCeBAhIDn2sPSvOCkxEbEG kB+Q== X-Gm-Message-State: AOJu0YyysBa1WjSY5GJytsCcw8TPJ7wD+mEHlvHCq9xI8nf8ei+LS2fM ppA/UTHSEEKzbTvL6kUyCmDKCudSrxtqhA== X-Google-Smtp-Source: AGHT+IF5zSjWoDPn7CNER2fBW1ddHR+9FT1AiH7W996NoEg1yiOxXBFr3ZSsVpapQPPyOnMTjKVqGA== X-Received: by 2002:a2e:8205:0:b0:2cd:690d:5d37 with SMTP id w5-20020a2e8205000000b002cd690d5d37mr76802ljg.29.1704919009786; Wed, 10 Jan 2024 12:36:49 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.112]) by smtp.gmail.com with ESMTPSA id x17-20020aa7d391000000b00556cf695da0sm2310685edq.78.2024.01.10.12.36.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Jan 2024 12:36:48 -0800 (PST) Message-ID: Date: Wed, 10 Jan 2024 21:36:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 7/8] tpm: tis-i2c: Add more compatible strings Content-Language: en-US From: Krzysztof Kozlowski To: Guenter Roeck , Ninad Palsule , Conor Dooley Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au, peterhuewe@gmx.de, jarkko@kernel.org, jgg@ziepe.ca, keescook@chromium.org, tony.luck@intel.com, gpiccoli@igalia.com, johannes.holland@infineon.com, broonie@kernel.org, patrick.rudolph@9elements.com, vincent@vtremblay.dev, peteryin.openbmc@gmail.com, lakshmiy@us.ibm.com, bhelgaas@google.com, naresh.solanki@9elements.com, alexander.stein@ew.tq-group.com, festevam@denx.de, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-hardening@vger.kernel.org, geissonator@yahoo.com References: <20231212164004.1683589-1-ninad@linux.ibm.com> <20231212164004.1683589-8-ninad@linux.ibm.com> <20231212-avid-grill-dbead068fac8@spud> <73381bb0-7fa7-4a9e-88df-ab0063058e26@roeck-us.net> <20231212-mouth-choice-40a83caa34ec@spud> <2946fbb1-2a47-4d21-83dc-8e45bf6ba5a9@roeck-us.net> <60c8bbdb-4e08-44f0-88d4-ab164d4843b5@linux.ibm.com> <20240109-pep-coerce-2a86ae88753d@spud> <01974929-dfbf-4989-ba39-369e521827d0@linux.ibm.com> <3d194e84-bf1a-48e4-a376-e5c327c6508d@linaro.org> <2dd37d2b-28da-4e73-9047-61ec5d64bdb5@linux.ibm.com> <385b06e9-1daa-408a-a0ed-7b09d7d539df@linux.ibm.com> <3830c26d-96be-4084-a04d-8edb9ccbab5e@roeck-us.net> <32d46b64-d4a5-437a-8737-c2d172608559@linaro.org> Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <32d46b64-d4a5-437a-8737-c2d172608559@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240110_123652_467474_2B240A29 X-CRM114-Status: GOOD ( 20.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/01/2024 21:34, Krzysztof Kozlowski wrote: >>>>>>>>>> I have send it as a separate commit. https://lore.kernel.org/linux-kernel/20231214144954.3833998-1-ninad@linux.ibm.com/ >>>>>>>>> Why did you do that? It now just adds undocumented compatibles to the >>>>>>>>> driver. Please, as Rob requested, work with Lukas on his series to make >>>>>>>>> sure that these devices are documented. >>>>>>>> I think krzysztof kozlowski suggested to send these patches separately: >>>>>>>> https://lore.kernel.org/linux-kernel/1c5ace65-2fd8-4503-b22f-e0f564d1c83f@linaro.org/ >>>>>>>> >>>>>>>> Did I misunderstood it? Do you guys want me to include that commit again? >>>>>>> My comment was in DTS thread under specific DTS patch. How did you >>>>>>> figure out it applies to driver and bindings? This does not make sense. >>>>>> Sorry for the misunderstanding. Where do you want me to add driver >>>>>> patch? Before all DTS patches or after all DTS patches? >>>>> Does not matter, why do you insist on combining them with DTS? Drivers >>>>> and bindings are going together. DTS better separate, although depending >>>>> on the case can be together. >>>>> >>>> I have combined DTS and Driver because DTS was using compatibility >>>> string which is not upstream yet hence I thought it is logical to send >>>> it under same patchset. >>> >>> Sometimes yes, sometimes not. DTS must not go via driver subsystem, so >>> sending it in the same patchset has implications on maintainers applying >>> it. Some like it, some don't and you will be nagged for combining them. >>> >> >> "DTS must not go via driver subsystem" >> >> I always thought the guideline was to submit separate _patches_ for dts >> and driver changes, but as part of a single series. I didn't know that >> there is a rule to submit separate patch _series_. I also didn't know >> (and as far as I know no one called me on it) that I am not supposed >> to _apply_ dts changes. So far, I typically applied dts changes together >> with driver patches after receiving an Acked-by: or Reviewed-by: >> from a devicetree maintainer. > > I did not notice you applying them, but such guideline - DTS must go via > respective SoC tree - was always repeated by me and SoC maintainers. > Just like gazillion other things probably was not documented... or even > if it was documented, it would be so deep among hundreds of other rules > nobody would find it. :) > >> >> This exchange suggests that I did it all wrong. Should I reject devicetree >> patches submitted as part of a driver patch series going forward ? > > I propose: just ignore them. The SoC maintainer will pick them up. > >> Should I not apply dts patches submitted as part of a patch series ? > > No, please do not apply them. Eh, English can be confusing. Let's make it easier to grasp: "Please do not apply DTS patches to a driver subsystem." Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel