From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D304C27C52 for ; Wed, 5 Jun 2024 08:40:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=w4bPQ4Lhortv9KbosZY3FUqBMpckSqOjKylBz3Al80w=; b=db3IQWbn6hH02R0VIXK/brIXms 3AJByID2rwAMaCKZ00VR8IOCiaxEj6fGLvyACBI5Mp3yMgQcik1FUlQuCw5dGZ9ud+kSqvw3ySiuR 8joAsrD7jff6O++wT6J9ThSIpO6m0jCopjaLFdF5E3w0F+LhDqOpc4+PYDhbT5PZkCnqXAF9vuLAI +BeN1pS0ZjE6v60OSTwHJt6jWL6o1HcdqINRzEPIq+Msp4GuxyKL7wfs5nSoJr2rEL0bHly47ReRe YTzkejAjFi/YvYq9ww7/CdRXxYS4p87mz9p2K3KXrCMm8twBgPKvEAnO92AWAqXk6FQNmO3+eiW73 QdU+zsMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEmCJ-00000005GJC-0E57; Wed, 05 Jun 2024 08:40:43 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sEmCE-00000005GH8-3wTP for linux-arm-kernel@lists.infradead.org; Wed, 05 Jun 2024 08:40:40 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 34636CE14E9; Wed, 5 Jun 2024 08:40:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6D6F8C4AF07; Wed, 5 Jun 2024 08:40:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717576836; bh=SSuUeQbO2I34BDzHIPG6kv2UTPDB/m4P39TM9c87s7U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=M8Ol6eQ8uwNDtxC0NQ5T5LtnOoyj9T/kgJ15LXylZws9yVCogCgIqt1iRnAu70HqR EKgizvqOq80Myld4yIAl2s2Qc3lBefOF0J+opuYC/n2F3LB+uM7GER6A3GSLZsFEFq GL0BcmY1L79oanQSiOMW3z6Y655VQCxMElhWuH+ctMhXdj7cAzzeVsvc54z9WxTsT/ 8GxqXFvo6yzQKV7qYAa0y7xP4v1RbLnYbRyCcikOuuZcvlZrqTsmXwcCDE3LD2VHsD DEf3GYbh7jo0TmM/Hq2dZwwo4K3lLH0r6xS5cbaOmhnEfdVL7xpnkeqY7Zqj9Euoft 2ED/w2eiEXVSA== Received: from disco-boy.misterjones.org ([217.182.43.188] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1sEmCA-000r52-Af; Wed, 05 Jun 2024 09:40:34 +0100 MIME-Version: 1.0 Date: Wed, 05 Jun 2024 09:40:34 +0100 From: Marc Zyngier To: Lorenzo Pieralisi Cc: linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Robin Murphy , Mark Rutland , linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, Fang Xiang , Robert Moore Subject: Re: [PATCH v5 1/1] irqchip/gic-v3: Enable non-coherent redistributors/ITSes ACPI probing In-Reply-To: References: <20240123110332.112797-1-lpieralisi@kernel.org> <20240123110332.112797-2-lpieralisi@kernel.org> User-Agent: Roundcube Webmail/1.4.15 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 217.182.43.188 X-SA-Exim-Rcpt-To: lpieralisi@kernel.org, linux-kernel@vger.kernel.org, rafael@kernel.org, robin.murphy@arm.com, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, acpica-devel@lists.linux.dev, fangxiang3@xiaomi.com, robert.moore@intel.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240605_014039_375154_60B60CEB X-CRM114-Status: GOOD ( 25.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024-06-05 08:14, Lorenzo Pieralisi wrote: > On Mon, Apr 22, 2024 at 10:42:19AM +0200, Lorenzo Pieralisi wrote: >> On Tue, Jan 23, 2024 at 12:03:32PM +0100, Lorenzo Pieralisi wrote: >> > The GIC architecture specification defines a set of registers for >> > redistributors and ITSes that control the sharebility and cacheability >> > attributes of redistributors/ITSes initiator ports on the interconnect >> > (GICR_[V]PROPBASER, GICR_[V]PENDBASER, GITS_BASER). >> > >> > Architecturally the GIC provides a means to drive shareability and >> > cacheability attributes signals but it is not mandatory for designs to >> > wire up the corresponding interconnect signals that control the >> > cacheability/shareability of transactions. >> > >> > Redistributors and ITSes interconnect ports can be connected to >> > non-coherent interconnects that are not able to manage the >> > shareability/cacheability attributes; this implicitly makes the >> > redistributors and ITSes non-coherent observers. >> > >> > To enable non-coherent GIC designs on ACPI based systems, parse the MADT >> > GICC/GICR/ITS subtables non-coherent flags to determine whether the >> > respective components are non-coherent observers and force the >> > shareability attributes to be programmed into the redistributors and >> > ITSes registers. >> > >> > An ACPI global function (acpi_get_madt_revision()) is added to retrieve >> > the MADT revision, in that it is essential to check the MADT revision >> > before checking for flags that were added with MADT revision 7 so that >> > if the kernel is booted with an ACPI MADT table with revision < 7 it >> > skips parsing the newly added flags (that should be zeroed reserved >> > values for MADT versions < 7 but they could turn out to be buggy and >> > should be ignored). >> > >> > Signed-off-by: Lorenzo Pieralisi >> > Cc: Robin Murphy >> > Cc: Mark Rutland >> > Cc: "Rafael J. Wysocki" >> > Cc: Marc Zyngier >> > --- >> > drivers/acpi/processor_core.c | 15 +++++++++++++++ >> > drivers/irqchip/irq-gic-v3-its.c | 4 ++++ >> > drivers/irqchip/irq-gic-v3.c | 9 +++++++++ >> > include/linux/acpi.h | 3 +++ >> > 4 files changed, 31 insertions(+) >> >> Hi Marc, Rafael, >> >> I would kindly ask you please what to do with this patch, it still >> applies to v6.9-rc5 - I can resend it if needed, ACPICA changes >> are already merged as-per the cover letter. > > Hi Marc, Rafael, > > I would kindly ask please what to do with this patch, rebased to > v6.10-rc1, > I can resend it if that's preferred, please let me know. Please resend it with my: Acked-by: Marc Zyngier and Cc'ing Thomas Gleixner. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel