From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B60B3C433FE for ; Wed, 9 Dec 2020 13:26:34 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E75023101 for ; Wed, 9 Dec 2020 13:26:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E75023101 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=arpvKEhJMkejJpng2mmaS1ivlHGYhvm5CBH0XeUhLYY=; b=Omh6JpIehwgRh3RqJLPcUgaQ/ KpRHX8VpNIbktCREtTFZU/7FNhsV+jhTnOrDRkB3XqZ3ug8HjrRU6bg8+2FNCyzH4b5Kr90jgmUfC +m2AfqcomDsMRZ5pM0jX9XsvrR5t+SB3TWL0vTPOFQBbI0PAK+dchZVRAcnX5/3bFkQJ2rmLM/cDU L7qOEBgYgvfu4rvwdSA/NjDUPM4YM2rWVuA9jO55F5kxA/QhUdf3y8RyycsasiJKbJFGq3XAKBMTs nsHTvXiLQKLnieWD/SCPhiXQgn5xAJKfK60WVRrP+dAbLJLx7BY+spj+tIqgPx6dVviwsKp6I6Tqc bzE5b8IBg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmzTB-0005o7-Ah; Wed, 09 Dec 2020 13:25:25 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmzT8-0005nl-J4 for linux-arm-kernel@lists.infradead.org; Wed, 09 Dec 2020 13:25:23 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0167123101; Wed, 9 Dec 2020 13:25:21 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1kmzT4-00HOUv-VX; Wed, 09 Dec 2020 13:25:19 +0000 MIME-Version: 1.0 Date: Wed, 09 Dec 2020 13:25:18 +0000 From: Marc Zyngier To: Catalin Marinas Subject: Re: [PATCH v5 0/2] MTE support for KVM guest In-Reply-To: <20201209124443.GB13566@gaia> References: <46fd98a2-ee39-0086-9159-b38c406935ab@arm.com> <0d0eb6da6a11f76d10e532c157181985@kernel.org> <20201207163405.GD1526@gaia> <874kkx5thq.wl-maz@kernel.org> <20201208172143.GB13960@gaia> <7ff14490e253878d0735633b792e1ea9@kernel.org> <20201209124443.GB13566@gaia> User-Agent: Roundcube Webmail/1.4.9 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: catalin.marinas@arm.com, steven.price@arm.com, peter.maydell@linaro.org, haibo.xu@linaro.org, linux-kernel@vger.kernel.org, quintela@redhat.com, richard.henderson@linaro.org, qemu-devel@nongnu.org, dgilbert@redhat.com, tglx@linutronix.de, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Dave.Martin@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201209_082522_757505_211E32EE X-CRM114-Status: GOOD ( 21.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Juan Quintela , QEMU Developers , Dave Martin , Richard Henderson , lkml - Kernel Mailing List , Steven Price , arm-mail-list , Haibo Xu , Thomas Gleixner , Will Deacon , kvmarm , "Dr. David Alan Gilbert" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-12-09 12:44, Catalin Marinas wrote: > On Tue, Dec 08, 2020 at 06:21:12PM +0000, Marc Zyngier wrote: >> On 2020-12-08 17:21, Catalin Marinas wrote: >> > On Mon, Dec 07, 2020 at 07:03:13PM +0000, Marc Zyngier wrote: >> > > I wonder whether we will have to have something kernel side to >> > > dump/reload tags in a way that matches the patterns used by live >> > > migration. >> > >> > We have something related - ptrace dumps/resores the tags. Can the same >> > concept be expanded to a KVM ioctl? >> >> Yes, although I wonder whether we should integrate this deeply into >> the dirty-log mechanism: it would be really interesting to dump the >> tags at the point where the page is flagged as clean from a dirty-log >> point of view. As the page is dirtied, discard the saved tags. > > From the VMM perspective, the tags can be treated just like additional > (meta)data in a page. We'd only need the tags when copying over. It can > race with the VM dirtying the page (writing tags would dirty it) but I > don't think the current migration code cares about this. If dirtied, it > copies it again. > > The only downside I see is an extra syscall per page both on the origin > VMM and the destination one to dump/restore the tags. Is this a > performance issue? I'm not sure. Migrating VMs already has a massive overhead, so an extra syscall per page isn't terrifying. But that's the point where I admit not knowing enough about what the VMM expects, nor whether that matches what happens on other architectures that deal with per-page metadata. Would this syscall operate on the guest address space? Or on the VMM's own mapping? M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel