From: Luis de Arquer <ldearquer@gmail.com>
To: linux-spi@vger.kernel.org, linux-rockchip@lists.infradead.org
Cc: broonie@kernel.org, heiko@sntech.de,
linux-arm-kernel@lists.infradead.org,
Robin Murphy <robin.murphy@arm.com>,
luis.dearquer@inertim.com
Subject: Re: [PATCH 3/3] spi: spi-rockchip: Fix unused chip select line when using gpio cs
Date: Sat, 27 Jan 2024 10:48:00 +0100 [thread overview]
Message-ID: <ef65935fac5c09c9eccb89604fc8af504c886f5d.camel@gmail.com> (raw)
In-Reply-To: <fc9519de1d278c3f0f0ba8a9640b0499ae2bedca.camel@gmail.com>
On Fri, 2024-01-26 at 20:47 +0100, Luis de Arquer wrote:
> This change allows the DT to use native c1 for a device while leaving
> native cs0 reserved for allowing gpio cs operation
>
Actually, I think this comment is the other way around -reserve cs1 and use cs0 for device.
Before, it was using cs0 for gpio operation always.
>
> - ROCKCHIP_SPI_SET_BITS(rs->regs + ROCKCHIP_SPI_SER, 1);
> + ROCKCHIP_SPI_SET_BITS(rs->regs + ROCKCHIP_SPI_SER, ctlr->unused_native_cs);
s/ctlr->unused_native_cs/BIT(ctlr->unused_native_cs)/
I mixed up cs numbers and bitmask, sorry.
I'll fix for v2
Luis
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2024-01-27 9:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 19:47 [PATCH 3/3] spi: spi-rockchip: Fix unused chip select line when using gpio cs Luis de Arquer
2024-01-27 9:48 ` Luis de Arquer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef65935fac5c09c9eccb89604fc8af504c886f5d.camel@gmail.com \
--to=ldearquer@gmail.com \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=luis.dearquer@inertim.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).