From: Marek Vasut <marex@denx.de>
To: Lucas Stach <l.stach@pengutronix.de>, Liu Ying <victor.liu@nxp.com>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
patchwork-lst@pengutronix.de
Subject: Re: [PATCH 2/5] drm: lcdif: move controller enable into atomic_flush
Date: Wed, 20 Sep 2023 19:31:53 +0200 [thread overview]
Message-ID: <ef70eae2-97df-b244-a20e-3d7ec543365e@denx.de> (raw)
In-Reply-To: <20230920103126.2759601-3-l.stach@pengutronix.de>
On 9/20/23 12:31, Lucas Stach wrote:
> Allow drm_atomic_helper_commit_tail_rpm to setup all the plane
> state before the scanout is started.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> drivers/gpu/drm/mxsfb/lcdif_kms.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mxsfb/lcdif_kms.c b/drivers/gpu/drm/mxsfb/lcdif_kms.c
> index f5bfe8b52920..4acf6914a8d1 100644
> --- a/drivers/gpu/drm/mxsfb/lcdif_kms.c
> +++ b/drivers/gpu/drm/mxsfb/lcdif_kms.c
> @@ -505,6 +505,8 @@ static int lcdif_crtc_atomic_check(struct drm_crtc *crtc,
> static void lcdif_crtc_atomic_flush(struct drm_crtc *crtc,
> struct drm_atomic_state *state)
> {
> + struct drm_crtc_state *crtc_state = drm_atomic_get_new_crtc_state(state,
> + crtc);
> struct lcdif_drm_private *lcdif = to_lcdif_drm_private(crtc->dev);
> struct drm_pending_vblank_event *event;
> u32 reg;
> @@ -513,6 +515,9 @@ static void lcdif_crtc_atomic_flush(struct drm_crtc *crtc,
> reg |= CTRLDESCL0_5_SHADOW_LOAD_EN;
> writel(reg, lcdif->base + LCDC_V8_CTRLDESCL0_5);
>
> + if (drm_atomic_crtc_needs_modeset(crtc_state))
> + lcdif_enable_controller(lcdif);
> +
> event = crtc->state->event;
> crtc->state->event = NULL;
>
> @@ -552,7 +557,6 @@ static void lcdif_crtc_atomic_enable(struct drm_crtc *crtc,
> writel(CTRLDESCL_HIGH0_4_ADDR_HIGH(upper_32_bits(paddr)),
> lcdif->base + LCDC_V8_CTRLDESCL_HIGH0_4);
> }
> - lcdif_enable_controller(lcdif);
>
> drm_crtc_vblank_on(crtc);
> }
Reviewed-by: Marek Vasut <marex@denx.de>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-20 17:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-20 10:31 [PATCH 0/5] imx-lcdif modeset changes Lucas Stach
2023-09-20 10:31 ` [PATCH 1/5] drm: lcdif: improve burst size configuration comment Lucas Stach
2023-09-20 10:59 ` Marco Felsch
2023-09-20 17:30 ` Marek Vasut
2023-09-20 10:31 ` [PATCH 2/5] drm: lcdif: move controller enable into atomic_flush Lucas Stach
2023-09-20 17:31 ` Marek Vasut [this message]
2023-09-21 7:13 ` Ying Liu
2023-09-21 7:55 ` Lucas Stach
2023-09-21 8:18 ` Ying Liu
2023-09-21 8:56 ` Lucas Stach
2023-09-21 9:14 ` Ying Liu
2023-09-20 10:31 ` [PATCH 3/5] drm: lcdif: remove superfluous setup of framebuffer DMA address Lucas Stach
2023-09-20 17:32 ` Marek Vasut
2023-09-20 10:31 ` [PATCH 4/5] drm: lcdif: move pitch setup to plane atomic update Lucas Stach
2023-09-20 17:32 ` Marek Vasut
2023-09-20 10:31 ` [PATCH 5/5] drm: lcdif: force modeset when FB format changes Lucas Stach
2023-09-20 17:33 ` Marek Vasut
2023-09-21 7:34 ` Ying Liu
2023-09-21 7:59 ` Lucas Stach
2023-09-21 8:30 ` Ying Liu
2023-09-21 6:55 ` [PATCH 0/5] imx-lcdif modeset changes Ying Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef70eae2-97df-b244-a20e-3d7ec543365e@denx.de \
--to=marex@denx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=patchwork-lst@pengutronix.de \
--cc=victor.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).