From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Claudiu Beznea <claudiu.beznea@microchip.com>,
perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com,
broonie@kernel.org, james.schulman@cirrus.com,
david.rhodes@cirrus.com, tanureal@opensource.cirrus.com,
rf@opensource.cirrus.com, oder_chiou@realtek.com,
shengjiu.wang@gmail.com, Xiubo.Lee@gmail.com, festevam@gmail.com,
nicoleotsuka@gmail.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de, linux-imx@nxp.com,
cezary.rojewski@intel.com, pierre-louis.bossart@linux.intel.com,
peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com,
ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com,
matthias.bgg@gmail.com, bgoswami@quicinc.com, vkoul@kernel.org,
daniel.baluta@nxp.com, thierry.reding@gmail.com,
jonathanh@nvidia.com, jarkko.nikula@bitmer.com
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
sound-open-firmware@alsa-project.org,
linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] ASoC: do not include pm_runtime.h if not used
Date: Fri, 10 Mar 2023 07:29:04 +0000 [thread overview]
Message-ID: <ef92dcac-cadd-b85e-d6ea-512684266e81@linaro.org> (raw)
In-Reply-To: <20230307103022.1007420-1-claudiu.beznea@microchip.com>
On 07/03/2023 10:30, Claudiu Beznea wrote:
> diff --git a/sound/soc/qcom/lpass-sc7180.c b/sound/soc/qcom/lpass-sc7180.c
> index 41db6617e2ed..dc892fac4baa 100644
> --- a/sound/soc/qcom/lpass-sc7180.c
> +++ b/sound/soc/qcom/lpass-sc7180.c
> @@ -12,7 +12,6 @@
> #include <linux/module.h>
> #include <linux/of.h>
> #include <linux/platform_device.h>
> -#include <linux/pm_runtime.h>
> #include <dt-bindings/sound/sc7180-lpass.h>
> #include <sound/pcm.h>
> #include <sound/soc.h>
> diff --git a/sound/soc/qcom/lpass-sc7280.c b/sound/soc/qcom/lpass-sc7280.c
> index d43f480cbae3..ee4a4b553e74 100644
> --- a/sound/soc/qcom/lpass-sc7280.c
> +++ b/sound/soc/qcom/lpass-sc7280.c
> @@ -8,7 +8,6 @@
> #include <linux/module.h>
> #include <sound/pcm.h>
> #include <sound/soc.h>
> -#include <linux/pm_runtime.h>
>
> #include <dt-bindings/sound/sc7180-lpass.h>
Has these been compile tested? the reason I ask is because both these
drivers need SET_SYSTEM_SLEEP_PM_OPS macro from pm.h which was getting
included from pm_runtime.h, now that is removed, am guessing it will
cause a compile errors.
can you atleast replace this with pm.h instead of removing it totally?
--srini
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-10 7:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 10:30 [PATCH] ASoC: do not include pm_runtime.h if not used Claudiu Beznea
2023-03-07 11:30 ` Charles Keepax
2023-03-10 7:06 ` Jarkko Nikula
2023-03-10 7:29 ` Srinivas Kandagatla [this message]
2023-03-10 8:12 ` Claudiu.Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef92dcac-cadd-b85e-d6ea-512684266e81@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=claudiu.beznea@microchip.com \
--cc=daniel.baluta@nxp.com \
--cc=david.rhodes@cirrus.com \
--cc=festevam@gmail.com \
--cc=james.schulman@cirrus.com \
--cc=jarkko.nikula@bitmer.com \
--cc=jonathanh@nvidia.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matthias.bgg@gmail.com \
--cc=nicoleotsuka@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=rf@opensource.cirrus.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tanureal@opensource.cirrus.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).