From: "Rafał Miłecki" <zajec5@gmail.com>
To: William Zhang <william.zhang@broadcom.com>,
Linux ARM List <linux-arm-kernel@lists.infradead.org>
Cc: Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
joel.peshkin@broadcom.com, dan.beygelman@broadcom.com,
kursad.oney@broadcom.com, f.fainelli@gmail.com,
anand.gore@broadcom.com, Ray Jui <rjui@broadcom.com>,
Russell King <linux@armlinux.org.uk>,
Scott Branden <sbranden@broadcom.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/8] arm: bcmbca: Move BCM63138 ARCH_BCM_63XX to ARCH_BCMBCA
Date: Wed, 13 Jul 2022 17:35:35 +0200 [thread overview]
Message-ID: <f00dbaaf-bf92-11db-8a2b-ef78e0a91347@gmail.com> (raw)
In-Reply-To: <20220707070037.261532-6-william.zhang@broadcom.com>
On 7.07.2022 09:00, William Zhang wrote:
> Remove ARCH_BCM_63XX Kconfig for BCM63138 and merge its selections to
> ARCH_BCMBCA. Delete bcm63xx.c as it is no longer needed.
>
> Signed-off-by: William Zhang <william.zhang@broadcom.com>
> ---
>
> (no changes since v1)
>
> arch/arm/mach-bcm/Kconfig | 26 +++++++++-----------------
> arch/arm/mach-bcm/Makefile | 7 +------
> arch/arm/mach-bcm/bcm63xx.c | 17 -----------------
> 3 files changed, 10 insertions(+), 40 deletions(-)
> delete mode 100644 arch/arm/mach-bcm/bcm63xx.c
>
> diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
> index f73a056bf560..25aa4ef4db07 100644
> --- a/arch/arm/mach-bcm/Kconfig
> +++ b/arch/arm/mach-bcm/Kconfig
> @@ -182,23 +182,6 @@ config ARCH_BCM_53573
> The base chip is BCM53573 and there are some packaging modifications
> like BCM47189 and BCM47452.
>
> -config ARCH_BCM_63XX
> - bool "Broadcom BCM63xx DSL SoC"
> - depends on ARCH_MULTI_V7
> - select ARCH_HAS_RESET_CONTROLLER
> - select ARM_ERRATA_754322
> - select ARM_ERRATA_764369 if SMP
> - select ARM_GIC
> - select ARM_GLOBAL_TIMER
> - select CACHE_L2X0
> - select HAVE_ARM_ARCH_TIMER
> - select HAVE_ARM_TWD if SMP
> - select HAVE_ARM_SCU if SMP
> - help
> - This enables support for systems based on Broadcom DSL SoCs.
> - It currently supports the 'BCM63XX' ARM-based family, which includes
> - the BCM63138 variant.
Oh, wait a second. This is actually going to totally break builds for
people because there are a lot of Kconfig-s that depend on it!
I don't believe it can't be handled this way.
You need to first introduce a replacement / parent symbol.
Then (in another release if needed) update all Kconfig-s.
Then eventually you can get rid of ARCH_BCM_63XX.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-13 15:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 7:00 [PATCH v2 0/8] arm: bcmbca: Move BCM63138 SoC support under ARCH_BCMBCA William Zhang
2022-07-07 7:00 ` [PATCH v2 1/8] dt-bindings: arm: add BCM63138 SoC William Zhang
2022-07-08 20:58 ` Florian Fainelli
2022-07-07 7:00 ` [PATCH v2 2/8] ARM: dts: Move BCM963138DVT board dts to ARCH_BCMBCA William Zhang
2022-07-08 20:59 ` Florian Fainelli
2022-07-13 15:26 ` Rafał Miłecki
2022-07-13 16:35 ` Florian Fainelli
2022-07-07 7:00 ` [PATCH v2 3/8] ARM: dts: update dts files for bcmbca SoC BCM63138 William Zhang
2022-07-08 20:59 ` Florian Fainelli
2022-07-07 7:00 ` [PATCH v2 4/8] ARM: dts: Add BCM63138 generic board dts William Zhang
2022-07-08 21:00 ` Florian Fainelli
2022-07-07 7:00 ` [PATCH v2 5/8] arm: bcmbca: Move BCM63138 ARCH_BCM_63XX to ARCH_BCMBCA William Zhang
2022-07-13 15:31 ` Rafał Miłecki
2022-07-13 16:36 ` Florian Fainelli
2022-07-13 15:35 ` Rafał Miłecki [this message]
2022-07-13 16:24 ` Florian Fainelli
2022-07-07 7:00 ` [PATCH v2 6/8] arm: bcmbca: Add BCMBCA sub platforms William Zhang
2022-07-07 7:00 ` [PATCH v2 7/8] MAINTAINERS: Move BCM63138 to bcmbca arch entry William Zhang
2022-07-08 21:06 ` Florian Fainelli
2022-07-07 7:00 ` [PATCH v2 8/8] ARM: multi_v7_defconfig: Update configs for BCM63138 William Zhang
2022-07-08 21:07 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f00dbaaf-bf92-11db-8a2b-ef78e0a91347@gmail.com \
--to=zajec5@gmail.com \
--cc=anand.gore@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.beygelman@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=joel.peshkin@broadcom.com \
--cc=kursad.oney@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).