From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6658FC54798 for ; Tue, 5 Mar 2024 08:50:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DrBISSeUq0aW4JGBsnfedQQ271LvxOimNZiNV88o4ig=; b=ufGnVDl7Iu1EDF tc6+Zn8cJ+w/yrDpH2TBtgwrrstHJmesOTM2VkxDb+0BOTjUNe0z75/ghFiazdCQevlSyJU5Z+LXr w8L7f2NVLHOXcuPzmextqZSguXzqelZmYcHP+ClKlAr9IGH7utapB0/mLdGc6DGoEcYDSagpOouDx xVklDO/FcKqvhRDTI+zuUv9jz/gygmWoL+TaxWfbnNOGhPAInI9LhI2V/ialne/nn6bYmdc9E2bUQ yR1/5ID9RIik6IRYXGof2XWyzZJiKDrw/aupl61DQ0jnCZ7MxnKxyJXtfvCTLBo9Iy1OXXWwFPs4x FHYaFJnduSsDFmufPNmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhQVT-0000000Cg78-2oSH; Tue, 05 Mar 2024 08:50:39 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rhQVQ-0000000Cg5o-0ISD for linux-arm-kernel@lists.infradead.org; Tue, 05 Mar 2024 08:50:38 +0000 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-563d56ee65cso8124641a12.2 for ; Tue, 05 Mar 2024 00:50:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709628634; x=1710233434; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=jT7ZsmNph1HICQhGYk/X5PZRUWWUGk3/PHQvVwvJTOo=; b=C7AKH6JtDqrpTOMBMs0YbvJy1s80lFRzgOUCdVcp75c4uy4EPR1pqVvZfFl2+bDx5r phlw9lkRam8UZjZ6YT4JHYki+sFda9ingCKuHm63u7ZvzuRU7l/H4QkIfK9fMLvLRxxH lzBxz1SVbe8iPuiEfUHD5lhzwSsK+d1aYLU2mGZpjTnqP8WrM9q2GAJZxaQcx3jyKy+Y UqPNwvQCOcY/Xo/piKSL6Cc9xmX1f5yVkAK53m3mmX9j4OZujGzEwX8GgBlEYtR5F25/ ekvtmxpOrIgarqud7px5R0Q0Iy1OnYrAxcEs7R7h/+3n4Q2Q7CKVSVLnLJHc/zQguHkp rfgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709628634; x=1710233434; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jT7ZsmNph1HICQhGYk/X5PZRUWWUGk3/PHQvVwvJTOo=; b=DbF/8t6qiGgjBYZG6IYG421DIvo+JlPOag0QI7eOfJjUCHGy1IwcROA5ruPHnqyV9q 6GPUbF/4yxpV9HM2Ia77ZBKVscJzysW3Yq3oc771YflezajewGVlHjb2sH0wMsb2/igd QoByRIgaKvvpOafENUpouOlcqIhmE0G1gsxS+cIOvgTPVPlJMhI9yGvERc91dfG4luJB DEnY21ggmZngAflHVcRx3P3/DO2f71krFA1en9vOz0vae+sSyajEpBiAdBV3qFs7rbY5 8yKobgaB3CNgcbuho5NlD1WhuSY53g9F7DoWvJrknLySXCuYOXF9R16BSM28jNZeqY82 9d2Q== X-Forwarded-Encrypted: i=1; AJvYcCVxJCRse1GWxEzcwfueU9YRypKhWx4lRL69MSUXfT2VWCad1OyaGcOIz1Fy/+Keh0GlX5Truq133obYO9AcqoHDpYj4oDMvQDCr6TKFae1For/EoYQ= X-Gm-Message-State: AOJu0Yyspwbtyr7i5IGpev907NrT6zXCU2wZTnVdN9XlUTL8d2Mi397W vx8lAgsHy1t7VBQzRh7NOdU5eoFZV4tbE3o8l2qSuJnszkaCDh2BVYtauGkWp44= X-Google-Smtp-Source: AGHT+IHJS+2LhiDD7zxJqHM589abVoaxutSaB3e9mIWp3cLj6gDlecOCLPFEcxg3I6gVnMuHzHEJSQ== X-Received: by 2002:a17:906:c06:b0:a44:1978:c73f with SMTP id s6-20020a1709060c0600b00a441978c73fmr7660917ejf.61.1709628633846; Tue, 05 Mar 2024 00:50:33 -0800 (PST) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id ef5-20020a17090697c500b00a449cb924dbsm4457506ejb.124.2024.03.05.00.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 00:50:33 -0800 (PST) Date: Tue, 5 Mar 2024 11:50:29 +0300 From: Dan Carpenter To: Shradha Todi Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, mturquette@baylibre.com, sboyd@kernel.org, jingoohan1@gmail.com, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, linux@armlinux.org.uk, m.szyprowski@samsung.com, manivannan.sadhasivam@linaro.org, pankaj.dubey@samsung.com, gost.dev@samsung.com Subject: Re: [PATCH v6 1/2] clk: Provide managed helper to get and enable bulk clocks Message-ID: References: <20240220084046.23786-1-shradha.t@samsung.com> <20240220084046.23786-2-shradha.t@samsung.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240220084046.23786-2-shradha.t@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240305_005036_228895_E5556B27 X-CRM114-Status: GOOD ( 13.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 20, 2024 at 02:10:45PM +0530, Shradha Todi wrote: > +int __must_check devm_clk_bulk_get_all_enable(struct device *dev, > + struct clk_bulk_data **clks) > +{ > + struct clk_bulk_devres *devres; > + int ret; > + > + devres = devres_alloc(devm_clk_bulk_release_all_enable, > + sizeof(*devres), GFP_KERNEL); > + if (!devres) > + return -ENOMEM; > + > + ret = clk_bulk_get_all(dev, &devres->clks); > + if (ret > 0) { I feel like this should be >= instead of >. There aren't any callers of this function yet so we can't see what's in *clks at the start but it's easy to imagine a situation where it's bad data. > + *clks = devres->clks; > + devres->num_clks = ret; > + } else { > + devres_free(devres); > + return ret; When clk_bulk_get_all() returns zero then we return success here. regards, dan carpenter > + } > + > + ret = clk_bulk_prepare_enable(devres->num_clks, *clks); > + if (!ret) { > + devres_add(dev, devres); > + } else { > + clk_bulk_put_all(devres->num_clks, devres->clks); > + devres_free(devres); > + } > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(devm_clk_bulk_get_all_enable); > + _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel