Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Frank Li <Frank.Li@nxp.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] ARM: dts: imx6qdl-sabrelite: add mdio phy address 0
Date: Tue, 12 May 2026 00:15:08 +0200	[thread overview]
Message-ID: <f04fadf2-8d73-435b-b713-9d07e48e80ae@lunn.ch> (raw)
In-Reply-To: <20260511-b4-imx25_dts_simple_warning-v1-1-01b855a5ce25@nxp.com>

On Mon, May 11, 2026 at 05:04:56PM -0400, Frank Li wrote:
> According to IEEE 802.3 Clause 22.2.4.5.5 PHYAD (PHY Address), A PHY that
> is connected to the station management entity via the mechanical interface
> defined in 22.6 shall always respond to transactions addressed to PHY
> Address zero <00000>.

Did you read 22.6? I've not seen a mechanical interface as defined in
22.6 for at least 20 years, maybe 30 years.

That cause does not apply in this context.

> -		ethphy: ethernet-phy {
> +		ethphy: ethernet-phy@0 {
>  			compatible = "ethernet-phy-ieee802.3-c22";
> +			reg = <0>;

This could very well break this board. Without a reg value, the core
will find the first PHY on the bus, at whatever address it is at. If
you hard code 0, the PHY must be at 0, otherwise it will not be found.

	Andrew


  reply	other threads:[~2026-05-11 22:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 21:04 [PATCH 0/4] ARM: dts: DTB_CHECK warning cleanup Frank Li
2026-05-11 21:04 ` [PATCH 1/4] ARM: dts: imx6qdl-sabrelite: add mdio phy address 0 Frank Li
2026-05-11 22:15   ` Andrew Lunn [this message]
2026-05-12  7:52     ` Francesco Dolcini
2026-05-12 12:23     ` Fabio Estevam
2026-05-12 13:43       ` Fabio Estevam
2026-05-12 14:26     ` Frank Li
2026-05-12  7:51   ` Francesco Dolcini
2026-05-11 21:04 ` [PATCH 2/4] ARM: dts: imx: add ti,deskew = <0> for ti,tfp410 Frank Li
2026-05-11 21:04 ` [PATCH 3/4] ARM: dts: imx53-qsb: add dvdd and avdd supply for panel sii,43wvf1g Frank Li
2026-05-11 21:04 ` [PATCH 4/4] ARM: dts: imx53-ppd: add '#phy-cells' for usb-nop-xceiv Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f04fadf2-8d73-435b-b713-9d07e48e80ae@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox