From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4253C4332F for ; Sun, 29 Oct 2023 22:41:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=93kbmwS3wMzfusDZuqlba2+G+GA+i5lI68924ZAmNNc=; b=qSACE2JO9FfcBH rCT89oXmgBilxr8Eko/enjK+03Ie624FgAcgQ6eYGAy7wKZq27kXpm5e3q2jQ9xxeWUifkPwkxDJS IRq68VWmZkI6hOEemAxDapoYgZG0NUZwqwGsZ2ZYoZi/Giz+IEqXtj+HPUtuSPITSxg6VqskwSkur 2Mf/MdIKn8+1kJO4E8ClKisykOX4zwquODUI+ePC3dFAFuXuoZDVtfbHRibkxSaU6VR4rjiiv97YO 3YlVz4+blmPVlriXdEyow2W7lwUF8Hu4suVCvNW/9ltmWU0fWiFwIRWtLVA+3Wh/kf2lAxq4mmYqF WF/21HciT5OneI1oPMnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qxETL-002CSO-25; Sun, 29 Oct 2023 22:41:31 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qxETI-002CRt-2G; Sun, 29 Oct 2023 22:41:29 +0000 Received: from [192.168.1.90] (unknown [188.24.143.101]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madras.collabora.co.uk (Postfix) with ESMTPSA id E600166072BB; Sun, 29 Oct 2023 22:41:25 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1698619287; bh=0moYwqGPpKpcCgWCZCbmjb3SQL9UUK8AXxSzTD9M6EM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=GAp2S5LeolDNT0oMnIU1XOERBBbWg8wPe66a2v7uBCjT0XEL2uOR/xK2jM76GBNkZ g5e8MN3Pt/i8oENbgyJip/7sswIfxUCXn6Wf8pQPBuWG4ooO+Xwwg7SxnSXhjTR8Bj 7Gehm8n2sgo2owH/pQiU4GNiOwJ0NV02FY6al52pwfxMy2bvUEJLGYgGmmyh6YsYmn 6S7/LpukLMtkMX2I25Aq/nj4WJiDUYBxGEX9+rYfeu6ED1sW483Hfh/3UvoGp8rMu8 UagKsbwJ2EUikHgocGXGOchFcKp/R5ps4nE8Lm2T+ymGrnlu0EH04pHnvNsCiq15Tz v/DIB0SxCyOKg== Message-ID: Date: Mon, 30 Oct 2023 00:41:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 11/12] riscv: dts: starfive: visionfive-v1: Enable gmac and setup phy Content-Language: en-US To: Andrew Lunn Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing , Samin Guo , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Giuseppe Cavallaro , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@collabora.com References: <20231029042712.520010-1-cristian.ciocaltea@collabora.com> <20231029042712.520010-12-cristian.ciocaltea@collabora.com> From: Cristian Ciocaltea In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231029_154128_886185_85678CBC X-CRM114-Status: GOOD ( 10.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/29/23 20:45, Andrew Lunn wrote: > On Sun, Oct 29, 2023 at 06:27:11AM +0200, Cristian Ciocaltea wrote: >> The StarFive VisionFive V1 SBC has a Motorcomm YT8521 PHY supporting >> RGMII-ID, but requires manual adjustment of the RX internal delay to >> work properly. >> >> The default RX delay provided by the driver is 1.95 ns, which proves to >> be too high. Applying a 50% reduction seems to mitigate the issue. > > I'm not so happy this cannot be explained. You are potentially heading > into horrible backwards compatibility problems with old DT blobs and > new kernels once this is explained and fixed. It seems the visionfive-v2 board also required setting some delays, but unfortunately no details were provided: 0104340a67b1 ("riscv: dts: starfive: visionfive 2: Add configuration of mac and phy") Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel