From: Tudor Ambarus <tudor.ambarus@linaro.org>
To: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Sam Protsenko <semen.protsenko@linaro.org>,
Peter Griffin <peter.griffin@linaro.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] dt-bindings: soc: samsung: usi: replace USI_V2 in constants with USI_MODE
Date: Mon, 6 Jan 2025 07:36:36 +0000 [thread overview]
Message-ID: <f0702bdb-846e-4817-a76c-5ce17dea38c8@linaro.org> (raw)
In-Reply-To: <20250105160346.418829-2-ivo.ivanov.ivanov1@gmail.com>
Hiya,
On 1/5/25 4:03 PM, Ivaylo Ivanov wrote:
> +#define USI_MODE_NONE 0
> +#define USI_MODE_UART 1
> +#define USI_MODE_SPI 2
> +#define USI_MODE_I2C 3
USI_CONFIG register refers to the protocol selection with USI_I2C,
USI_SPI, USI_UART. How about getting rid of the MODE from the name?
Cheers,
ta
next prev parent reply other threads:[~2025-01-06 7:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-05 16:03 [PATCH v3 0/4] soc: samsung: usi: implement support for USIv1 Ivaylo Ivanov
2025-01-05 16:03 ` [PATCH v3 1/4] dt-bindings: soc: samsung: usi: replace USI_V2 in constants with USI_MODE Ivaylo Ivanov
2025-01-06 6:24 ` Krzysztof Kozlowski
2025-01-06 7:09 ` Ivaylo Ivanov
2025-01-06 7:28 ` Krzysztof Kozlowski
2025-01-06 7:36 ` Tudor Ambarus [this message]
2025-01-06 7:41 ` Ivaylo Ivanov
2025-01-06 8:50 ` Krzysztof Kozlowski
2025-01-06 9:10 ` Tudor Ambarus
2025-01-05 16:03 ` [PATCH v3 2/4] dt-bindings: soc: samsung: usi: add USIv1 and samsung,exynos8895-usi Ivaylo Ivanov
2025-01-06 6:31 ` Krzysztof Kozlowski
2025-01-06 7:11 ` Ivaylo Ivanov
2025-01-05 16:03 ` [PATCH v3 3/4] soc: samsung: usi: implement support for USIv1 and exynos8895 Ivaylo Ivanov
2025-01-06 7:02 ` Krzysztof Kozlowski
2025-01-05 16:03 ` [PATCH v3 4/4] arm64: dts: exynos: update all samsung,mode constants Ivaylo Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0702bdb-846e-4817-a76c-5ce17dea38c8@linaro.org \
--to=tudor.ambarus@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).