From: Stephen Boyd <sboyd@kernel.org>
To: Hao Ge <gehao@kylinos.cn>,
matthias.bgg@gmail.com, mturquette@baylibre.com
Cc: gehao@kylinos.cn, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mediatek/clk-mt8173-apmixedsys: convert to devm_platform_ioremap_resource
Date: Thu, 13 Apr 2023 11:40:22 -0700 [thread overview]
Message-ID: <f09425fde83f4b21ee301ef8810c4c29.sboyd@kernel.org> (raw)
In-Reply-To: <20230413090128.60119-1-gehao@kylinos.cn>
Quoting Hao Ge (2023-04-13 02:01:28)
> diff --git a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c
> index a56c5845d07a..fe386bf8225d 100644
> --- a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c
> +++ b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c
> @@ -90,7 +90,7 @@ static int clk_mt8173_apmixed_probe(struct platform_device *pdev)
> struct clk_hw *hw;
> int r;
>
> - base = of_iomap(node, 0);
> + base = devm_platform_ioremap_resource(pdev, 0);
> if (!base)
This needs to be updated.
> return PTR_ERR(base);
And PTR_ERR(NULL) is 0, which is wrong.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-13 18:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 9:01 [PATCH] mediatek/clk-mt8173-apmixedsys: convert to devm_platform_ioremap_resource Hao Ge
2023-04-13 18:40 ` Stephen Boyd [this message]
2023-04-20 8:53 ` Hao Ge
2023-04-20 9:11 ` [PATCH V2] " Hao Ge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f09425fde83f4b21ee301ef8810c4c29.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=gehao@kylinos.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).