From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED0EEC77B61 for ; Thu, 13 Apr 2023 18:41:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O3nEhZ9/66mhJtvYtlX7x44G0xZgcToNK9Wj/xk997g=; b=JRL3iKcB0plhvE A/54bj1FgcVXjOuGHj8ENLeMCai6oT49Lt6YcuzJViIwvef5vU6paETMT4AlM0x3etSPldcMrq5gj 2wQkumrG/f5t8LM7bsZOD45V2EOoz4kSAEaLx/4aNVu1sWoVVAGvudYl0dOzF/EVJpt6L9cREaChU lpYOLYboCVWHnDRvZKNQmNS2BpODMaOsRza+pXX2M/Rdzj/1z9LB47FY+LnBiiO4u2kLlBA2I4234 Vf/LtQ6wkhUqwB7zDhFwfyfQLvakUBgC13LXenvhd6+THQz7CF8f6A1vGIQ+S3bKO+roMx8vs5emT eUebWfz2gHqZBuUDbm7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pn1rw-006vWj-1J; Thu, 13 Apr 2023 18:40:28 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pn1rt-006vW5-2W; Thu, 13 Apr 2023 18:40:26 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2401C640D0; Thu, 13 Apr 2023 18:40:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 536EDC433EF; Thu, 13 Apr 2023 18:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681411224; bh=mwYnTH2xTUlzJflPd1vC123IfsPEl3nEWJIFOU/ryso=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=C1b7JS3gODDSYYlBDTIpxlgxG1R4XL1R85N0pALFWGPerftCQh/QgRTkSYmNuEYE9 L/Edkv3kS7VyqrGIxRIIdjjQO2xm/Qoe5ITC3m4M51owUTozFTFYrb45KhE0FrHJ9E yjniCCFn4wdkU5OC0UqrILGm8af4piU0eXT+ootGLCww0CkSFCgOTSkv41JoWKduH1 wNXgpYg6SbGBH3SUhdHfLx6632/mSuRMo2Q/jkQfKPur8yk4bqg7cVIAPHLTp5pE43 rCPZVphcdd8JaZowPPREGMbP25Ke1cssVQFxLKe/7IZLp0MzhMSd+NPktv81meIG13 zpAqAywMfmBGA== Message-ID: MIME-Version: 1.0 In-Reply-To: <20230413090128.60119-1-gehao@kylinos.cn> References: <20230413090128.60119-1-gehao@kylinos.cn> Subject: Re: [PATCH] mediatek/clk-mt8173-apmixedsys: convert to devm_platform_ioremap_resource From: Stephen Boyd Cc: gehao@kylinos.cn, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org To: Hao Ge , matthias.bgg@gmail.com, mturquette@baylibre.com Date: Thu, 13 Apr 2023 11:40:22 -0700 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230413_114025_859492_C909E10D X-CRM114-Status: UNSURE ( 9.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Hao Ge (2023-04-13 02:01:28) > diff --git a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c > index a56c5845d07a..fe386bf8225d 100644 > --- a/drivers/clk/mediatek/clk-mt8173-apmixedsys.c > +++ b/drivers/clk/mediatek/clk-mt8173-apmixedsys.c > @@ -90,7 +90,7 @@ static int clk_mt8173_apmixed_probe(struct platform_device *pdev) > struct clk_hw *hw; > int r; > > - base = of_iomap(node, 0); > + base = devm_platform_ioremap_resource(pdev, 0); > if (!base) This needs to be updated. > return PTR_ERR(base); And PTR_ERR(NULL) is 0, which is wrong. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel