From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4687DC5478C for ; Wed, 28 Feb 2024 23:07:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:To:Cc:From:Subject:References: In-Reply-To:MIME-Version:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yWEQHpuJ2Xf3XehMabRkRtd/RBjmYa+2xn2y0t7ACxU=; b=sWkZnwudUWJL3Z tSHeSZsu2luMQxqqngdXvAHsUL/qsfwUYcspByFX55QMg5bhlrPErRQ0tVsXIlxZ+xCvc5osP8tH3 k+drZDjMWvFTXfogwNXbMXlvSN98yhhOJsTzY1TCHF6F2w7JSZMk4q2B8V+FKdpxA0mJjhQDSQpGX CYCz2QDA4Ykfg2Id++9NHBnsh4ksBRJAFxQcE9LOQlIvNLFZyRsDjOhxmm70lMd4vO7ATWmTl/92v 4qpbInMhMcrejjB1el5TTP8A+8xtKA1WkMqgVFjaU9TXU6SDeTeyccHNHburvCADAdfx6cOhKcR5P 5zCDNYZKMFM0MKZOXHgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfT15-0000000BEq9-0zOX; Wed, 28 Feb 2024 23:07:11 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rfT12-0000000BEpU-1tZN for linux-arm-kernel@lists.infradead.org; Wed, 28 Feb 2024 23:07:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B7E47610FB; Wed, 28 Feb 2024 23:07:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 55CF8C433C7; Wed, 28 Feb 2024 23:07:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709161627; bh=aR4XOGShLBiKaiFwyckrNuJndPej+Cz0PLltPRgtO/0=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=SGDMpXELHbumNnj2vOipRsbXBpmiviivWs4gnnCaTcxPqWkKBayyehjUyhwqhySRN 9UAB8ACDCTBUxi0BAgtivVkCW/NXy+UeiEJa9v3Huivqwj/yfc6VVXqsBXPJndte+5 6oGKfrhX+ncpcGWdA7pLNTJvR1u9jfL8GL4C6e/j244TAOj1qZXq+66UNWYfYBGrTX JLa74Ah9kl2vqRV+xNbmzlOhMEmqNVjBzseoIfYjty0wbl+a+Pa7ZGR32+PIH4dqVp A6Feiw6ZcEC6ljZJGDNKpPe/m5dmj3kWwSP/2+baG4bR4qL3wIVuFTe3s4SqOtFbBa WL/OOIqdqJinw== Message-ID: MIME-Version: 1.0 In-Reply-To: <20240214073318.82573-1-duoming@zju.edu.cn> References: <20240214073318.82573-1-duoming@zju.edu.cn> Subject: Re: [PATCH] clk: zynq: Prevent null pointer dereference caused by kmalloc failure From: Stephen Boyd Cc: mturquette@baylibre.com, michal.simek@amd.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Duoming Zhou To: Duoming Zhou , linux-kernel@vger.kernel.org Date: Wed, 28 Feb 2024 15:07:05 -0800 User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240228_150708_569613_568F5D70 X-CRM114-Status: UNSURE ( 9.61 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Duoming Zhou (2024-02-13 23:33:18) > diff --git a/drivers/clk/zynq/clkc.c b/drivers/clk/zynq/clkc.c > index 7bdeaff2bfd..7621c2f0046 100644 > --- a/drivers/clk/zynq/clkc.c > +++ b/drivers/clk/zynq/clkc.c > @@ -427,7 +427,7 @@ static void __init zynq_clk_setup(struct device_node *np) > SLCR_GEM1_CLK_CTRL, 0, 0, &gem1clk_lock); > > tmp = strlen("mio_clk_00x"); > - clk_name = kmalloc(tmp, GFP_KERNEL); > + clk_name = kmalloc(tmp, GFP_KERNEL | __GFP_NOFAIL); Just make a stack variable please. __GFP_NOFAIL is a bad code smell. > for (i = 0; i < NUM_MIO_PINS; i++) { > int idx; > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel