From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6191C27C77 for ; Mon, 17 Jun 2024 07:26:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Cc:To:From:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VAGQjlSoVmUhRRPnFle/Cilr5/xRtzCzsi0PLTzdHq4=; b=MS+PzRKkbLHbwqS9ANvsmbatRX 1eILqfSMj4Khz/B3l78bSnaUZW11U5u8IJXWFuTF7sXqdL0C/Arc3Bq3xvywDkBxqgNYApeQ7UI/N m/taMaNk1+UirFBBoGzxHSsaK0Hyoo8wLv6XwqiqsLh+V6F7n1NGgkrqL9SbjtsccFpG4+WVttS/G +PTRUirofDU1JmTJ8t9EVB2noUFohafnVDqNcfuSN4Jw3UBo8DVeMB4lBjfPFnuwL16T5mGqIClIF 6aa1GS9JCf1gHObbOGNJImBiovP1FJjYbbjpnnTChQFbzULnWMf11segF/4/HoIYlcvVZY87sIAs5 JSUksvTw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ6kZ-00000009de0-30uT; Mon, 17 Jun 2024 07:25:59 +0000 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ6kW-00000009dd4-3kSS for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 07:25:58 +0000 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-42278f3aea4so35717245e9.1 for ; Mon, 17 Jun 2024 00:25:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1718609155; x=1719213955; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VAGQjlSoVmUhRRPnFle/Cilr5/xRtzCzsi0PLTzdHq4=; b=SmueiM0vKMgi9YsrEP7GCtIVoimIc7EQU2XCl4XQgpyE/7yCCnhYNG2GiQZ+937JrI 84cYLDL9baUTqSBGryClCLCbndXP3vlBUBYuyxEMD/fZkhkJ8oX480CkPWo3uBFOfV2d PvSH+q0jDoeVe/mVlo3TWZ7Quo8Zc27Mhbl6x4GY1KWhVWoh4ufgVcY1valycVJWlpZJ rZFlM/MDiEO0scN1UQ/OHogh2yUs3uEQ1KQmTMA3gNm+W/TL2PZSuszf5yYObxRt4wk9 /E4Zs2V1L6uAi1dfpvVxfzidPsq1E8QWugXdiSAUqfPaL0aq6FlTj9Hg5DHfHXqkxUn9 xWRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718609155; x=1719213955; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VAGQjlSoVmUhRRPnFle/Cilr5/xRtzCzsi0PLTzdHq4=; b=M+inLCAQE60zOBVmm+rX/yXidA0ueExe+JO3pGlX0PXY6cYYvh0eiLS7eXEdlanjIf TGbaN+ubI75z2oFIX0tUhT/8GWn5jcudNsTnP+wER05H+UQrYgS5az60NzuRHuECeyli W3+T67jb5VJbjB0dmZg52yff05bIQM2zMjWKp6/mHTyKJ0k7cIZxHqJUh0eNsuuKJPCg VJFPKUpUHDpQC+8iGiKR63QyS7jvF1rfym6VwYkSuL0fDjK3VMkiotW8wXcYvtrgJHng O7w5vFWs6A8HHPIW6xboxIyoEEQiECaEdSgnsYDo7YquHQJD3vO7Q1Z4d1T5aJBI0pw5 ZJLg== X-Forwarded-Encrypted: i=1; AJvYcCVo0mljTUb0rkp/SBGL/suy21/EvDO2jaHG1+XRDXfc3R2YMex9SFmro0sbLVZcnmHeyIy8mlFJuWaqD+8lkHHmtrUnhmj1KEog8tOlgacYjF227do= X-Gm-Message-State: AOJu0Yx4YBM1ZPzdYiFj0P8To5kdeFWxC8WYCpcHmKshSM/ytoUgQY2O SB8gCFqBKzszJ674a3k5h0mlnCq32q/597zM30p/NYpXjUlGMFfMn4lR7JEuFnY= X-Google-Smtp-Source: AGHT+IHGTLig64RZScCxEgxVs7DaULrPVWEgwJ03TPdeRQTj+7cL+VH6g1Og+GMfyv9gu7deldJu4w== X-Received: by 2002:a05:600c:3107:b0:423:499:a1ce with SMTP id 5b1f17b1804b1-42304d934c4mr82449965e9.32.1718609154783; Mon, 17 Jun 2024 00:25:54 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-422f641a64bsm151553735e9.46.2024.06.17.00.25.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jun 2024 00:25:54 -0700 (PDT) Message-ID: Date: Mon, 17 Jun 2024 10:25:52 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 03/12] dt-bindings: mfd: renesas,rzg3s-vbattb: Document VBATTB Content-Language: en-US From: claudiu beznea To: Krzysztof Kozlowski , geert+renesas@glider.be, mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org, alexandre.belloni@bootlin.com, magnus.damm@gmail.com Cc: linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Claudiu Beznea References: <20240614071932.1014067-1-claudiu.beznea.uj@bp.renesas.com> <20240614071932.1014067-4-claudiu.beznea.uj@bp.renesas.com> <936beb9a-2701-476c-8f5a-4b6b06d4f87d@kernel.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_002556_971990_14408A5C X-CRM114-Status: GOOD ( 18.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17.06.2024 10:16, claudiu beznea wrote: > > > On 16.06.2024 10:38, Krzysztof Kozlowski wrote: >> On 14/06/2024 09:19, Claudiu wrote: >>> From: Claudiu Beznea >> >>> + >>> +maintainers: >>> + - Claudiu Beznea >>> + >>> +properties: >>> + compatible: >>> + items: >>> + - const: renesas,rzg3s-vbattb >>> + - const: syscon >>> + - const: simple-mfd >> >> No, mfd does no look good. That's not a simple device anymore and you >> claim here child does not need vbat bclk, power domains and resets? That >> would be a big surprise, although technically possible. > > I wasn't sure how this MFD will be received by the Renesas maintainers so I > kept it simple for this version. > > In theory the VBAT clk, power domain and resets are specific to VBAT module > itself but, indeed, the child cannot work w/o these. > >> >> Please clarify: which of parent resources are needed for children? > > VBAT clock, power domain are needed. Reset, too. In the current > implementation the reset is deasserted though parent by calling the > syscon_node_to_regmap(np->parent) in the clock driver. > >> >> ... >> >>> + >>> +additionalProperties: false >>> + >>> +examples: >>> + - | >>> + #include >>> + #include >>> + >>> + vbattb: vbattb@1005c000 { >>> + compatible = "renesas,rzg3s-vbattb", "syscon", "simple-mfd"; >>> + reg = <0x1005c000 0x1000>; >>> + ranges = <0 0 0x1005c000 0 0x1000>; >>> + interrupts = ; >>> + interrupt-names = "tampdi"; >>> + clocks = <&cpg CPG_MOD R9A08G045_VBAT_BCLK>; >>> + clock-names = "bclk"; >>> + power-domains = <&cpg>; >>> + resets = <&cpg R9A08G045_VBAT_BRESETN>; >>> + #address-cells = <2>; >>> + #size-cells = <2>; >>> + status = "disabled"; >> >> Drop > > Could you please clarify this? Would you want me to drop the full node > (same for clock-controller node)? Looking at your review on patch 05/12 from this series I noticed you're taking about the status = "disabled" lines. I'll drop it as suggested. Thank you, Claudiu Beznea > > Can you point me an example that you are thinking about? > > Thank you, > Claudiu Beznea > >> >>> + >>> + vbattclk: clock-controller@1c { >>> + compatible = "renesas,rzg3s-vbattb-clk"; >>> + reg = <0 0x1c 0 0x10>; >>> + clocks = <&cpg CPG_MOD R9A08G045_VBAT_BCLK>, <&vbattb_xtal>; >>> + clock-names = "bclk", "vbattb_xtal"; >>> + #clock-cells = <0>; >>> + power-domains = <&cpg>; >>> + status = "disabled"; >> >> Drop >> >>> + }; >>> + }; >>> + >>> +... >> >> Best regards, >> Krzysztof >>