From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5191C7EE2E for ; Fri, 9 Jun 2023 09:06:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Z0/Vh0vt5/aAKf0c478WV6ZR9HlpI8kQGPHUFRqYpkU=; b=s8pMbTXFP57mED IIAqvU7h+M6Tj0DM+IsECLeRvOw9TVbDyCzb2RoUPuV5A4Ec5KGbrnBgOQ/V0WGcFp5i2tgHjqGjT j6w1qrLgBtR0O3CyADuIzPL8yoUHKQaIpEymsKCoqo4YvAQ1r9rPCQCD392l+zkWE4QcPXNO08oyn FBSavuKzyYrrEospcw030rf3q5Ua9w9QjvGYy2PaBTpM5I4az9XxFh8NbVJjoMkC97PvoYDdR9arP uKGDCIVl3RldnYSVBhI23cVTzylhOB+Xuc6pqkhhjXavoGyujC46PjVPjHO8sVTmI/7nIcAuYMvtt ki7mAyd4oDUzn33c35QA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q7Y4X-00CM19-2f; Fri, 09 Jun 2023 09:06:17 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q7Y4R-00CLyU-1e for linux-arm-kernel@lists.infradead.org; Fri, 09 Jun 2023 09:06:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686301570; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eyj9qAaMTXhV0BDBMXgw3bkhoC43Djt8OMEq06UECOo=; b=MftZzibkIXcevdRkcvaE6jujBfCIsBKgkrV2eDCGGuXcDZ4fjLQsGvoTHC1SOPr1mwlDPK vbM7oQBMyR4qSSziJ9R6H59OrFrdmirUOwRzbMSUgMmuJe8I0ApRKVZLnWkY5ST8oUeB/U yMZY9KwMTDT4fYbQvJQ21EvITNsHgk4= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-91-U-rOr7cNPrW89U5d5NSMFQ-1; Fri, 09 Jun 2023 05:06:06 -0400 X-MC-Unique: U-rOr7cNPrW89U5d5NSMFQ-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-506b21104faso1507642a12.1 for ; Fri, 09 Jun 2023 02:06:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686301565; x=1688893565; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eyj9qAaMTXhV0BDBMXgw3bkhoC43Djt8OMEq06UECOo=; b=DNiMuyiM5w85D95uYkPgf+/5FGoSkGWWaGKbcyPqhZCs8R+jfYyGIC9I181wugf3tr 67rUrUKDGR4U8oVtOTa1/W//Xy+8/UeQgmURU6LllP73bMQaZ6cNhgQ1GOFF4zarVx6Y NZVaFztNF0xm+Ojomncfikr+dd1BCygLhggLp1DcQ4za9SlGrWcFqancpC6VvTucbujA iyTM0zb2pPcc3e0jpQMY0RezTbJoeJ+bcmiYxlZudYXvMT2CpKFj1XEELlye30MoRyld QUaz1ws04D553l5bZpMq7KARtsp0R0FfEmVXdq+WELIKrcC1PrU6cXcXP4qE5xJk+eej UoZw== X-Gm-Message-State: AC+VfDyRhxYRE0tipsatXSKkmsJk99WsIYlSYnJ6GBse8l3Wa+zL6Pau 19K1u7BvJSz262JFuGqm7Pp8iMUcAXg5toGHO64/BTaey7ZWFUItvUQOWcSkCTVw3nt6imu4oT4 JvpDMbJTa4LoLEBkVOuQ4NE8Px1dBKmutorQ= X-Received: by 2002:a05:6402:643:b0:510:82b4:844d with SMTP id u3-20020a056402064300b0051082b4844dmr902459edx.2.1686301565419; Fri, 09 Jun 2023 02:06:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Eo2fL8sg8ZAFF9ExDb1hoz+RWsXilNiiceAqQ1jh6YF+h+q2Lb+V5P8mQdJn5E/+DPP6p2g== X-Received: by 2002:a05:6402:643:b0:510:82b4:844d with SMTP id u3-20020a056402064300b0051082b4844dmr902445edx.2.1686301565157; Fri, 09 Jun 2023 02:06:05 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id f9-20020a056402068900b0051495ce23absm1517006edy.10.2023.06.09.02.06.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jun 2023 02:06:04 -0700 (PDT) Message-ID: Date: Fri, 9 Jun 2023 11:06:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH mm-unstable v2 09/10] kvm/x86: add kvm_arch_test_clear_young() To: Yu Zhao , Andrew Morton Cc: Alistair Popple , Anup Patel , Ben Gardon , Borislav Petkov , Catalin Marinas , Chao Peng , Christophe Leroy , Dave Hansen , Fabiano Rosas , Gaosheng Cui , Gavin Shan , "H. Peter Anvin" , Ingo Molnar , James Morse , "Jason A. Donenfeld" , Jason Gunthorpe , Jonathan Corbet , Marc Zyngier , Masami Hiramatsu , Michael Ellerman , Michael Larabel , Mike Rapoport , Nicholas Piggin , Oliver Upton , Paul Mackerras , Peter Xu , Sean Christopherson , Steven Rostedt , Suzuki K Poulose , Thomas Gleixner , Thomas Huth , Will Deacon , Zenghui Yu , kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-trace-kernel@vger.kernel.org, x86@kernel.org, linux-mm@google.com References: <20230526234435.662652-1-yuzhao@google.com> <20230526234435.662652-10-yuzhao@google.com> From: Paolo Bonzini In-Reply-To: <20230526234435.662652-10-yuzhao@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230609_020611_624325_A4C19E20 X-CRM114-Status: GOOD ( 10.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/27/23 01:44, Yu Zhao wrote: > +#define kvm_arch_has_test_clear_young kvm_arch_has_test_clear_young > +static inline bool kvm_arch_has_test_clear_young(void) > +{ > + return IS_ENABLED(CONFIG_X86_64) && > + (!IS_REACHABLE(CONFIG_KVM) || (tdp_mmu_enabled && shadow_accessed_mask)); > +} I don't think you need IS_REACHABLE(CONFIG_KVM) here, it would be a bug if this is called from outside KVM code. Maybe make it a BUILD_BUG_ON? Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel