From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A680C433EF for ; Wed, 5 Jan 2022 01:36:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KF1nVmUXvBNOCELxbn28/0vyNRMEyzp/DUO2ubeDR6U=; b=LgXg4VtTiz3mrwoGwK+RoSJBXw vdbxnMWD3OVlcspDZMrMWnBnoQlbfnnRH6zMv8EaKYL0FysMd78+a227kviSERxMcAJvAScFDOZgZ nqzmwlM8RScbzbWqjfv5oRcTlvSGUTdr8iNRIDRXd1LPb1K0YTNbfe2jVNvdMvEx5lKi7ZFSK4UBq rnAquqFFtowwajpkmFR2UrBWFLvt+ZItejYtDsqVPcBrV2ShxrjCwlT2KviXuTmkSipIdmqHa25il nFST/3gIAFAr83Bt6WdV4gYG648rxwrZcYoz2fvuyQq79tJGB+1cX4O5Z//xyB1dxKn+WjKyvufr5 6HQpZa6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4vCs-00DFOi-Mw; Wed, 05 Jan 2022 01:35:14 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n4vCn-00DFN7-WA for linux-arm-kernel@lists.infradead.org; Wed, 05 Jan 2022 01:35:12 +0000 Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.53]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4JTBq538Nnzcbxj; Wed, 5 Jan 2022 09:34:25 +0800 (CST) Received: from dggpemm500002.china.huawei.com (7.185.36.229) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 5 Jan 2022 09:34:58 +0800 Received: from [10.174.178.247] (10.174.178.247) by dggpemm500002.china.huawei.com (7.185.36.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 5 Jan 2022 09:34:58 +0800 Subject: Re: [PATCH v3 2/2] ACPI: AGDI: Add driver for Arm Generic Diagnostic Dump and Reset device To: Ilkka Koskinen , , , , CC: , , , , , , , References: <20211231033725.21109-1-ilkka@os.amperecomputing.com> <20211231033725.21109-3-ilkka@os.amperecomputing.com> From: Hanjun Guo Message-ID: Date: Wed, 5 Jan 2022 09:34:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20211231033725.21109-3-ilkka@os.amperecomputing.com> Content-Language: en-GB X-Originating-IP: [10.174.178.247] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500002.china.huawei.com (7.185.36.229) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220104_173510_413992_C2702A81 X-CRM114-Status: GOOD ( 25.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ilkka, On 2021/12/31 11:37, Ilkka Koskinen wrote: > ACPI for Arm Components 1.1 Platform Design Document v1.1 [0] specifices > Arm Generic Diagnostic Device Interface (AGDI). It allows an admin to > issue diagnostic dump and reset via an SDEI event or an interrupt. > This patch implements SDEI path. > > [0] https://developer.arm.com/documentation/den0093/latest/ > > Signed-off-by: Ilkka Koskinen > --- > drivers/acpi/arm64/Kconfig | 8 +++ > drivers/acpi/arm64/Makefile | 1 + > drivers/acpi/arm64/agdi.c | 125 ++++++++++++++++++++++++++++++++++++ > 3 files changed, 134 insertions(+) > create mode 100644 drivers/acpi/arm64/agdi.c > > diff --git a/drivers/acpi/arm64/Kconfig b/drivers/acpi/arm64/Kconfig > index 6dba187f4f2e..24869ba5b365 100644 > --- a/drivers/acpi/arm64/Kconfig > +++ b/drivers/acpi/arm64/Kconfig > @@ -8,3 +8,11 @@ config ACPI_IORT > > config ACPI_GTDT > bool > + > +config ACPI_AGDI > + bool "Arm Generic Diagnostic Dump and Reset Device Interface" > + depends on ARM_SDE_INTERFACE > + help > + Arm Generic Diagnostic Dump and Reset Device Interface (AGDI) is > + a standard that enables issuing a non-maskable diagnostic dump and > + reset command. > diff --git a/drivers/acpi/arm64/Makefile b/drivers/acpi/arm64/Makefile > index 66acbe77f46e..7b9e4045659d 100644 > --- a/drivers/acpi/arm64/Makefile > +++ b/drivers/acpi/arm64/Makefile > @@ -1,4 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0-only > +obj-$(CONFIG_ACPI_AGDI) += agdi.o > obj-$(CONFIG_ACPI_IORT) += iort.o > obj-$(CONFIG_ACPI_GTDT) += gtdt.o > obj-y += dma.o > diff --git a/drivers/acpi/arm64/agdi.c b/drivers/acpi/arm64/agdi.c > new file mode 100644 > index 000000000000..6525ccbae5c1 > --- /dev/null > +++ b/drivers/acpi/arm64/agdi.c > @@ -0,0 +1,125 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * This file implements handling of > + * Arm Generic Diagnostic Dump and Reset Interface table (AGDI) > + * > + * Copyright (c) 2021, Ampere Computing LLC > + */ > + > +#define pr_fmt(fmt) "ACPI: AGDI: " fmt > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Please keep the head files in alphabetical order. > + > +struct agdi_data { > + int sdei_event; > +}; > + > +static int agdi_sdei_handler(u32 sdei_event, struct pt_regs *regs, void *arg) > +{ > + nmi_panic(regs, "Arm Generic Diagnostic Dump and Reset SDEI event issued"); > + return 0; > +} > + > +static int agdi_sdei_probe(struct platform_device *pdev, > + struct agdi_data *adata) > +{ > + int err; > + > + err = sdei_event_register(adata->sdei_event, agdi_sdei_handler, pdev); > + if (err) { > + dev_err(&pdev->dev, "Failed to register for SDEI event %d", > + adata->sdei_event); > + return err; > + } > + > + err = sdei_event_enable(adata->sdei_event); > + if (err) { > + sdei_event_unregister(adata->sdei_event); > + dev_err(&pdev->dev, "Failed to enable event %d\n", > + adata->sdei_event); > + return err; > + } > + > + return 0; > +} > + > +static int agdi_probe(struct platform_device *pdev) > +{ > + struct agdi_data *adata; > + > + adata = dev_get_platdata(&pdev->dev); > + if (!adata) > + return -EINVAL; > + > + return agdi_sdei_probe(pdev, adata); > +} > + > +static int agdi_remove(struct platform_device *pdev) > +{ > + struct agdi_data *adata = platform_get_drvdata(pdev); > + > + sdei_event_disable(adata->sdei_event); > + sdei_event_unregister(adata->sdei_event); > + > + return 0; > +} > + > +static struct platform_driver agdi_driver = { > + .driver = { > + .name = "agdi", > + }, > + .probe = agdi_probe, > + .remove = agdi_remove, > +}; > + > +static int __init agdi_init(void) > +{ > + int ret; > + acpi_status status; > + struct acpi_table_agdi *agdi_table; > + struct agdi_data pdata; > + struct platform_device *pdev; > + > + if (acpi_disabled) > + return 0; > + > + status = acpi_get_table(ACPI_SIG_AGDI, 0, > + (struct acpi_table_header **) &agdi_table); > + if (ACPI_FAILURE(status)) > + return -ENODEV; > + > + if (agdi_table->flags & ACPI_AGDI_SIGNALING_MODE) { > + pr_warn("Interrupt signaling is not supported"); > + ret = -ENODEV; > + goto err_put_table; > + } > + > + pdata.sdei_event = agdi_table->sdei_event; > + > + pdev = platform_device_register_data(NULL, "agdi", 0, &pdata, sizeof(pdata)); > + if (IS_ERR(pdev)) { > + ret = PTR_ERR(pdev); > + goto err_put_table; > + } > + > + ret = platform_driver_register(&agdi_driver); > + if (ret) > + goto err_device_unregister; > + > + acpi_put_table((struct acpi_table_header *)agdi_table); > + return 0; > + > +err_device_unregister: > + platform_device_unregister(pdev); > +err_put_table: > + acpi_put_table((struct acpi_table_header *)agdi_table); > + return ret; > +} > +device_initcall(agdi_init); The rest are looking good to me. Thanks Hanjun _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel