From: neil.armstrong@linaro.org
To: Dmitry Rokosov <ddrokosov@sberdevices.ru>,
krzysztof.kozlowski@linaro.org, robh@kernel.org,
khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com, jianxin.pan@amlogic.com
Cc: kernel@sberdevices.ru, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
rockosov@gmail.com
Subject: Re: [PATCH v2] firmware: meson_sm: populate platform devices from sm device tree data
Date: Fri, 24 Mar 2023 15:05:53 +0100 [thread overview]
Message-ID: <f1088121-02c7-86da-d603-7c2015030b0e@linaro.org> (raw)
In-Reply-To: <20230324140141.6743-1-ddrokosov@sberdevices.ru>
On 24/03/2023 15:01, Dmitry Rokosov wrote:
> In some meson boards, secure monitor device has children, for example,
> power secure controller. By default, secure monitor isn't the bus in terms
> of device tree subsystem, so the of_platform initialization code doesn't
> populate its device tree data. As a result, secure monitor's children
> aren't probed at all.
>
> Run the 'of_platform_populate()' routine manually to resolve such issues.
>
> Signed-off-by: Dmitry Rokosov <ddrokosov@sberdevices.ru>
> ---
> drivers/firmware/meson/meson_sm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/meson/meson_sm.c b/drivers/firmware/meson/meson_sm.c
> index 77aa5c6398aa..b79d0e316cb1 100644
> --- a/drivers/firmware/meson/meson_sm.c
> +++ b/drivers/firmware/meson/meson_sm.c
> @@ -316,7 +316,7 @@ static int __init meson_sm_probe(struct platform_device *pdev)
> if (sysfs_create_group(&pdev->dev.kobj, &meson_sm_sysfs_attr_group))
> goto out_in_base;
>
> - return 0;
> + return devm_of_platform_populate(dev);
You should check return and jump to out_in_base on error instead.
Neil
>
> out_in_base:
> iounmap(fw->sm_shmem_in_base);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-24 14:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 14:01 [PATCH v2] firmware: meson_sm: populate platform devices from sm device tree data Dmitry Rokosov
2023-03-24 14:05 ` neil.armstrong [this message]
2023-03-24 14:13 ` Dmitry Rokosov
2023-03-24 14:08 ` Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1088121-02c7-86da-d603-7c2015030b0e@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=ddrokosov@sberdevices.ru \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jianxin.pan@amlogic.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=robh@kernel.org \
--cc=rockosov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox