From: Florian Fainelli <f.fainelli@gmail.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Peter Robinson <pbrobinson@gmail.com>,
Eric Anholt <eric@anholt.net>, David Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] gpu/drm/v3d: Add ARCH_BCM2835 to DRM_V3D Kconfig
Date: Wed, 18 Dec 2019 09:39:55 -0800 [thread overview]
Message-ID: <f127b960-e374-ce6f-403a-6f592408f9ee@gmail.com> (raw)
In-Reply-To: <78a1badd7c08ca39e7f62c6b66addeb2bf485a1e.camel@suse.de>
On 12/18/19 6:39 AM, Nicolas Saenz Julienne wrote:
> Hi Peter,
>
> On Wed, 2019-12-18 at 08:43 +0000, Peter Robinson wrote:
>> On arm64 the config ARCH_BCM doesn't exist so to be able to
>> build for platforms such as the Raspberry Pi 4 we need to add
>> ARCH_BCM2835 similar to what has been done on vc4.
>>
>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
>> ---
>
> v3d's upstream implementation doesn't support RPi4 for now. So I don't see how
> we could benefit from this.
Right, but it should support the Pi3 running in 64-bit mode too, so
maybe that would be a better justification to put in the commit message?
>
> That said you're more than welcome to have a go at adding support for RPi4. It
> seems to me that the divergence betweeen us and Raspberry Pi foundation's
> kernel isn't that big. Maybe Eric can share some extra light on this.
>
> Regards,
> Nicolas
>
>> drivers/gpu/drm/v3d/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/v3d/Kconfig b/drivers/gpu/drm/v3d/Kconfig
>> index 9a5c44606337..b0e048697964 100644
>> --- a/drivers/gpu/drm/v3d/Kconfig
>> +++ b/drivers/gpu/drm/v3d/Kconfig
>> @@ -1,7 +1,7 @@
>> # SPDX-License-Identifier: GPL-2.0-only
>> config DRM_V3D
>> tristate "Broadcom V3D 3.x and newer"
>> - depends on ARCH_BCM || ARCH_BCMSTB || COMPILE_TEST
>> + depends on ARCH_BCM || ARCH_BCMSTB || ARCH_BCM2835 || COMPILE_TEST
>> depends on DRM
>> depends on COMMON_CLK
>> depends on MMU
>
--
Florian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-18 17:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 8:43 [PATCH] gpu/drm/v3d: Add ARCH_BCM2835 to DRM_V3D Kconfig Peter Robinson
2019-12-18 14:39 ` Nicolas Saenz Julienne
2019-12-18 17:39 ` Florian Fainelli [this message]
2019-12-18 17:51 ` Nicolas Saenz Julienne
2020-03-05 6:27 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f127b960-e374-ce6f-403a-6f592408f9ee@gmail.com \
--to=f.fainelli@gmail.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric@anholt.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=pbrobinson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox