linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
Date: Mon, 28 Mar 2011 11:08:15 +0530	[thread overview]
Message-ID: <f12f050c3f7fe0b405fde475fcd62104@mail.gmail.com> (raw)
In-Reply-To: <1301099396-30380-1-git-send-email-omar.ramirez@ti.com>

> -----Original Message-----
> From: Omar Ramirez Luna [mailto:omar.ramirez at ti.com]
> Sent: Saturday, March 26, 2011 6:00 AM
> To: Tony Lindgren
> Cc: Russell King; l-o; lak; sricharan; Santosh Shilimkar; Felipe
> Balbi; Benoit Cousson; Omar Ramirez Luna
> Subject: [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message
>
> If an error occurs in the L3 on any other initiator than MPU,
> the interrupt goes unhandled given that the 'base' register
> was calculated with the initialized err_base value (which
> coincidentally points to MPU) and not with the actual source
> of the error.
>
> Signed-off-by: Omar Ramirez Luna <omar.ramirez@ti.com>

Patch looks good. Did you observe this with DSP initiator??

Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

> ---
>  arch/arm/mach-omap2/omap_l3_smx.c |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_l3_smx.c b/arch/arm/mach-
> omap2/omap_l3_smx.c
> index 5f2da75..da917c2 100644
> --- a/arch/arm/mach-omap2/omap_l3_smx.c
> +++ b/arch/arm/mach-omap2/omap_l3_smx.c
> @@ -196,11 +196,12 @@ static irqreturn_t omap3_l3_app_irq(int irq,
> void *_l3)
>  		/* No timeout error for debug sources */
>  	}
>
> -	base = ((l3->rt) + (*(omap3_l3_bases[int_type] +
> err_source)));
> -
>  	/* identify the error source */
>  	for (err_source = 0; !(status & (1 << err_source));
> err_source++)
>  									;
> +
> +	base = ((l3->rt) + (*(omap3_l3_bases[int_type] +
> err_source)));
> +
>  	error = omap3_l3_readll(base, L3_ERROR_LOG);
>
>  	if (error) {
> --
> 1.7.1

  parent reply	other threads:[~2011-03-28  5:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-26  0:29 [PATCH] OMAP3: l3: fix for "irq 10: nobody cared" message Omar Ramirez Luna
2011-03-26  0:44 ` Ramirez Luna, Omar
2011-03-26 21:38 ` Sergei Shtylyov
2011-03-28  1:49   ` Ramirez Luna, Omar
2011-03-28  8:27     ` Sergei Shtylyov
2011-03-28  1:30 ` Felipe Contreras
2011-03-28  1:47   ` Ramirez Luna, Omar
2011-03-28  5:38 ` Santosh Shilimkar [this message]
2011-03-28 15:15   ` Ramirez Luna, Omar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f12f050c3f7fe0b405fde475fcd62104@mail.gmail.com \
    --to=santosh.shilimkar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).