From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23ED7C3DA4A for ; Fri, 26 Jul 2024 18:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lyBUB0VjQodyh7/g5kyro/B0sHtxliR680HpWSHx5x4=; b=o0xqaEUsBXzwqs9kQ1h+Z6yUt8 iKgaGSy1SF77AkNM4ye6TNSnQuhn/NpvfXUePJE8oWjgCaMM/8ACciM1+3wyaJ9FuLe3jnLL/aA65 XbRsLpMbVqaikbuurrIMod+lyqjZSQN+SfzFLhc8JiUGFwHMa73DWbgiEYJBM+01ixriovnODpgWg OaLAykvV3QyrU0mZ5x5P70kLDeEN9bfWKh0s3ZXWiCKQbV3ULx2eqmMrIHyKYZVo0EPKDKLVEaQem dgqdcd/MLgoZHIOSjAgOP1bXfkX2w0/G9J9NNiUzpz3rdXfBm0eKLJnwW4MgzLewSfCUnLbj0dDUZ MLJgCeew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXPFQ-00000004anP-3ffD; Fri, 26 Jul 2024 18:00:56 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sXOCg-00000004TUu-0vzf for linux-arm-kernel@lists.infradead.org; Fri, 26 Jul 2024 16:54:03 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-42808071810so14790635e9.1 for ; Fri, 26 Jul 2024 09:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1722012840; x=1722617640; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=lyBUB0VjQodyh7/g5kyro/B0sHtxliR680HpWSHx5x4=; b=aZwXaoaOzQ+YN0hZZgMUyfjYbrlEtrBFhEwM0GqME8Px52w3u/lMFqdft8KSg7ryrc xrD3lXBQZggN1i0pDTpGkbM8zjK4qzL1x50f4BRQXXaFkZX099+OSQlnKjHJofo+7uqu sueIzNDYsV+QnfB8lLC3UvW+z4cs/SFENBx6ynINWuhM4BCY3gy5Aj4rFFGa4P/RVBT/ g66bFOfvGkZAmv9mK/3O6BVHfNojdXJ5ueM4a7/2x8iJHhdfOkKB8PilBFXq0LC5TSSF g+l2zR5Wmroj+3h1haIP/HyyoaLwaZReSnxt6rdeFuSCo2rHfZrWAfG5yKXc4MJQNTMk mwCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722012840; x=1722617640; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lyBUB0VjQodyh7/g5kyro/B0sHtxliR680HpWSHx5x4=; b=XQWLGoSgcgukSb5e+RxqLNyEvOTLpx7blEkTrs3EyBI2w5n0Xr5rBAfxcRJK4j0bq2 8YHNu+AqO8DimhqL8GI8sg9ehtod/eIHgwsu9ZcxiOOf1BHuYvpYhwXTOShhVomj6PN0 W/m60+P+YJqHlalzLkyoAcXjunY01Or4JnegZybTFpGzLYIuJApktCJfltyd0lImWGro Z/AE/HmrjWeFDQm1iNj5/yQGfCtoLAeKR3HbjnOSwxSc2ByUlXI1RazC8P+G+ADAFy5W hDmFhdmsu0OG/aJBZV8zsNG4kZtpezuLL8psvVqq7eqy4Uu1dz/ux3GGTYCTWmmtSVZz 0/Sg== X-Gm-Message-State: AOJu0YzL45vrDXfTUW5LHGE9KwhZ0XoalTe4S50JNb9p3QAF8VazLYkL kqEPIKGnzuYnUOo44wShAbHW03lEmyW/v4NdMbssR85Es5vEUkWY3glk/j2upgA= X-Google-Smtp-Source: AGHT+IGpGw0WiufgY26+n/F7oToSP+bfbqFIHW3rW6u4ArhcoqZorHULtO/EvyMqvgVFTdS12d7ILA== X-Received: by 2002:a05:600c:6c4c:b0:426:5f06:5462 with SMTP id 5b1f17b1804b1-42811e422e4mr1002575e9.37.1722012839726; Fri, 26 Jul 2024 09:53:59 -0700 (PDT) Received: from [192.168.0.32] ([47.62.239.100]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427f9372e99sm125436245e9.16.2024.07.26.09.53.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jul 2024 09:53:59 -0700 (PDT) Message-ID: Date: Fri, 26 Jul 2024 18:53:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: s32g: add the pinctrl node To: Andrei Stefanescu , Chester Lin , Ghennadi Procopciuc , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, NXP S32 Linux Team References: <20240724132415.1700386-1-andrei.stefanescu@oss.nxp.com> Content-Language: en-US, ca-ES, es-ES From: Matthias Brugger Autocrypt: addr=mbrugger@suse.com; keydata= xsFNBFP1zgUBEAC21D6hk7//0kOmsUrE3eZ55kjc9DmFPKIz6l4NggqwQjBNRHIMh04BbCMY fL3eT7ZsYV5nur7zctmJ+vbszoOASXUpfq8M+S5hU2w7sBaVk5rpH9yW8CUWz2+ZpQXPJcFa OhLZuSKB1F5JcvLbETRjNzNU7B3TdS2+zkgQQdEyt7Ij2HXGLJ2w+yG2GuR9/iyCJRf10Okq gTh//XESJZ8S6KlOWbLXRE+yfkKDXQx2Jr1XuVvM3zPqH5FMg8reRVFsQ+vI0b+OlyekT/Xe 0Hwvqkev95GG6x7yseJwI+2ydDH6M5O7fPKFW5mzAdDE2g/K9B4e2tYK6/rA7Fq4cqiAw1+u EgO44+eFgv082xtBez5WNkGn18vtw0LW3ESmKh19u6kEGoi0WZwslCNaGFrS4M7OH+aOJeqK fx5dIv2CEbxc6xnHY7dwkcHikTA4QdbdFeUSuj4YhIZ+0QlDVtS1QEXyvZbZky7ur9rHkZvP ZqlUsLJ2nOqsmahMTIQ8Mgx9SLEShWqD4kOF4zNfPJsgEMB49KbS2o9jxbGB+JKupjNddfxZ HlH1KF8QwCMZEYaTNogrVazuEJzx6JdRpR3sFda/0x5qjTadwIW6Cl9tkqe2h391dOGX1eOA 1ntn9O/39KqSrWNGvm+1raHK+Ev1yPtn0Wxn+0oy1tl67TxUjQARAQABzSRNYXR0aGlhcyBC cnVnZ2VyIDxtYnJ1Z2dlckBzdXNlLmNvbT7CwXgEEwECACIFAlV6iM0CGwMGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAAAoJENkUC7JWEwLx6isQAIMGBgJnFWovDS7ClZtjz1LgoY8skcMU ghUZY4Z/rwwPqmMPbY8KYDdOFA+kMTEiAHOR+IyOVe2+HlMrXv/qYH4pRoxQKm8H9FbdZXgL bG8IPlBu80ZSOwWjVH+tG62KHW4RzssVrgXEFR1ZPTdbfN+9Gtf7kKxcGxWnurRJFzBEZi4s RfTSulQKqTxJ/sewOb/0kfGOJYPAt/QN5SUaWa6ILa5QFg8bLAj6bZ81CDStswDt/zJmAWp0 08NOnhrZaTQdRU7mTMddUph5YVNXEXd3ThOl8PetTyoSCt04PPTDDmyeMgB5C3INLo1AXhEp NTdu+okvD56MqCxgMfexXiqYOkEWs/wv4LWC8V8EI3Z+DQ0YuoymI5MFPsW39aPmmBhSiacx diC+7cQVQRwBR6Oz/k9oLc+0/15mc+XlbvyYfscGWs6CEeidDQyNKE/yX75KjLUSvOXYV4d4 UdaNrSoEcK/5XlW5IJNM9yae6ZOL8vZrs5u1+/w7pAlCDAAokz/As0vZ7xWiePrI+kTzuOt5 psfJOdEoMKQWWFGd/9olX5ZAyh9iXk9TQprGUOaX6sFjDrsTRycmmD9i4PdQTawObEEiAfzx 1m2MwiDs2nppsRr7qwAjyRhCq2TOAh0EDRNgYaSlbIXX/zp38FpK/9DMbtH14vVvG6FXog75 HBoOzsFNBF3VOUgBEACbvyZOfLjgfB0hg0rhlAfpTmnFwm1TjkssGZKvgMr/t6v1yGm8nmmD MIa4jblx41MSDkUKFhyB80wqrAIB6SRX0h6DOLpQrjjxbV46nxB5ANLqwektI57yenr/O+ZS +GIuiSTu1kGEbP5ezmpCYk9dxqDsAyJ+4Rx/zxlKkKGZQHdZ+UlXYOnEXexKifkTDaLne6Zc up1EgkTDVmzam4MloyrA/fAjIx2t90gfVkEEkMhZX/nc/naYq1hDQqGN778CiWkqX3qimLqj 1UsZ6qSl6qsozZxvVuOjlmafiVeXo28lEf9lPrzMG04pS3CFKU4HZsTwgOidBkI5ijbDSimI CDJ+luKPy6IjuyIETptbHZ9CmyaLgmtkGaENPqf+5iV4ZbQNFxmYTZSN56Q9ZS6Y3XeNpVm6 FOFXrlKeFTTlyFlPy9TWcBMDCKsxV5eB5kYvDGGxx26Tec1vlVKxX3kQz8o62KWsfr1kvpeu fDzx/rFpoY91XJSKAFNZz99xa7DX6eQYkM2qN9K8HuJ7XXhHTxDbxpi3wsIlFdgzVa5iWhNw iFFJdSiEaAeaHu6yXjr39FrkIVoyFPfIJVyK4d1mHe77H47WxFw6FoVbcGTEoTL6e3HDwntn OGAU6CLYcaQ4aAz1HTcDrLBzSw/BuCSAXscIuKuyE/ZT+rFbLcLwOQARAQABwsF2BBgBCAAg FiEE5rmSGMDywyUcLDoX2RQLslYTAvEFAl3VOUgCGwwACgkQ2RQLslYTAvG11w/+Mcn28jxp 0WLUdChZQoJBtl1nlkkdrIUojNT2RkT8UfPPMwNlgWBwJOzaSZRXIaWhK1elnRa10IwwHfWM GhB7nH0u0gIcSKnSKs1ebzRazI8IQdTfDH3VCQ6YMl+2bpPz4XeWqGVzcLAkamg9jsBWV6/N c0l8BNlHT5iH02E43lbDgCOxme2pArETyuuJ4tF36F7ntl1Eq1FE0Ypk5LjB602Gh2N+eOGv hnbkECywPmr7Hi5o7yh8bFOM52tKdGG+HM8KCY/sEpFRkDTA28XGNugjDyttOI4UZvURuvO6 quuvdYW4rgLVgAXgLJdQEvpnUu2j/+LjjOJBQr12ICB8T/waFc/QmUzBFQGVc20SsmAi1H9c C4XB87oE4jjc/X1jASy7JCr6u5tbZa+tZjYGPZ1cMApTFLhO4tR/a/9v1Fy3fqWPNs3F4Ra3 5irgg5jpAecT7DjFUCR/CNP5W6nywKn7MUm/19VSmj9uN484vg8w/XL49iung+Y+ZHCiSUGn LV6nybxdRG/jp8ZQdQQixPA9azZDzuTu+NjKtzIA5qtfZfmm8xC+kAwAMZ/ZnfCsKwN0bbnD YfO3B5Q131ASmu0kbwY03Mw4PhxDzZNrt4a89Y95dq5YkMtVH2Me1ZP063cFCCYCkvEAK/C8 PVrr2NoUqi/bxI8fFQJD1jVj8K0= In-Reply-To: <20240724132415.1700386-1-andrei.stefanescu@oss.nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240726_095402_304274_B83C9024 X-CRM114-Status: GOOD ( 16.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/07/2024 15:24, Andrei Stefanescu wrote: > Add the pinctrl node in the device tree in order to enable the > S32G2/S32G3 pinctrl driver to probe. > > Signed-off-by: Andrei Stefanescu Reviewed-by: Matthias Brugger > --- > V2 -> V1: moved the pinctrl node before the uart1 one to sort based > on the reg value, removed the status property, renamed the > jtag_pins node and jtag_grp* subnodes > > arch/arm64/boot/dts/freescale/s32g2.dtsi | 50 +++++++++++++++++++++++ > arch/arm64/boot/dts/freescale/s32g3.dtsi | 52 +++++++++++++++++++++++- > 2 files changed, 101 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/s32g2.dtsi b/arch/arm64/boot/dts/freescale/s32g2.dtsi > index fc19ae2e8d3b..fa054bfe7d5c 100644 > --- a/arch/arm64/boot/dts/freescale/s32g2.dtsi > +++ b/arch/arm64/boot/dts/freescale/s32g2.dtsi > @@ -114,6 +114,56 @@ soc@0 { > #size-cells = <1>; > ranges = <0 0 0 0x80000000>; > > + pinctrl: pinctrl@4009c240 { > + compatible = "nxp,s32g2-siul2-pinctrl"; > + /* MSCR0-MSCR101 registers on siul2_0 */ > + reg = <0x4009c240 0x198>, > + /* MSCR112-MSCR122 registers on siul2_1 */ > + <0x44010400 0x2c>, > + /* MSCR144-MSCR190 registers on siul2_1 */ > + <0x44010480 0xbc>, > + /* IMCR0-IMCR83 registers on siul2_0 */ > + <0x4009ca40 0x150>, > + /* IMCR119-IMCR397 registers on siul2_1 */ > + <0x44010c1c 0x45c>, > + /* IMCR430-IMCR495 registers on siul2_1 */ > + <0x440110f8 0x108>; > + > + jtag_pins: jtag-pins { > + jtag-grp0 { > + pinmux = <0x0>; > + input-enable; > + bias-pull-up; > + slew-rate = <166>; > + }; > + > + jtag-grp1 { > + pinmux = <0x11>; > + slew-rate = <166>; > + }; > + > + jtag-grp2 { > + pinmux = <0x40>; > + input-enable; > + bias-pull-down; > + slew-rate = <166>; > + }; > + > + jtag-grp3 { > + pinmux = <0x23c0>, > + <0x23d0>, > + <0x2320>; > + }; > + > + jtag-grp4 { > + pinmux = <0x51>; > + input-enable; > + bias-pull-up; > + slew-rate = <166>; > + }; > + }; > + }; > + > uart0: serial@401c8000 { > compatible = "nxp,s32g2-linflexuart", > "fsl,s32v234-linflexuart"; > diff --git a/arch/arm64/boot/dts/freescale/s32g3.dtsi b/arch/arm64/boot/dts/freescale/s32g3.dtsi > index c1b08992754b..b4226a9143c8 100644 > --- a/arch/arm64/boot/dts/freescale/s32g3.dtsi > +++ b/arch/arm64/boot/dts/freescale/s32g3.dtsi > @@ -1,6 +1,6 @@ > // SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) > /* > - * Copyright 2021-2023 NXP > + * Copyright 2021-2024 NXP > * > * Authors: Ghennadi Procopciuc > * Ciprian Costea > @@ -171,6 +171,56 @@ soc@0 { > #size-cells = <1>; > ranges = <0 0 0 0x80000000>; > > + pinctrl: pinctrl@4009c240 { > + compatible = "nxp,s32g2-siul2-pinctrl"; > + /* MSCR0-MSCR101 registers on siul2_0 */ > + reg = <0x4009c240 0x198>, > + /* MSCR112-MSCR122 registers on siul2_1 */ > + <0x44010400 0x2c>, > + /* MSCR144-MSCR190 registers on siul2_1 */ > + <0x44010480 0xbc>, > + /* IMCR0-IMCR83 registers on siul2_0 */ > + <0x4009ca40 0x150>, > + /* IMCR119-IMCR397 registers on siul2_1 */ > + <0x44010c1c 0x45c>, > + /* IMCR430-IMCR495 registers on siul2_1 */ > + <0x440110f8 0x108>; > + > + jtag_pins: jtag-pins { > + jtag-grp0 { > + pinmux = <0x0>; > + input-enable; > + bias-pull-up; > + slew-rate = <166>; > + }; > + > + jtag-grp1 { > + pinmux = <0x11>; > + slew-rate = <166>; > + }; > + > + jtag-grp2 { > + pinmux = <0x40>; > + input-enable; > + bias-pull-down; > + slew-rate = <166>; > + }; > + > + jtag-grp3 { > + pinmux = <0x23c0>, > + <0x23d0>, > + <0x2320>; > + }; > + > + jtag-grp4 { > + pinmux = <0x51>; > + input-enable; > + bias-pull-up; > + slew-rate = <166>; > + }; > + }; > + }; > + > uart0: serial@401c8000 { > compatible = "nxp,s32g3-linflexuart", > "fsl,s32v234-linflexuart";