From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83227C07E96 for ; Tue, 6 Jul 2021 13:46:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4941661C85 for ; Tue, 6 Jul 2021 13:46:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4941661C85 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YUNSSrHyUbay5YgvM6yBUMs+CpUYjL+KvUSiCEt58Rg=; b=QBelvzJjuPUZx5bKoZPAq5ySDI 51AKSv4ASvNKVQI0+wyRlcKi2Udux6KftpUEMz082BtH9QU3ZraA19KJANDLzmW4nViJVYZxld5IX beyxZLj16C6EONi6jP0UV+4kxq4RsMXQGxXNvdI2shKUMFoy4ZvuHGLKhUCmGOVb19mxLoxSXE+YM jmu8F7bxC4nBsFpBTkh2gEy/Ps/oU5yo6hzQmtnOkUDBNOMsSybnnSHYbrVE3D3W+axmzjEuFdY0V bPlSpoY8nMvniOqSvlIb+Y1Eem0ojZhcy2VvVm/y1esTUz373TVPwgFTwExAIuoruO1wQh6mZOsCZ vH2CRaLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0lNA-00BuzG-UE; Tue, 06 Jul 2021 13:44:25 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0lN7-00Buyf-Ef for linux-arm-kernel@lists.infradead.org; Tue, 06 Jul 2021 13:44:22 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0536861CA4; Tue, 6 Jul 2021 13:44:21 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1m0lN4-00Bk1C-Tp; Tue, 06 Jul 2021 14:44:19 +0100 MIME-Version: 1.0 Date: Tue, 06 Jul 2021 14:44:18 +0100 From: Marc Zyngier To: Will Deacon Cc: Robin Murphy , Catalin Marinas , Yassine Oudjana , ardb@kernel.org, arnd@arndb.de, kernel-team@android.com, linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, vincent.whitchurch@axis.com, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH] arm64: cache: Lower ARCH_DMA_MINALIGN to 64 (L1_CACHE_BYTES) In-Reply-To: <20210706133314.GB20327@willie-the-truck> References: <20210527124356.22367-1-will@kernel.org> <20210706102634.GB24903@arm.com> <59800d6c-364a-f4be-e341-c5b531657ba3@arm.com> <20210706133314.GB20327@willie-the-truck> User-Agent: Roundcube Webmail/1.4.11 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: will@kernel.org, robin.murphy@arm.com, catalin.marinas@arm.com, y.oudjana@protonmail.com, ardb@kernel.org, arnd@arndb.de, kernel-team@android.com, linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com, vincent.whitchurch@axis.com, linux-arm-msm@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210706_064421_578458_CD56C4B1 X-CRM114-Status: GOOD ( 26.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-07-06 14:33, Will Deacon wrote: > On Tue, Jul 06, 2021 at 02:29:07PM +0100, Robin Murphy wrote: >> On 2021-07-06 11:26, Catalin Marinas wrote: >> > On Tue, Jul 06, 2021 at 09:26:59AM +0000, Yassine Oudjana wrote: >> > > In-Reply-To: <20210527124356.22367-1-will@kernel.org> >> > > > Reduce ARCH_DMA_MINALIGN to 64 bytes and allow the warning/taint to >> > > > indicate if there are machines that unknowingly rely on this. >> > > >> > > The warning is being triggered on Qualcomm MSM8996, as well as the out-of-spec taint: >> > >> > Is this booting with ACPI or DT? >> > >> > > ------------[ cut here ]------------ >> > > rtc-pm8xxx 400f000.qcom,spmi:pmic@0:rtc@6000: ARCH_DMA_MINALIGN smaller than CTR_EL0.CWG (64 < 128) >> > > WARNING: CPU: 0 PID: 1 at arch/arm64/mm/dma-mapping.c:45 arch_setup_dma_ops+0xf8/0x10c >> > [...] >> > > This warning is triggered with nearly every driver probe, not only rtc-pm8xxx. >> > >> > I have a suspicion none of the reported devices actually do any DMA, so >> > in practice it should be safe but we need to figure out why >> > arch_setup_dma_ops() gets called. >> >> It gets called because there's no straightforward way to know that a >> platform device *isn't* DMA-capable, so we have to assume they are. >> >> I would also assume that in a Qcom SoC there really are at least some >> things >> doing non-coherent DMA :( > > Agreed, unless this is a CPU erratum and the line size is being > reported for > a cache beyond the PoC, then I think we're going to have to revert the > patch > reducing ARCH_DMA_MINALIGN after all. > > I can't find much information about the original Kryo core at all... I have similar issues with my QDF2400. The UART, RTC and DMA controllers are all screaming at me. I'm confident that the UART doesn't do any DMA (it is handled by the SBSA driver), but the DMA controllers are probably doing what it says on the tin. Do we know whether Falkor and Kryo share any part of their design? M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel