From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E94FC43334 for ; Sun, 12 Jun 2022 15:10:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Jt4VFiuIV7BHdusnTx28um0PAuqUb1L1fRpprJs3bmM=; b=iqOI4CDdupCZ7buOCBe9oiC8n/ AzWilCIF1kBGOmyWsz1H5cj0+m3xBoLaigFBJcVkYjAkMOUOxEW+LpIlY5p7jDFqrcoE2/XsjbHHN ng3UBKY4R4gTSkjrWvfYXVLbdXIueT0J50ABWssSlvYRxgdPNbAPHr/Bh33eZqW6wxVP0GZi7/jXD VjYNtw5NbzDVs6HhdDd78i1IGLe/C9Y64avWZr6fLrhsYpuufw/Au1j/TrFESJLzmNXw4abkOOHBG jjLTHqE8zUiaxUXTypE/VIH9JKSGTN48pa+O2foo2s1wbTCctiE0l3XspVAVvGj2rNxZwX87fqOf5 8wbwdj0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0PDu-00Gsh0-BP; Sun, 12 Jun 2022 15:09:54 +0000 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0PDr-00GsgE-W2 for linux-arm-kernel@lists.infradead.org; Sun, 12 Jun 2022 15:09:53 +0000 Received: by mail-lj1-x22a.google.com with SMTP id d19so3789615lji.10 for ; Sun, 12 Jun 2022 08:09:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=kR1FFXBNuVcnI+XFY+UkNzwK+20t6KACUWQ6sh+8W7w=; b=WfraHZESA0Ns7l45yKXsRgqhPj9UEGMkb4W3PHOlB5YUfLBdjEXyXoQWqAyC5NrrKG UlHC0uTDbvzVcGAJsGuVa7FEcCfd95CKX77qu1foVsL3VnAUbf76XGPp8r4VHmRpL7Az lJcG7P5Xdm1PcJFhlUoZPr/q2345HtFzIOXXtmMkXUH00EiSksXaqt/ivRkuk/gu9AEg SDdKZrYfttipfh/chG8wOEhamYi2mNghpO9Y+Idku5yHoYiUazlqR09NlPw4YEf/jJXX eX1qcPeq4ZUL0nEBOlOelXFfMYkfo3ZzTFoT0q4+uTVB/kLkQ+1ZXWzmW/XSw1imA9aH dhSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=kR1FFXBNuVcnI+XFY+UkNzwK+20t6KACUWQ6sh+8W7w=; b=Z67l63hd2URbAGK7bK2ZZaESY2DtZkdR2jkn1oBf/4HJ55K8DjkeLcl19Yrmt4cDL2 TczhKTjmCDd+QaF8KVWFi1PdT7zEihRvN1OnGmzdEuUF8ykNuj9ElyQ/xIQCQN1slAWF scMSjAXy7BU9HhsD823OlZi0GWwkvRfgBfbKh3jWUDJTSJiVj+6s3+djPCAaoJ1kXEQm 0dvnoEFSPYVYKwAps3/Spb5GgGQdlrMn06emnbkZFXxQES+TOtSM+kvMUpXXzGclDw5C nirR26YJ6piTwThhTYgBs78tr31i8idsW3aZEln5K9xGlvkqgCB9SWa6n5HEuUMmnvEv WatQ== X-Gm-Message-State: AOAM531HO9q0X5JKIVFzvnYBKN3gew9AGfyA56OTgYuvXCOiZ0nR/Rz+ zV1+0MXM5dGrrFGjZnSJKA0= X-Google-Smtp-Source: ABdhPJwUeaIP09kg///zZLbr4I7t7Kkm58sR3kj+eU1oSGhbUcursPA4tzEXpO1EP0GCLBmzgRzo9w== X-Received: by 2002:a2e:8501:0:b0:249:17a0:ebf8 with SMTP id j1-20020a2e8501000000b0024917a0ebf8mr67356763lji.125.1655046589721; Sun, 12 Jun 2022 08:09:49 -0700 (PDT) Received: from [192.168.0.131] ([194.183.54.57]) by smtp.gmail.com with ESMTPSA id q11-20020ac2510b000000b00478f739f1fdsm640278lfb.103.2022.06.12.08.09.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Jun 2022 08:09:49 -0700 (PDT) Message-ID: Date: Sun, 12 Jun 2022 17:09:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 3/3] ARM: dts: exynos: add function and color to aat1290 flash LED node in Galaxy S3 Content-Language: en-US To: Krzysztof Kozlowski , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20220607085343.72414-1-krzysztof.kozlowski@linaro.org> <20220607085343.72414-3-krzysztof.kozlowski@linaro.org> <4a7f8ab6-c061-3861-5790-b6c0fbd7cad1@gmail.com> From: Jacek Anaszewski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220612_080952_081282_A0C87997 X-CRM114-Status: GOOD ( 19.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/10/22 12:14, Krzysztof Kozlowski wrote: > On 09/06/2022 22:31, Jacek Anaszewski wrote: >> Hi Krzysztof, >> >> On 6/7/22 10:53, Krzysztof Kozlowski wrote: >>> Add common LED properties - the function and color - to aat1290 flash >>> LED node in Galaxy S3. >>> >>> Signed-off-by: Krzysztof Kozlowski >>> --- >>> arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi >>> index 72901772fcad..d76f3678dcab 100644 >>> --- a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi >>> +++ b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi >>> @@ -7,6 +7,7 @@ >>> */ >>> >>> /dts-v1/; >>> +#include >>> #include "exynos4412-midas.dtsi" >>> >>> / { >>> @@ -27,6 +28,8 @@ led-controller { >>> >>> led { >>> label = "flash"; >>> + function = LED_FUNCTION_FLASH; >>> + color = ; >> >> Addition of these two properties will not change anything because >> the label has precedence. It is deprecated, but if you introduce >> function and color to the binding instead of the label, the resulting >> LED class device name will change. > > Which is not necessarily what we want, right? Adding these properties is > a proper description of hardware, regardless whether current Linux > implementation uses them or not. Actually I'd just drop label in addition to your change. I don't think it would break anybody seriously - not expecting it has any larger group of users and having uniformly constructed DTS files in the mainline has greater value. -- Best regards, Jacek Anaszewski _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel