From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE575EB64D7 for ; Wed, 28 Jun 2023 15:53:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hpXIwQwSXnQUegAuLdQ4SPkJni2P8rOlTuUKE33nJz4=; b=FBtdGq1i0mAE4y ukPegaErlAqLA8zs3rGK56CB2WVL/8gGjTd6V5OpGMva8IScGRRSlJLPXPos5hLhnNu2gMup72Rs3 A9wIPe2pRkav03gNYlsenpUeFRWr8qpKWOe52AtmjN9ElUm0LWtkGo3AHBz/CUFP1AhmA5rduuxs/ v3AXmusovy+oyV4fIpwD8n1UW8XBmi0LOE3aJojodaMlR0oHh7xXiWpqbtVtwPphZg3Ox6YRYQA4V W4HBqCoVks/AMXoe/RAwbIQ8Lm7tJAar6Br9V4W4ASKfzSMHnR80xe547sbNijLqv0ODoDxb4CZ9r YpkwhMBH/LbcwAvqbHIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qEXTS-00G2Cg-36; Wed, 28 Jun 2023 15:52:54 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qEXTP-00G2C7-32 for linux-arm-kernel@lists.infradead.org; Wed, 28 Jun 2023 15:52:53 +0000 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 35SCfvsm031492; Wed, 28 Jun 2023 15:51:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=qcppdkim1; bh=mM/crjBuJsdgjSMJGD01XqtrFQ+ghm/v2ibK3En1ebw=; b=CtBItgC4v3LavzcTPGecFuF9lmgrh8+n+yDxqKxNIglJczlH8g901XepekBF051nazjy jbYPFOP9d5OcduOXTnbbsDfJqrowueyINouj5IQ9BlqNbAteFGIzoc+nbdpESvIiSqC8 hpozP/J3yt5GT5yN/Zv+fvKapm1JkAt3hzclz8Z6zV50VY74sjGfGSmwtKspJevE8N+R k8Pwt9AcEBdpJF5PoFyhlOkXUzaRFT2FG0QJQFnQygwfxmEbZcjU8GqVMcOk1p/bledK PN70XU5bpb+T1XnQdFbeYNIr6FSgpitm0mShQ3FkFbirrFO9sRkyc5GmBU1IomuciD2X EA== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rg21taxyc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Jun 2023 15:51:56 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 35SFptJR030238 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Jun 2023 15:51:55 GMT Received: from hu-pkondeti-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.7; Wed, 28 Jun 2023 08:51:47 -0700 Date: Wed, 28 Jun 2023 21:21:44 +0530 From: Pavan Kondeti To: Mukesh Ojha CC: , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v4 13/21] remoterproc: qcom: refactor to leverage exported minidump symbol Message-ID: References: <1687955688-20809-1-git-send-email-quic_mojha@quicinc.com> <1687955688-20809-14-git-send-email-quic_mojha@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1687955688-20809-14-git-send-email-quic_mojha@quicinc.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: Pu4d_6xM3tTmi2m1FvajyDnk7XcT6zwO X-Proofpoint-GUID: Pu4d_6xM3tTmi2m1FvajyDnk7XcT6zwO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-06-28_10,2023-06-27_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=973 phishscore=0 adultscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 mlxscore=0 bulkscore=0 malwarescore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2306280141 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230628_085251_987810_3706BEB3 X-CRM114-Status: GOOD ( 23.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 28, 2023 at 06:04:40PM +0530, Mukesh Ojha wrote: > -static int qcom_add_minidump_segments(struct rproc *rproc, struct minidump_subsystem *subsystem, > - void (*rproc_dumpfn_t)(struct rproc *rproc, struct rproc_dump_segment *segment, > - void *dest, size_t offset, size_t size)) > +void qcom_minidump(struct rproc *rproc, unsigned int minidump_id, > + void (*rproc_dumpfn_t)(struct rproc *rproc, > + struct rproc_dump_segment *segment, void *dest, size_t offset, > + size_t size)) > { > - struct minidump_region __iomem *ptr; > - struct minidump_region region; > - int seg_cnt, i; > dma_addr_t da; > size_t size; > + int seg_cnt; > char *name; > + void *ptr; > + int ret; > + int i; > > if (WARN_ON(!list_empty(&rproc->dump_segments))) { > dev_err(&rproc->dev, "dump segment list already populated\n"); > - return -EUCLEAN; > + return; > } > > - seg_cnt = le32_to_cpu(subsystem->region_count); > - ptr = ioremap((unsigned long)le64_to_cpu(subsystem->regions_baseptr), > - seg_cnt * sizeof(struct minidump_region)); > + ptr = qcom_ss_md_mapped_base(minidump_id, &seg_cnt); > if (!ptr) > - return -EFAULT; > + return; > > for (i = 0; i < seg_cnt; i++) { > - memcpy_fromio(®ion, ptr + i, sizeof(region)); > - if (le32_to_cpu(region.valid) == MINIDUMP_REGION_VALID) { > - name = kstrndup(region.name, MAX_REGION_NAME_LENGTH - 1, GFP_KERNEL); > - if (!name) { > - iounmap(ptr); > - return -ENOMEM; > - } > - da = le64_to_cpu(region.address); > - size = le64_to_cpu(region.size); > - rproc_coredump_add_custom_segment(rproc, da, size, rproc_dumpfn_t, name); > + ret = qcom_ss_valid_segment_info(ptr, i, &name, &da, &size); > + if (ret < 0) { > + iounmap(ptr); > + dev_err(&rproc->dev, > + "Failed with error: %d while adding minidump entries\n", > + ret); > + goto clean_minidump; > } > - } > - > - iounmap(ptr); > - return 0; > -} > - > -void qcom_minidump(struct rproc *rproc, unsigned int minidump_id, > - void (*rproc_dumpfn_t)(struct rproc *rproc, > - struct rproc_dump_segment *segment, void *dest, size_t offset, > - size_t size)) > -{ > - int ret; > - struct minidump_subsystem *subsystem; > - struct minidump_global_toc *toc; > - > - /* Get Global minidump ToC*/ > - toc = qcom_smem_get(QCOM_SMEM_HOST_ANY, SBL_MINIDUMP_SMEM_ID, NULL); > - > - /* check if global table pointer exists and init is set */ > - if (IS_ERR(toc) || !toc->status) { > - dev_err(&rproc->dev, "Minidump TOC not found in SMEM\n"); > - return; > - } > > - /* Get subsystem table of contents using the minidump id */ > - subsystem = &toc->subsystems[minidump_id]; > - > - /** > - * Collect minidump if SS ToC is valid and segment table > - * is initialized in memory and encryption status is set. > - */ > - if (subsystem->regions_baseptr == 0 || > - le32_to_cpu(subsystem->status) != 1 || > - le32_to_cpu(subsystem->enabled) != MINIDUMP_SS_ENABLED || > - le32_to_cpu(subsystem->encryption_status) != MINIDUMP_SS_ENCR_DONE) { > - dev_err(&rproc->dev, "Minidump not ready, skipping\n"); > - return; > + /* if it is a valid segment */ > + if (!ret) > + rproc_coredump_add_custom_segment(rproc, da, size, > + rproc_dumpfn_t, name); > } > > - ret = qcom_add_minidump_segments(rproc, subsystem, rproc_dumpfn_t); > - if (ret) { > - dev_err(&rproc->dev, "Failed with error: %d while adding minidump entries\n", ret); > - goto clean_minidump; > - } > + iounmap(ptr); > rproc_coredump_using_sections(rproc); > + > clean_minidump: > qcom_minidump_cleanup(rproc); > } I like the idea of moving minidump pieces to drivers/soc/qcom/*minidump*. Is it possible to accept one function callback from remoteproc and do all of this in one function exported by minidump? qcom_ss_valid_segment_info() seems a low level function to be exported.. Thanks, Pavan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel