From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "Macpaul Lin (林智斌)" <Macpaul.Lin@mediatek.com>,
"Peter Wang (王信友)" <peter.wang@mediatek.com>,
"chu.stanley@gmail.com" <chu.stanley@gmail.com>,
"robh@kernel.org" <robh@kernel.org>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"avri.altman@wdc.com" <avri.altman@wdc.com>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>
Cc: "macpaul@gmail.com" <macpaul@gmail.com>,
"Pablo Sun (孫毓翔)" <pablo.sun@mediatek.com>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"Bear Wang (萩原惟德)" <bear.wang@mediatek.com>,
"Ramax Lo (羅明遠)" <Ramax.Lo@mediatek.com>
Subject: Re: [PATCH v2 3/4] dt-bindings: ufs: mediatek,ufs: add MT8195 compatible and update clock nodes
Date: Wed, 23 Jul 2025 10:10:02 +0200 [thread overview]
Message-ID: <f1589156-7e4a-4f47-88a1-8c51f6594366@collabora.com> (raw)
In-Reply-To: <845f204b2b2e39b794cdb9c0f3293dc8cba7286a.camel@mediatek.com>
Il 23/07/25 09:33, Macpaul Lin (林智斌) ha scritto:
> On Tue, 2025-07-22 at 11:39 +0200, AngeloGioacchino Del Regno wrote:
>>
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>
> [snip...]
>
>> The unipro mp_bclk really is the ufs-sap clock; besides, the standard
>> has clocks
>> for both TX and RX symbols - and also MT8195 (and also MT6991,
>> MT8196, and others)
>> UFS controller do have both TX and RX symbol clocks.
>>
>> Besides, you're also missing the crypto clocks for UFS, which brings
>> the count to
>> 12 total clocks for MT8195.
>>
>> Please, look at my old submission, which actually fixes the
>> compatibles other than
>> adding the right clocks for all UFS controllers in MediaTek
>> platforms.
>>
>> https://lore.kernel.org/all/20240612074309.50278-1-angelogioacchino.delregno@collabora.com/
>>
>> I want to take the occasion to remind everyone that my fixes were
>> discarded because
>> the MediaTek UFS driver maintainer wants to keep the low quality of
>> the driver in
>> favor of easier downstream porting - which is *not* in any way
>> adhering to quality
>> standards that the Linux community deserves.
>>
>
> Oops, it is sad to hear that.
> MediaTek will raise an internal discussion and hope
> we could get the more specific requirements back to you soon.
>
Thanks for that.
Cheers,
Angelo
next prev parent reply other threads:[~2025-07-23 8:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 8:57 [PATCH v2 1/4] scsi: ufs: ufs-mediatek: Add UFS host support for MT8195 SoC Macpaul Lin
2025-07-22 8:57 ` [PATCH v2 2/4] dt-bindings: ufs: mediatek,ufs: add ufs-disable-mcq flag for UFS host Macpaul Lin
2025-07-23 4:45 ` Rob Herring (Arm)
2025-07-23 9:33 ` Peter Wang (王信友)
2025-07-22 8:57 ` [PATCH v2 3/4] dt-bindings: ufs: mediatek,ufs: add MT8195 compatible and update clock nodes Macpaul Lin
2025-07-22 9:39 ` AngeloGioacchino Del Regno
2025-07-23 4:50 ` Rob Herring
2025-07-23 7:33 ` Macpaul Lin (林智斌)
2025-07-23 8:10 ` AngeloGioacchino Del Regno [this message]
2025-07-23 9:41 ` Peter Wang (王信友)
2025-10-19 10:19 ` Krzysztof Kozlowski
2025-10-20 8:13 ` Peter Wang (王信友)
2025-10-20 8:28 ` Krzysztof Kozlowski
2025-10-20 9:44 ` Peter Wang (王信友)
2025-10-20 9:56 ` Krzysztof Kozlowski
2025-10-20 10:46 ` Peter Wang (王信友)
2025-10-20 11:04 ` AngeloGioacchino Del Regno
2025-10-20 11:46 ` Peter Wang (王信友)
2025-10-20 10:02 ` Krzysztof Kozlowski
2025-10-20 10:49 ` Peter Wang (王信友)
2025-07-22 8:57 ` [PATCH v2 4/4] arm64: dts: mediatek: mt8195: add UFSHCI node Macpaul Lin
2025-07-23 9:34 ` Peter Wang (王信友)
2025-07-23 9:33 ` [PATCH v2 1/4] scsi: ufs: ufs-mediatek: Add UFS host support for MT8195 SoC Peter Wang (王信友)
2025-07-31 4:44 ` Martin K. Petersen
2025-10-20 15:40 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1589156-7e4a-4f47-88a1-8c51f6594366@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Macpaul.Lin@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Ramax.Lo@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bear.wang@mediatek.com \
--cc=bvanassche@acm.org \
--cc=chu.stanley@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=macpaul@gmail.com \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=pablo.sun@mediatek.com \
--cc=peter.wang@mediatek.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox